OpenACS / openacs-4 / packages

general-comments

Tools

Line History

Line Count Graph
Line Count Graph

Stats

Commits this week: 0
Total Committers: 27
Last Commit: 27 Dec
Commits this week: 0
Total Lines of Code (LoC): 9,764
Net change in LoC this week: 0

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated 10 hours ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Thursday 28 Jun 2018
12:39 pm

hectorr

Prefer 'person::name' to 'acs_user::get_element ... -name'

Options
    • -4
    • +4
    ./tcl/general-comments-procs.tcl
    • -2
    • +2
    ./www/delete.tcl
    • -2
    • +2
    ./www/view-comment.tcl
    • -2
    • +2
    ./www/admin/delete.tcl
    • -2
    • +2
    ./www/admin/index.tcl
  6. … 4 more files in changeset.
Wednesday 27 Jun 2018
6:11 pm

hectorr

Prefer again 'person::name', as the proc has been reimplemented using 'person::get_person_info', which uses the new 'person_info_cache' cache.

Options
    • -2
    • +2
    ./www/index.tcl
  2. … 13 more files in changeset.
Tuesday 19 Jun 2018
3:45 pm

hectorr

Whitespace changes

Options
    • -29
    • +29
    ./www/index.tcl
  2. … 11 more files in changeset.
3:35 pm

hectorr

Prefer 'acs_user::get_element ...' to 'person::name ...', in cases when 'person' is a user, as it doesn't rely on util_memoize_cache.

Options
    • -2
    • +2
    ./www/index.tcl
  2. … 13 more files in changeset.
11:51 am

antoniop

Similar to www/index page:

- remove divergency between oracle and postgres code

- improve localization

- add author column to UI as was probably meant to be (author was selected, but not used)

- use multirow builtin count instead of manually generated one

Options
    • -29
    • +0
    ./www/admin/index-oracle.xql
    • -28
    • +0
    ./www/admin/index-postgresql.xql
    • -11
    • +39
    ./www/admin/index.tcl
11:35 am

antoniop

Remove divergency between oracle and postgres codebase

Options
    • -28
    • +0
    ./www/admin/delete-oracle.xql
    • -26
    • +0
    ./www/admin/delete-postgresql.xql
    • -10
    • +10
    ./www/admin/delete.tcl
9:58 am

antoniop

Remove leftover xql and prefer acs_user::get api, as doesn't rely on util_memoize cache

Options
    • -28
    • +0
    ./www/delete-oracle.xql
    • -26
    • +0
    ./www/delete-postgresql.xql
    • -9
    • +8
    ./www/delete.tcl
Wednesday 13 Jun 2018
4:22 pm

antoniop

Make filters consistent with what the list displays (approved means live_revision not nulll and latest revision = live_revision)

Options
    • -6
    • +4
    ./www/index.xql
4:14 pm

antoniop

UI improvements and fix

- make sql portable

- bring all sql inline

- reduce query duplication

- simplify if idioms

- fix UI by unclobbering revision_id variable and allowing to select revision correctly

Options
    • -64
    • +0
    ./www/view-comment-oracle.xql
    • -63
    • +0
    ./www/view-comment-postgresql.xql
    • -32
    • +47
    ./www/view-comment.tcl
    • -55
    • +0
    ./www/view-comment.xql
3:40 pm

antoniop

Improvement and fixes for this UI

- improve localization

- exploit builtin multirow feature

- reduce divergencies between oracle and postgres codebase

- remove unused sql columns

- invert boolean logics for approved and live to reflect sql clause behavior

Options
    • -30
    • +0
    ./www/index-oracle.xql
    • -28
    • +0
    ./www/index-postgresql.xql
    • -11
    • +10
    ./www/index.tcl
    • -0
    • +22
    ./www/index.xql
Monday 11 Jun 2018
5:15 pm

antoniop

Use cached user api to retrieve comment author

Options
    • -2
    • +2
    ./tcl/general-comments-procs.tcl
5:08 pm

gustafn

file general-comments-procs-oracle.xql was added on branch oacs-5-10 on 2019-02-16 09:33:45 +0000

Options
    • -0
    • +0
    ./tcl/general-comments-procs-oracle.xql
5:08 pm

gustafn

file general-comments-procs-postgresql.xql was added on branch oacs-5-10 on 2019-02-16 09:33:45 +0000

Options
    • -0
    • +0
    ./tcl/general-comments-procs-postgresql.xql
5:08 pm

antoniop

Resurrect xql files lost in previous commit, reduce differences between oracle and postgres codebase

Options
    • -0
    • +37
    ./tcl/general-comments-procs-oracle.xql
    • -0
    • +39
    ./tcl/general-comments-procs-postgresql.xql
    • -2
    • +3
    ./tcl/general-comments-procs.tcl
Wednesday 06 Jun 2018
6:03 pm

hectorr

Do not trust 'print_attachments_p'

Options
    • -1
    • +1
    ./lib/comments.adp
Tuesday 22 May 2018
7:30 pm

hectorr

Rework adp boolean expressions

Options
    • -1
    • +1
    ./www/view-comment.adp
  2. … 25 more files in changeset.
5:59 pm

hectorr

Prefer literal in adp axpressions + Whitespace changes

Options
    • -1
    • +1
    ./lib/comments.adp
  2. … 29 more files in changeset.
5:13 pm

hectorr

Prefer literal in adp axpressions

Options
    • -3
    • +3
    ./www/test.adp
    • -6
    • +6
    ./www/view-comment.adp
  3. … 8 more files in changeset.
Wednesday 16 May 2018
1:56 pm

antoniop

Follow the "ugly" smell

rework of general-comments rendering so that the templating system is used, instead of handcrafted markup. Also, allow theming in the future.

Options
    • -0
    • +33
    ./lib/comments.adp
    • -96
    • +0
    ./tcl/general-comments-procs-oracle.xql
    • -101
    • +0
    ./tcl/general-comments-procs-postgresql.xql
    • -124
    • +61
    ./tcl/general-comments-procs.tcl
    • -33
    • +4
    ./tcl/general-comments-procs.xql
Tuesday 01 May 2018
10:49 am

gustafn

make spelling more consistent

Options
    • -2
    • +2
    ./tcl/general-comments-procs.tcl
    • -2
    • +2
    ./www/url-add-2.tcl
    • -2
    • +2
    ./www/url-add.tcl
    • -2
    • +2
    ./www/url-edit.tcl
10:45 am

gustafn

regenerated documentation

Options
    • -1
    • +1
    ./www/doc/design.adp
    • -2
    • +2
    ./www/doc/dev-guide.adp
  3. … 27 more files in changeset.
Tuesday 24 Apr 2018
6:13 pm

hectorr

Rework variable assignment (set -> lassign) + Whitespace changes

Options
    • -8
    • +7
    ./www/file-add-2.tcl
  2. … 3 more files in changeset.
Monday 26 Mar 2018
12:39 am

hectorr

Fix typos

Options
    • -2
    • +2
    ./www/comment-add.tcl
    • -2
    • +2
    ./www/comment-edit.tcl
Saturday 20 Jan 2018
11:49 pm

gustafn

Fix boolean expressions in -adp files, make termination after connection closing commands explicit

Options
    • -1
    • +2
    ./www/comment-edit.tcl
    • -1
    • +2
    ./www/delete.tcl
    • -1
    • +2
    ./www/file-download.tcl
    • -3
    • +2
    ./www/url-edit.tcl
    • -1
    • +3
    ./www/view-comment.tcl
    • -1
    • +2
    ./www/admin/delete.tcl
    • -2
    • +2
    ./www/admin/index.tcl
  8. … 12 more files in changeset.
Wednesday 22 Nov 2017
3:13 pm

antoniop

Reduce divergencies between oracle and postgres codebase

Options
    • -27
    • +0
    ./www/index-oracle.xql
    • -27
    • +1
    ./www/index-postgresql.xql
    • -11
    • +34
    ./www/index.xql
    • -26
    • +0
    ./www/admin/index-oracle.xql
    • -26
    • +1
    ./www/admin/index-postgresql.xql
    • -16
    • +39
    ./www/admin/index.xql
  7. … 3 more files in changeset.
Tuesday 08 Aug 2017
1:47 am

gustafn

merged changes from the oacs-5-9 branch and resolved conflicts

Options
    • -7
    • +7
    ./general-comments.info
    • -6
    • +7
    ./catalog/general-comments.de_DE.ISO-8859-1.xml
    • -0
    • +1
    ./catalog/general-comments.en_US.ISO-8859-1.xml
    • -3
    • +4
    ./catalog/general-comments.es_ES.ISO-8859-1.xml
    • -8
    • +9
    ./catalog/general-comments.it_IT.ISO-8859-1.xml
    • -1
    • +7
    ./tcl/general-comments-callback-procs.tcl
    • -1
    • +2
    ./tcl/general-comments-procs-oracle.xql
    • -1
    • +1
    ./tcl/general-comments-procs-postgresql.xql
    • -7
    • +11
    ./tcl/general-comments-procs.tcl
    • -2
    • +8
    ./www/comment-add-2.tcl
    • -2
    • +8
    ./www/comment-add-3.tcl
    • -2
    • +8
    ./www/comment-add.tcl
    • -3
    • +3
    ./www/comment-ae.adp
    • -2
    • +8
    ./www/comment-edit-2.tcl
    • -2
    • +8
    ./www/comment-edit-3.tcl
  16. … 7820 more files in changeset.
Sunday 06 Aug 2017
1:31 pm

gustafn

regenerated ducumentation

Options
    • -28
    • +28
    ./www/doc/design.adp
    • -8
    • +8
    ./www/doc/dev-guide.adp
  3. … 250 more files in changeset.
1:17 pm

gustafn

- do not depend on beta or development versions

- make sure that released versions are not beta or development

- align version numbers (e.g. use also 5.9.1 for xotcl-core)

- bump version numbers to 5.9.1

Options
    • -7
    • +7
    ./general-comments.info
  2. … 83 more files in changeset.
Monday 24 Jul 2017
12:30 pm

gustafn

bump version numbers to 5.9.1b9 respectively to 2.9.1b9 to prepare for release

Options
    • -6
    • +6
    ./general-comments.info
  2. … 91 more files in changeset.
Friday 21 Apr 2017
10:11 pm

gustafn

Fix spelling errors

Options
    • -1
    • +1
    ./tcl/general-comments-callback-procs.tcl
    • -2
    • +2
    ./www/delete-attachment-2.tcl
    • -4
    • +4
    ./www/doc/design.adp
    • -5
    • +5
    ./www/doc/design.html
    • -5
    • +5
    ./www/doc/design.xml
    • -3
    • +3
    ./www/doc/dev-guide.adp
    • -4
    • +4
    ./www/doc/dev-guide.html
    • -4
    • +4
    ./www/doc/requirements.xml
  9. … 9 more files in changeset.