• last updated 2 hours ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
file upgrade-1.1.5d1-1.1.5d2.sql was initially added on branch oacs-5-10.

file webtest-procs.tcl was initially added on branch oacs-5-10.

file upgrade-1.1.4-1.1.5d1.sql was initially added on branch oacs-5-10.

file upgrade-5.10.0d6-5.10.0d7.sql was initially added on branch oacs-5-10.

file upgrade-5.10.0d1-5.10.0d2.sql was initially added on branch oacs-5-10.

provide named arguments for stored procedures to reduce warnings with recent versions of OpenACS

file index.xql was initially added on branch oacs-5-10.

    • -0
    • +0
    /openacs-4/packages/acs-lang/www/admin/index.xql
Fix 3 inconsistent log messages in the test

Prefer portable current_timestamp idiom to NOW()

Exploit existing acs::test::user::create api

Normalize indentation, add editor hints

    • -10
    • +17
    /openacs-4/packages/xolp/tcl/xolp-iri-procs.tcl
    • -0
    • +7
    /openacs-4/packages/xolp/tcl/xolp-procs.tcl
    • -31
    • +38
    /openacs-4/packages/xolp/tcl/xolp-user-procs.tcl
    • -10
    • +17
    /openacs-4/packages/xolp/tcl/xolp-util-procs.tcl
Modernize XoTcl idioms

    • -12
    • +11
    /openacs-4/packages/xolp/tcl/xolp-iri-procs.tcl
Use xotcl-core indentation convention

    • -95
    • +96
    /openacs-4/packages/xolp/tcl/xolp-apm-procs.tcl
Whitespace cleanup, normalize indentation, add editor hints

    • -94
    • +100
    /openacs-4/packages/xolp/tcl/xolp-apm-procs.tcl
Use xotcl db idioms

Rollback tests or they will interfere with the others

Reimplement query to obtain user competencies to fix xolp.user_get_competencies automated test

Personal perplexities:

- why do we specify the competency_set_id on the indicator facts? If one fact can be e.g. an exam, this might be related with multiple competency sets

- should we take into account also the validity of an activity?

    • -14
    • +36
    /openacs-4/packages/xolp/tcl/xolp-user-procs.tcl
file package-list.xql was initially added on branch oacs-5-10.

    • -0
    • +0
    /openacs-4/packages/acs-lang/www/admin/package-list.xql
Port downstream commit cab327aeda04f1f1f6b8f2310ddc88c7c081a84f from Günter Ernst:

Minor adjustments to ensure install- and uninstallability

Port of downstream commit 9cbc3f04aad075e902e64d0c67d53158160a933c from Felix Möedritscher:

feature / issue #10359: added message keys, extended the xolp API - get_competencies, get_activities_of_package, update_title

    • -0
    • +4
    /openacs-4/packages/xolp/catalog/xolp.de_DE.ISO-8859-1.xml
    • -0
    • +4
    /openacs-4/packages/xolp/catalog/xolp.en_US.ISO-8859-1.xml
Insert missing performance indicators for the user

Fix typo

As xolp_indicator_facts_check1 wants end_timestamp <= storage_timestamp, force end_timestamp some time in the past (api won't allow to specify storage_timestamp)

As the original test expects it, make sure begin timestamp and end timestamp are the same

Fix indicator_create test case:

- handle timezone correctly

- don't rely on database language

Add documentation or make procs private to please documentation__check_proc_doc test

State dependency from acs-datetime, as we use dt_* api

Init the right table

file upgrade-5.10.0d16-5.10.0d17.sql was initially added on branch oacs-5-10.

file message-undelete.adp was initially added on branch oacs-5-10.

    • -0
    • +0
    /openacs-4/packages/acs-lang/www/admin/message-undelete.adp