antoniop in OpenACS

About

903 commits
  • Committer is not mapped to a user
  • First commit: 20 November 2006
  • Last commit: 20 September 2018
Last Week All Time
Commits: 0 903
Files changed: 20 2,636
Change in LOC: 259 14,582

Line History

Line Count Graph
Line Count Graph

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 
Thursday 20 Sep
3:28 pm

antoniop

Converge render method for chat and xotcl-core package

Options
    • -21
    • +1
    /openacs-4/packages/chat/tcl/chat-ajax-procs.tcl
    • -6
    • +9
    /openacs-4/packages/xotcl-core/tcl/chat-procs.tcl
3:25 pm

antoniop

Add ':' to formatting to uniform with the render method

Options
    • -2
    • +2
    /openacs-4/packages/xowiki/www/ajax/scripted-streaming-chat.js
    • -2
    • +2
    /openacs-4/packages/xowiki/www/ajax/streaming-chat.js
3:12 pm

antoniop

Preliminary xowiki chat rework

- update javascript to comply with CSP (setInterval...)

- exploit template resource loading machinery to load javascripts

- remove code duplication

- remove inline styling

Options
    • -95
    • +78
    /openacs-4/packages/xowiki/tcl/chat-procs.tcl
3:03 pm

antoniop

Unquote single quote from JSON before appending messages to chat

Options
    • -2
    • +3
    /openacs-4/packages/xowiki/www/ajax/scripted-streaming-chat.js
    • -2
    • +3
    /openacs-4/packages/xowiki/www/ajax/streaming-chat.js
Wednesday 19 Sep
7:11 pm

antoniop

Fix quoting of single quotes in JSON

Options
    • -2
    • +2
    /openacs-4/packages/xotcl-core/tcl/chat-procs.tcl
7:01 pm

antoniop

Remove leftover alert

Options
    • -2
    • +1
    /openacs-4/packages/xowiki/www/ajax/streaming-chat.js
6:19 pm

antoniop

Avoid javascript eval idiom as CSP will refuse to execute when unsafe-eval is disabled

This requires moving to a more approprate JSON parser... which is also pickier regarding single quotes, so I had to rework JSON encoding to please it.

Options
    • -4
    • +4
    /openacs-4/packages/xotcl-core/tcl/chat-procs.tcl
    • -2
    • +3
    /openacs-4/packages/xowiki/www/ajax/streaming-chat.js
3:32 pm

antoniop

Make ad_sanitize_html not hardly dependant on a connection being there (thanks to Markus moser for the report)

Also, update documentation and make idioms less awkward.

(this passes automated tests)

Options
    • -33
    • +45
    /openacs-4/packages/acs-tcl/tcl/text-html-procs.tcl
Tuesday 18 Sep
5:08 pm

antoniop

Better separate data from formatting

Options
    • -1
    • +6
    /openacs-4/packages/chat/www/ajax/chat.adp
    • -9
    • +1
    /openacs-4/packages/chat/www/ajax/chat.tcl
4:46 pm

antoniop

Normalize indentation

Options
    • -19
    • +19
    /openacs-4/packages/chat/tcl/chat-ajax-procs.tcl
4:44 pm

antoniop

Decouple a bit formatting from data

Options
    • -0
    • +48
    /openacs-4/packages/chat/www/ajax/chat.adp
    • -26
    • +6
    /openacs-4/packages/chat/www/ajax/chat.tcl
4:42 pm

antoniop

Give templating a chance

move all hardcoded styling to the adp template, which might be styled by the theme. Also, biring some order in the login proc, e.g. don't open and read a file to include a javascript all the time.

Options
    • -64
    • +59
    /openacs-4/packages/chat/tcl/chat-ajax-procs.tcl
    • -0
    • +17
    /openacs-4/packages/chat/www/ajax-chat-script.adp
3:35 pm

antoniop

Modernize XoTcl idioms

Options
    • -5
    • +5
    /openacs-4/packages/chat/tcl/chat-ajax-procs.tcl
Friday 14 Sep
1:10 pm

antoniop

Remove smelly comment, as parameter is there

Options
    • -3
    • +1
    /openacs-4/packages/acs-content-repository/tcl/image-procs.tcl
1:08 pm

antoniop

Deprecate util_search_list_of_lists, as since Tcl 8.5 its behavior can be achieved natively through lsearch

Options
    • -2
    • +23
    /openacs-4/packages/acs-tcl/tcl/deprecated-procs.tcl
    • -16
    • +1
    /openacs-4/packages/acs-tcl/tcl/utilities-procs.tcl
1:04 pm

antoniop

Modernize tcl

Options
    • -7
    • +6
    /openacs-4/packages/acs-content-repository/tcl/image-procs.tcl
12:35 pm

antoniop

Whitespace removal

Options
    • -33
    • +33
    /openacs-4/packages/acs-content-repository/tcl/image-procs.tcl
12:24 pm

antoniop

Move image::get_info together with its pals procs in the content repository... just to realize it should probably go away at some point

Options
    • -2
    • +35
    /openacs-4/packages/acs-content-repository/tcl/image-procs.tcl
    • -42
    • +0
    /openacs-4/packages/acs-tcl/tcl/image-procs.tcl
11:39 am

antoniop

Fix layout when no data for test is available

Options
    • -0
    • +1
    /openacs-4/packages/acs-automated-testing/www/admin/index.adp
Friday 24 Aug
12:54 pm

antoniop

Fix typo in doc

Options
    • -2
    • +2
    /openacs-4/packages/calendar/tcl/calendar-callback-procs.tcl
12:32 pm

antoniop

Add a callback hook to put logic before calendar item deletion

Options
    • -1
    • +4
    /openacs-4/packages/calendar/tcl/cal-item-procs.tcl
    • -0
    • +15
    /openacs-4/packages/calendar/tcl/calendar-callback-hooks-procs.tcl
Thursday 16 Aug
5:39 pm

antoniop

Let max_depth behave as specified (0 disables redirection). Many thanks to Markus Moser

Options
    • -2
    • +2
    /openacs-4/packages/acs-tcl/tcl/http-client-procs.tcl
Thursday 02 Aug
2:41 pm

antoniop

Fix typo, normalize indentation

Options
    • -21
    • +22
    /openacs-4/packages/openacs-bootstrap3-theme/tcl/apm-callback-procs.tcl
Wednesday 01 Aug
12:39 pm

antoniop

Introduce elapsed time in http api response

Will use the one coming from ns_http when available, or fallback to a calculated one.

Options
    • -14
    • +45
    /openacs-4/packages/acs-tcl/tcl/http-client-procs.tcl
10:09 am

antoniop

Close tag properly (fixes files__check_info_files)

Options
    • -1
    • +1
    /openacs-4/packages/xowf/xowf.info
10:04 am

antoniop

Update adp boolean expression

Options
    • -1
    • +1
    /openacs-4/packages/forums-portlet/www/forums-portlet.adp
Friday 27 Jul
6:35 pm

antoniop

Remove unneded ad_script_abort

Options
    • -1
    • +0
    /openacs-4/packages/acs-admin/lib/service-parameters.tcl
12:21 pm

antoniop

Fix files__page_contracts for include, replace ad_decode idioms

Options
    • -2
    • +11
    /openacs-4/packages/acs-admin/lib/password-update.tcl
12:14 pm

antoniop

Fix files__page_contracts for this page

Options
    • -0
    • +7
    /openacs-4/packages/acs-admin/lib/developer-services.tcl
11:47 am

antoniop

Fix files__page_contracts automated test for the page

Options
    • -10
    • +13
    /openacs-4/packages/acs-admin/lib/service-parameters.tcl