antoniop in OpenACS

About

941 commits
  • Committer is not mapped to a user
  • First commit: 20 November 2006
  • Last commit: 20 November 2018
Last Week All Time
Commits: 0 941
Files changed: 35 2,822
Change in LOC: 828 15,952

Line History

Line Count Graph
Line Count Graph

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 
Tuesday 20 Nov
7:45 pm

antoniop

Converge styling of chat in a single css file for both xowiki and chat packages

This might fork in the future, but there is no need atm

Options
    • -221
    • +0
    /openacs-4/packages/chat/www/resources/chat.css
    • -9
    • +6
    /openacs-4/packages/xowiki/tcl/chat-procs.tcl
7:41 pm

antoniop

Switch to a non-nsv approach to determine the right chat class

Options
    • -7
    • +6
    /openacs-4/packages/xowiki/tcl/chat-procs.tcl
    • -3
    • +4
    /openacs-4/packages/xowiki/www/chat.tcl
7:00 pm

antoniop

Unclutter the code by putting mode detection in a separate proc

Options
    • -41
    • +47
    /openacs-4/packages/xowiki/tcl/chat-procs.tcl
6:48 pm

antoniop

Add leftover file

Options
    • -0
    • +47
    /openacs-4/packages/xowiki/www/chat.tcl
6:46 pm

antoniop

Chat reform:

- reduce code duplication by determining the proper chat class dynamically and storing it in an nsv

- move static content in the resources path. Serving them is now independent from the mounted xowiki path

- get rid of the ajax url path

Options
    • -1
    • +6
    /openacs-4/packages/chat/tcl/chat-ajax-procs.tcl
    • -48
    • +0
    /openacs-4/packages/chat/www/ajax/chat.tcl
    • -17
    • +22
    /openacs-4/packages/xowiki/tcl/chat-procs.tcl
    • -205
    • +0
    /openacs-4/packages/xowiki/www/ajax/chat-common.js
    • -40
    • +0
    /openacs-4/packages/xowiki/www/ajax/chat.js
    • -42
    • +0
    /openacs-4/packages/xowiki/www/ajax/chat.tcl
    • -20
    • +0
    /openacs-4/packages/xowiki/www/ajax/scripted-streaming-chat.js
    • -54
    • +0
    /openacs-4/packages/xowiki/www/ajax/streaming-chat.js
    • -0
    • +205
    /openacs-4/packages/xowiki/www/resources/chat-common.js
    • -8
    • +27
    /openacs-4/packages/xowiki/www/resources/chat.css
    • -0
    • +40
    /openacs-4/packages/xowiki/www/resources/chat.js
    • -0
    • +20
    /openacs-4/packages/xowiki/www/resources/scripted-streaming-chat.js
    • -0
    • +54
    /openacs-4/packages/xowiki/www/resources/streaming-chat.js
Monday 19 Nov
7:19 pm

antoniop

Allow to make other (non .adp) kinds of resources "theme aware" and use this to provide a theme mapping to the /resources/ URL pattern, then use this new capability to allow the override of css in the chat implementations

Options
    • -7
    • +21
    /openacs-4/packages/acs-tcl/tcl/request-processor-procs.tcl
    • -2
    • +3
    /openacs-4/packages/acs-templating/tcl/util-procs.tcl
    • -5
    • +6
    /openacs-4/packages/xowiki/tcl/chat-procs.tcl
5:35 pm

antoniop

Give xowiki chat also some kind of nice skin and centralize css retrieval

TODO: something smarter can be done in order to retrieve the proper css, based e.g. on theme, chat skin (to be implemented) etc. To be discussed is some way to resolve resources based on the theme.

Options
    • -2
    • +1
    /openacs-4/packages/chat/tcl/chat-ajax-procs.tcl
    • -3
    • +1
    /openacs-4/packages/chat/www/chat.tcl
    • -1
    • +6
    /openacs-4/packages/xowiki/tcl/chat-procs.tcl
    • -0
    • +202
    /openacs-4/packages/xowiki/www/resources/chat.css
3:32 pm

antoniop

New chat_room includelet, behaving as the existing chat one, but plugged with extra chat package's feature (transcript management...)

To avoid package_id to be overridden, we force it always to the one of the current chat

Options
    • -2
    • +27
    /openacs-4/packages/chat/tcl/chat-ajax-procs.tcl
    • -2
    • +2
    /openacs-4/packages/chat/www/chat.tcl
    • -3
    • +2
    /openacs-4/packages/xowiki/tcl/includelet-procs.tcl
3:12 pm

antoniop

Move chat machinery from xotcl-core to xowiki

Rationale: this feature makes little sense without the front-end xowiki provides and makes chat implementation harder to understand, as components are scattered in different packages.

Options
    • -358
    • +0
    /openacs-4/packages/xotcl-core/tcl/chat-procs.tcl
    • -3
    • +350
    /openacs-4/packages/xowiki/tcl/chat-procs.tcl
12:15 pm

antoniop

Add package_id to the parameters for the already-available chat includelet

Options
    • -2
    • +3
    /openacs-4/packages/xowiki/tcl/includelet-procs.tcl
Friday 16 Nov
7:39 pm

antoniop

Improve error handling idioms and handle additional error cases where the client has just disconnected

Options
    • -16
    • +21
    /openacs-4/packages/xotcl-core/tcl/bgdelivery-procs.tcl
7:10 pm

antoniop

Try to trap additional disconnection-related errors

Options
    • -1
    • +4
    /openacs-4/packages/xotcl-core/tcl/bgdelivery-procs.tcl
7:03 pm

antoniop

Put the puts operation in the try catch as well

Options
    • -2
    • +2
    /openacs-4/packages/xotcl-core/tcl/bgdelivery-procs.tcl
Tuesday 13 Nov
4:32 pm

antoniop

Specify the timeout value on the wait command as well and avoid unneeded conversion

Options
    • -15
    • +15
    /openacs-4/packages/acs-tcl/tcl/http-client-procs.tcl
Friday 09 Nov
12:01 pm

antoniop

Fix typo in comment

Options
    • -2
    • +2
    /openacs-4/packages/xotcl-core/tcl/bgdelivery-procs.tcl
12:00 pm

antoniop

Use finer grained error handling to intercept disconnection from client

Options
    • -7
    • +9
    /openacs-4/packages/xotcl-core/tcl/bgdelivery-procs.tcl
Thursday 08 Nov
5:37 pm

antoniop

Replace deprecated proc template::util::leadingPad with ad_pad

Options
    • -7
    • +4
    /openacs-4/packages/acs-templating/tcl/date-procs.tcl
3:40 pm

antoniop

Treat failure to flush the channel as just a warning, because this usually just means client (e.g. browser in a chat) closed the connection

Options
    • -3
    • +13
    /openacs-4/packages/xotcl-core/tcl/bgdelivery-procs.tcl
Tuesday 06 Nov
11:41 am

antoniop

Tolerate wrong locales from browsers by assuming our default one

Options
    • -2
    • +6
    /openacs-4/packages/acs-lang/tcl/locale-procs.tcl
Wednesday 31 Oct
3:09 pm

antoniop

Fix installer by uniforming columns returned by the two query variants

Options
    • -1
    • +1
    /openacs-4/packages/acs-tcl/tcl/site-nodes-procs-postgresql.xql
2:54 pm

antoniop

Create a full subsite instead of just a node, or the context bar will ignore it, then consider localization in the test

Options
    • -9
    • +26
    /openacs-4/packages/acs-tcl/tcl/test/navigation-procs.tcl
12:28 pm

antoniop

Consider localization when testing the context bar

Options
    • -1
    • +1
    /openacs-4/packages/acs-tcl/tcl/test/navigation-procs.tcl
Tuesday 30 Oct
4:40 pm

antoniop

Fix list expression

Options
    • -2
    • +2
    /openacs-4/packages/categories/www/cadmin/tree-order-update.tcl
Wednesday 24 Oct
7:02 pm

antoniop

Use the new utility to refresh the chat whenever one lands here from the browser history

Options
    • -1
    • +3
    /openacs-4/packages/xowiki/tcl/chat-procs.tcl
7:01 pm

antoniop

Add new utility to trigger a browser refresh when we reach a page by the browser's history

Useful e.g. for those pages implementing some server push interaction, where browser might have 'missed out' events while on another page

Options
    • -0
    • +21
    /openacs-4/packages/acs-templating/tcl/head-procs.tcl
1:05 pm

antoniop

When transcripting a message, use the provided user_id when available

This fixes auto logout messages being written down as from unregistered visitor in the transcript

Options
    • -3
    • +4
    /openacs-4/packages/chat/tcl/chat-ajax-procs.tcl
12:29 pm

antoniop

Specialize the way chat::Chat class retrieves the package_id: use the context_id of the chat room (if this is a valid chat room)

This will allow to embed a chat::Chat instance in a xowiki page pinting to an existing chat room and let it use the chat package specific features to e.g. keep transcripts of a conversation

Options
    • -1
    • +9
    /openacs-4/packages/chat/tcl/chat-ajax-procs.tcl
    • -1
    • +2
    /openacs-4/packages/chat/tcl/chat-procs.tcl
    • -2
    • +1
    /openacs-4/packages/chat/www/chat.tcl
    • -3
    • +3
    /openacs-4/packages/xowiki/tcl/chat-procs.tcl
11:14 am

antoniop

Fade out obsolete code

Options
    • -4
    • +5
    /openacs-4/packages/chat/tcl/chat-init.tcl
    • -219
    • +220
    /openacs-4/packages/chat/tcl/chat-procs.tcl
Thursday 04 Oct
6:36 pm

antoniop

Quote the backslash as well...

Options
    • -2
    • +2
    /openacs-4/packages/xotcl-core/tcl/chat-procs.tcl
Tuesday 02 Oct
5:34 pm

antoniop

Italian message keys for cookie-consent package

Options
    • -0
    • +7
    /openacs-4/packages/cookie-consent/catalog/cookie-consent.it_IT.ISO-8859-1.xml