antoniop in OpenACS

Use localized version of richtext types

Clean indentation

Fix deprecated idiom

Revert changes as this won't work on Aolserver

Remove catches, as -nocomplain behavior was fixed in Naviserver by https://bitbucket.org/naviserver/naviserver/commits/6008e3d0720e12f2237fbc4397daf878efc79b5c

Don't go all the way when user provides an invalid parent post to reply to

    • -8
    • +7
    /openacs-4/packages/forums/www/message-post.tcl
Assume moderators have always the right to post

Let admins post in every situation

    • -7
    • +11
    /openacs-4/packages/forums/www/message-post.tcl
Backfix upgrade to be PostgreSQL 9.0 compliant

Backport fix to https://openacs.org/bugtracker/openacs/bug?format=table&bug_number=3331: fix original problematic update

file upgrade-5.9.1-5.9.2d1.sql was initially added on branch oacs-5-9.

Fix typo

Use PostgreSQL 9.0 compatible idioms in 'sql' stored procedure

Handle access to non-existent faq question through human-readable error message

    • -7
    • +4
    /openacs-4/packages/faq/www/one-question.tcl
Fix typo

Introduce a callback hook for packages to insert some specific logic

Driver is reduce difference between downstream and upstream code

Don't tamper with permissions to remember whether we should be able to moderate or not

Show moderate button only when forum is actually moderated

check truth by lean and mean tcl idiom

Ehm, fix missed occurrency of message level permission check

Fix typo in deprecated proc (not used upstream anymore)

Forum reform

- remove hardcoded dependency with registered_users group. Target is to improve suitability in convoluted multi groups/multi subsites context

- in place of previous permission-based machinery, use plain table columns to detect whether user can or cannot post replies/new threads

- remove permission check at the message level in favor of that on forum level

    • -2
    • +2
    /openacs-4/packages/forums/forums.info
    • -4
    • +1
    /openacs-4/packages/forums/lib/forums/new.tcl
    • -36
    • +37
    /openacs-4/packages/forums/tcl/forums-procs.tcl
    • -3
    • +2
    /openacs-4/packages/forums/www/message-email.tcl
    • -4
    • +8
    /openacs-4/packages/forums/www/message-post.tcl
    • -20
    • +2
    /openacs-4/packages/forums/www/message-view.tcl
  1. … 7 more files in changeset.
Remove usage of apm_package_version__version_name_greater in favor of apm_version_names_compare proc as their logics conflict

Remove usage of apm_package_version.version_name_greater stored procedure in favor of apm_version_names_compare proc, because their logics conflict

Unifiy logic for package version comparison

Fix: folder "name" is in fact "label" property, remove obsolete xql, remove superfluous ad_return_template

Allow to modify folder description

Fix idiom to check for string being populated

Use full <if @foo_p@ true> instead of undocumented shortcut idiom <if @foo_p@>

Create utility to retrieve pdf information using poppler utils (https://poppler.freedesktop.org/)

This includes author, number of page, encription (yes/no), pdf version etc.

Introduce catches from downstream when cleaning up chat variables

Looks like these variables can have been removed before logging out.

Bugfix ad_user_login

-expire flag for ad_set_signed_cookie (and therefore ad_set_cookie) was not specified by ad_user_login and set false per-default. This prevented parameters to set cookie expiration to have an effect, even when -max_age was correctly specified.

Now we set the -expire flag according to the -forever flag.