antoniop in OpenACS

About

300 commits
  • Committer is not mapped to a user
  • First commit: 20 November 2006
  • Last commit: 21 June 2017
Last Week All Time
Commits: 0 300
Files changed: 0 120
Change in LOC: 0 319

Line History

Line Count Graph
Line Count Graph

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 
Wednesday 21 Jun
11:09 pm

antoniop

Use site_node:: api to retrieve package_url instead of explicit query. Remove unused sql and simplify idiom for fs_get_folder_name.

Options
    • -6
    • +4
    /openacs-4/packages/file-storage/tcl/file-storage-procs.tcl
    • -8
    • +0
    /openacs-4/packages/file-storage/tcl/file-storage-procs.xql
Tuesday 20 Jun
9:46 pm

antoniop

Don't assume a Unix OS when executing commands

Options
    • -2
    • +8
    /openacs-4/packages/xotcl-request-monitor/www/index.tcl
9:34 pm

antoniop

Don't assume a Unix OS when exec'ing commands

Options
    • -3
    • +6
    /openacs-4/packages/acs-admin/www/monitor.tcl
    • -2
    • +5
    /openacs-4/packages/acs-admin/www/apm/version-generate-diffs.tcl
2:51 pm

antoniop

Localize group actions (port of work by Monika Andergassen)

Options
    • -0
    • +2
    /openacs-4/packages/acs-subsite/catalog/acs-subsite.de_DE.ISO-8859-1.xml
    • -0
    • +2
    /openacs-4/packages/acs-subsite/catalog/acs-subsite.en_US.ISO-8859-1.xml
    • -0
    • +4
    /openacs-4/packages/acs-subsite/catalog/acs-subsite.it_IT.ISO-8859-1.xml
    • -3
    • +3
    /openacs-4/packages/acs-subsite/www/register/user-join.tcl
Monday 19 Jun
8:35 pm

antoniop

Prevent error when user is removed from the Registered Users group, but not from users altogether

Options
    • -2
    • +2
    /openacs-4/packages/acs-authentication/tcl/authentication-procs.tcl
7:16 pm

antoniop

Allow to specify another return url for the page

Options
    • -2
    • +3
    /openacs-4/packages/acs-subsite/www/members/member-remove.tcl
Friday 16 Jun
7:07 pm

antoniop

Fix typo in previous commit

Options
    • -2
    • +2
    /openacs-4/packages/acs-authentication/tcl/authentication-procs.tcl
7:05 pm

antoniop

Don't steal anybody's address nor email, especially if people was banned. Fail and give a message instead.

Options
    • -12
    • +3
    /openacs-4/packages/acs-authentication/tcl/authentication-procs.tcl
Friday 09 Jun
7:47 pm

antoniop

Use ad_script_abort everytime one issues ad_return_complaint, or subsequent errors will trigger without the user noticing

Options
    • -0
    • +1
    /openacs-4/packages/chat/www/chat-transcripts.tcl
    • -0
    • +1
    /openacs-4/packages/chat/www/html-chat.tcl
    • -2
    • +3
    /openacs-4/packages/chat/www/message-delete-2.tcl
    • -1
    • +2
    /openacs-4/packages/chat/www/room-delete-2.tcl
    • -0
    • +1
    /openacs-4/packages/chat/www/transcript-delete-2.tcl
    • -1
    • +2
    /openacs-4/packages/chat/www/transcript-edit.tcl
4:33 pm

antoniop

Prevent user from triggering db error by entering too big subjects

Options
    • -2
    • +14
    /openacs-4/packages/forums/lib/message/post.tcl
3:40 pm

antoniop

simplify idiom

Options
    • -2
    • +2
    /openacs-4/packages/acs-authentication/tcl/local-procs.tcl
2:07 pm

antoniop

Fix cases of this portlet being called on trees without categories.

Modernize list assign idioms

Options
    • -4
    • +7
    /openacs-4/packages/xowiki/www/prototypes/categories-portlet.page
Thursday 08 Jun
8:15 pm

antoniop

Port some improvements from Learn@WU codebase:

- check whether chat room exists exploits cache

- chat room retrieval enriches with some acs_objects metadata

Fix potential errors when we try entering a chat room that has been deleted and check for its activity status

Options
    • -11
    • +43
    /openacs-4/packages/chat/tcl/chat-procs.tcl
6:42 pm

antoniop

- Introduce new proc ad_sanitize_filename implementing current best practices for ensuring a valid filename on most filesystems.

- Use it in every place where filename sanitization is performed in the code and deprecate fs::remove_special_file_system_characters.

TODO deprecate also util_text_to_html? Use case of sanitizing urls and filenames might have different requirements.

Options
    • -3
    • +5
    /openacs-4/packages/acs-content-repository/tcl/content-item-procs.tcl
    • -1
    • +115
    /openacs-4/packages/acs-tcl/tcl/utilities-procs.tcl
    • -1
    • +0
    /openacs-4/packages/file-storage/lib/folder-links.tcl
    • -8
    • +24
    /openacs-4/packages/file-storage/tcl/file-storage-procs.tcl
    • -3
    • +1
    /openacs-4/packages/file-storage/www/folder-chunk.tcl
    • -2
    • +5
    /openacs-4/packages/file-storage/www/folder-create.tcl
Tuesday 06 Jun
5:01 pm

antoniop

Make sure message exists when dealing with a banned user

Options
    • -2
    • +3
    /openacs-4/packages/acs-subsite/lib/login.tcl
Wednesday 31 May
11:56 am

antoniop

Update construct to reload a page, as previous one was not working properly at least on Chrome and Explorer

Options
    • -3
    • +3
    /openacs-4/packages/xowiki/tcl/bootstrap-procs.tcl
Tuesday 30 May
7:16 pm

antoniop

Improve UI for Hostnode map so it is feasible on sites with many nodes to show navigate the site structure

Options
    • -5
    • +16
    /openacs-4/packages/acs-subsite/www/admin/host-node-map/index.tcl
2:00 pm

antoniop

Fix typo

Options
    • -1
    • +1
    /openacs-4/packages/file-storage/www/folder-delete.adp
1:58 pm

antoniop

Check if we have already a folder with same name before inserting, or we get error in the logs.

Remove small duplication

Options
    • -8
    • +15
    /openacs-4/packages/file-storage/www/folder-create.tcl
Friday 26 May
5:20 pm

antoniop

Don't report pretty link in export comments for items without a package_id, or export will come out corrupted.

(This is the case for global template objects as en:folder.form)

Options
    • -2
    • +3
    /openacs-4/packages/xowiki/tcl/import-procs.tcl
Wednesday 24 May
8:49 pm

antoniop

Remove sql duplication, converge oracle and postgres codebase

Options
    • -14
    • +0
    /openacs-4/packages/file-storage/tcl/file-storage-procs-oracle.xql
    • -17
    • +0
    /openacs-4/packages/file-storage/tcl/file-storage-procs-postgresql.xql
    • -1
    • +2
    /openacs-4/packages/file-storage/tcl/file-storage-procs.tcl
    • -0
    • +8
    /openacs-4/packages/file-storage/tcl/file-storage-procs.xql
6:09 pm

antoniop

Prevent user from selecting source folder as destination folder when moving files. Localize feedback messages (thanks to Markus Moser for the germen translation)

Options
    • -0
    • +2
    /openacs-4/packages/file-storage/catalog/file-storage.de_DE.ISO-8859-1.xml
    • -2
    • +4
    /openacs-4/packages/file-storage/catalog/file-storage.en_US.ISO-8859-1.xml
    • -0
    • +2
    /openacs-4/packages/file-storage/catalog/file-storage.it_IT.ISO-8859-1.xml
    • -33
    • +34
    /openacs-4/packages/file-storage/www/move.tcl
Thursday 11 May
6:40 pm

antoniop

Fix typo in html attributes definition (this enables proper styling and input checks).

Put formwidget directly into markup, otherwise the templating system complains about missing id for the submit widget.

Options
    • -1
    • +3
    /openacs-4/packages/calendar/www/view-list-display.adp
    • -2
    • +2
    /openacs-4/packages/calendar/www/view-list-display.tcl
Tuesday 09 May
6:09 pm

antoniop

Don't lookup creator name for messages coming from the system, as they won't be found

Options
    • -2
    • +3
    /openacs-4/packages/chat/tcl/chat-procs.tcl
4:09 pm

antoniop

Don't assume import_file exists when checking for virus

Options
    • -2
    • +3
    /openacs-4/packages/xowiki/tcl/xowiki-form-procs.tcl
3:35 pm

antoniop

Put missing -base argument (many thanks to Markus Moser)

Options
    • -1
    • +1
    /openacs-4/packages/xowiki/tcl/folder-procs.tcl
2:03 pm

antoniop

Remove debugging comment

Options
    • -4
    • +3
    /openacs-4/packages/file-storage/www/copy.tcl
2:01 pm

antoniop

Use name and title for the copy, rather than name as title and file_upload_name as name. This will make so copied files will have also the same title as the original when this was renamed.

Try conserving file extension in the name when adding the suffix

Options
    • -6
    • +6
    /openacs-4/packages/file-storage/www/copy-oracle.xql
    • -6
    • +6
    /openacs-4/packages/file-storage/www/copy-postgresql.xql
    • -9
    • +15
    /openacs-4/packages/file-storage/www/copy.tcl
12:07 pm

antoniop

Localize untranslated messages in the copy file-storage script (thanks to Markus Moser for the german translation)

Options
    • -0
    • +2
    /openacs-4/packages/file-storage/catalog/file-storage.de_DE.ISO-8859-1.xml
    • -0
    • +2
    /openacs-4/packages/file-storage/catalog/file-storage.en_US.ISO-8859-1.xml
    • -0
    • +2
    /openacs-4/packages/file-storage/catalog/file-storage.it_IT.ISO-8859-1.xml
    • -2
    • +2
    /openacs-4/packages/file-storage/www/copy.tcl
Monday 08 May
3:12 pm

antoniop

Don't show time interval when choosing recurrence in case of all day events

Options
    • -2
    • +8
    /openacs-4/packages/calendar/www/cal-item-create-recurrence.adp