antoniop in OpenACS

About

1,410 commits
  • Committer is not mapped to a user
  • First commit: 20 November 2006
  • Last commit: 15 May 2019
Last Week All Time
Commits: 0 1,410
Files changed: 0 3,414
Change in LOC: 0 19,162

Line History

Line Count Graph
Line Count Graph

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 
Wednesday 15 May
8:05 pm

antoniop

Safety belt so users cannot change URL of the main subsite from the UI

Options
    • -3
    • +10
    /openacs-4/packages/acs-subsite/www/admin/applications/application-add.tcl
Monday 13 May
12:12 pm

antoniop

Make sure package_id is set on transcripts also when flushing messages every day

Options
    • -0
    • +1
    /openacs-4/packages/chat/tcl/xotcl-chat-procs.tcl
12:02 pm

antoniop

Chat reform:

- use consistently package_id to model belonging of a chat object to a particular package instead of the context_id

- set context_id to the package_id, as was already the case in practice, for permission checking

- make sure package_id exists and set it to the context_id in case it doesn't to handle legacy installations

Options
    • -2
    • +2
    /openacs-4/packages/chat/chat.info
    • -0
    • +11
    /openacs-4/packages/chat/tcl/apm-callback-procs.tcl
    • -2
    • +2
    /openacs-4/packages/chat/tcl/chat-ajax-procs.tcl
    • -2
    • +2
    /openacs-4/packages/chat/tcl/chat-procs.tcl
    • -3
    • +7
    /openacs-4/packages/chat/tcl/xotcl-chat-procs.tcl
    • -2
    • +2
    /openacs-4/packages/chat/www/index.tcl
    • -1
    • +1
    /openacs-4/packages/chat/www/room-edit.tcl
    • -1
    • +1
    /openacs-4/packages/chat/www/transcript-new-2.tcl
Friday 10 May
6:05 pm

antoniop

Further performance improvement: as we only want one column from xowiki_form_page, just get it through a subquery

Options
    • -2
    • +2
    /openacs-4/packages/xowiki/xowiki.info
    • -5
    • +5
    /openacs-4/packages/xowiki/tcl/xowiki-procs.tcl
    • -1
    • +12
    /openacs-4/packages/xowiki/tcl/upgrade/upgrade.tcl
5:09 pm

antoniop

xowiki_form_instance_item_view performance improvement: do not join with dummy cr_text table, use lateral on Postgres to better guide the query planner

Options
    • -2
    • +2
    /openacs-4/packages/xowiki/xowiki.info
    • -5
    • +34
    /openacs-4/packages/xowiki/tcl/xowiki-procs.tcl
    • -1
    • +12
    /openacs-4/packages/xowiki/tcl/upgrade/upgrade.tcl
Thursday 09 May
8:03 pm

antoniop

Fix properly import/export in a way that, as we did before, context_id of imported objects will use cr_items default, the parent_id

Options
    • -10
    • +5
    /openacs-4/packages/xowiki/tcl/xowiki-procs.tcl
5:07 pm

antoniop

xowiki_form_instance_item_view reform: retrieve the context_id from the cr_item, rather than from the cr_revision

Rationale: revision's context_id is always set to its item_id. This will make every fetched ORM object appear as its context_id = item_id, while item's acs_object will display the correct context_id (in most cases, its parent)

Options
    • -2
    • +2
    /openacs-4/packages/xowiki/xowiki.info
    • -2
    • +3
    /openacs-4/packages/xowiki/tcl/xowiki-procs.tcl
    • -1
    • +12
    /openacs-4/packages/xowiki/tcl/upgrade/upgrade.tcl
4:43 pm

antoniop

Keep previous behavior of ignoring the context_id when exporting/importing xowiki objects now that this metadata would be persisted

Options
    • -1
    • +11
    /openacs-4/packages/xowiki/tcl/xowiki-procs.tcl
Wednesday 08 May
5:10 pm

antoniop

Pass object_id to the include UI, make the include contract clear

Options
    • -4
    • +11
    /openacs-4/packages/categories/lib/tree-form.tcl
    • -1
    • +1
    /openacs-4/packages/categories/www/cadmin/tree-form.adp
Tuesday 07 May
2:38 pm

antoniop

Wrap upleveled command in a list statement to make number of arguments clear

Options
    • -2
    • +2
    /openacs-4/packages/xotcl-core/tcl/10-recreation-procs.tcl
Thursday 02 May
6:56 pm

antoniop

Do not require uuid package anymore

Options
    • -2
    • +0
    /openacs-4/packages/xolp/tcl/xolp-util-procs.tcl
5:46 pm

antoniop

Use ns_uuid Naviserver command instead of uuid::uuid generate from tcllib: apparently, this can interact badly with clock localized formatting, leading to the "GREGORIAN_CHANGE_DATE" issue

Options
    • -2
    • +2
    /openacs-4/packages/xolp/tcl/xolp-util-procs.tcl
Friday 26 Apr
6:40 pm

antoniop

Add @see to deprecated doc

Options
    • -2
    • +2
    /openacs-4/packages/categories/tcl/categories-procs.tcl
6:38 pm

antoniop

Prefer using the list structure directly: each category has only 1 translation per locale

Options
    • -6
    • +6
    /openacs-4/packages/categories/tcl/categories-procs.tcl
6:27 pm

antoniop

Smartify idiom

Options
    • -6
    • +3
    /openacs-4/packages/categories/tcl/categories-procs.tcl
6:21 pm

antoniop

Replace catch idiom

Options
    • -4
    • +5
    /openacs-4/packages/categories/tcl/categories-procs.tcl
6:18 pm

antoniop

Replace catch idioms

Options
    • -20
    • +24
    /openacs-4/packages/categories/tcl/categories-procs.tcl
6:06 pm

antoniop

Replace catch idiom

Options
    • -2
    • +5
    /openacs-4/packages/categories/tcl/categories-procs.tcl
6:01 pm

antoniop

Move portable sql inline, streamline idioms

Options
    • -33
    • +108
    /openacs-4/packages/categories/tcl/categories-procs.tcl
    • -178
    • +0
    /openacs-4/packages/categories/tcl/categories-procs.xql
3:57 pm

antoniop

Simplify idioms: lang is unique for a particular tree

Options
    • -7
    • +4
    /openacs-4/packages/categories/tcl/category-trees-procs.tcl
3:44 pm

antoniop

Replace catch idiom

Options
    • -2
    • +5
    /openacs-4/packages/categories/tcl/category-trees-procs.tcl
3:34 pm

antoniop

Replace catch idiom

Options
    • -2
    • +5
    /openacs-4/packages/categories/tcl/category-trees-procs.tcl
3:31 pm

antoniop

Replace catch idioms

Options
    • -11
    • +19
    /openacs-4/packages/categories/tcl/category-trees-procs.tcl
3:26 pm

antoniop

tree_id is a positional argument

Options
    • -2
    • +2
    /openacs-4/packages/categories/tcl/category-trees-procs.tcl
3:05 pm

antoniop

Replace catch idiom, improve proc contract, make it clear that we return a list

Options
    • -5
    • +9
    /openacs-4/packages/categories/tcl/category-trees-procs.tcl
2:47 pm

antoniop

Bring sql inline, reduce duplication

Options
    • -24
    • +64
    /openacs-4/packages/categories/tcl/category-trees-procs.tcl
    • -131
    • +0
    /openacs-4/packages/categories/tcl/category-trees-procs.xql
2:31 pm

antoniop

Simplify idiom, bring sql inline

Options
    • -3
    • +6
    /openacs-4/packages/categories/tcl/category-trees-procs.tcl
    • -10
    • +0
    /openacs-4/packages/categories/tcl/category-trees-procs.xql
12:49 pm

antoniop

Take advantage of oldie utility template::util::list_to_multirow to refactor and simplify the code

Options
    • -21
    • +16
    /openacs-4/packages/categories/www/cadmin/index.tcl
12:30 pm

antoniop

Fix typo

Options
    • -2
    • +2
    /openacs-4/packages/categories/www/cadmin/index.tcl
12:30 pm

antoniop

Fix missing variable

Options
    • -2
    • +2
    /openacs-4/packages/categories/www/cadmin/index.tcl