hectorr in OpenACS

Add new private proc 'attachments::get_attachments_url', and use it to complement the logic of 'attachments::get_url'

As 'attachments::get_url' returns the value of the attachments package

'RelativeUrl' parameter, which can change at any time, it could happen

that previously mounted attachments have a different url and are not

found anymore.

We try our best here to find a mounted attachments package under

'base_url' to mitigate this, probably flawed, package logic.

In the future, probably a better method should be used for URL resolving

that is not so broken.

The whole thing is even more weird, as the attachments package is

currently a singleton that auto-mounts on /attachments, so i am tempted

to replace this whole thing with just that, but anyway...

Use 'attachments::detach_url' instead of building manually the URL

Bump version to reload message keys

Renaming of files so they are loaded after 00-icanuse-procs.tcl

    • -3800
    • +0
    /openacs-4/packages/acs-tcl/tcl/00-database-procs.tcl
    • -0
    • +3800
    /openacs-4/packages/acs-tcl/tcl/01-database-procs.tcl
file 01-database-procs-oracle.tcl was initially added on branch oacs-5-10.

file 01-database-procs.tcl was initially added on branch oacs-5-10.

    • -0
    • +0
    /openacs-4/packages/acs-tcl/tcl/01-database-procs.tcl
file 01-database-procs-postgresql.tcl was initially added on branch oacs-5-10.

file 01-database-procs-postgresql-postgresql.xql was initially added on branch oacs-5-10.

    • -0
    • +0
    /openacs-4/packages/acs-tcl/tcl/01-database-procs-postgresql-postgresql.xql
Localize some pretty names. Many thanks to Monika Andergassen

Fix typo

Fix typos

Remove form debug code

Forum attachments reform.

- Add new style of attachments to the forums, allowing multiple attachments to a single message directly from the message post page, using the multiple file input widget.

- Retain compatibility with old style attachments, using the new 'AttachmentStyle' package instance parameter. Currently, this supports two values: 'simple' (new behavior) and 'complex' previous behavior.

- Both attachment styles can coexist, and attachments added by any of such methods will be shown.

- Improve the contract on 'forums/lib/message/post.tcl'.

- Show attachments on message preview.

- Bump version number.

    • -2
    • +3
    /openacs-4/packages/forums/forums.info
Add 'alt_template' to include contract

Add include contract and 'preview' view to the attachment list

Add some remarks regarding the 'privacy control' in the forum portlet

Require admin privileges for attachment deletion in the forum, the same as for message editing

Put the delete link to the right of the attachment

Only offer the possibility to delete an attachment from the file storage if it is really there, offer to detach it in any case.

Add 'attachments::get_title' to centralize the logic of title guessing for an attachment

Add the 'detach' option on the attachment list, for users with write permissions on the message

Center icons on attachment list

Generalize attachment size logic in forum posts, so different object types, such as 'content_item', 'content_revision', and their subtypes, are supported

Whitespace changes

Generalize attachment download logic, so it can deal with different object types, such as 'content_item', 'content_revision', and their subtypes

Add 'exception_count' to 'ad_return_complaint'

Use the paremeter 'LoginPasswordAutocomplete' to decide on the value of the attribute for the password element in the login form

Add a new instance parameter 'LoginPasswordAutocomplete' with the value of the 'autocomplete' attribute of the password field of the login form, to let each subsite decide.

Make 'attachments::get_all_attachments' more general, so we try our best to get the 'label' of the attachment by trying different options depending on the object type: 'content_item', 'content_revision', a subtype of those, or just the 'title' row in the 'acs_objects' table. In the very worst case, just set the given 'item_id' as the label.

Add a simple test case for 'content::revision::get_title'