gustafn in OpenACS

Added points in addition to minutes to test items and inclass-exam workflows

    • -2
    • +2
    /openacs-4/packages/xowiki/xowiki.info
remove personal-message dialog when user has finished her exam

improve source code documentation

    • -0
    • +6
    /openacs-4/packages/xowf/lib/inclass-exam.wf
return raw value for form-fields of type label, when disableOutputEscaping is set

fix broken support for explicit bindvars to db_foreach

added last_contribution based on last created object

file ip-info.adp was initially added on branch oacs-5-10.

    • -0
    • +0
    /openacs-4/packages/acs-admin/www/ip-info.adp
file ip-info.tcl was initially added on branch oacs-5-10.

    • -0
    • +0
    /openacs-4/packages/acs-admin/www/ip-info.tcl
remove stray "from" in last visit information

we have in table "users" no last IP, we could just fall back to a

last contribution field

use common "icanuse" idioms

use localized_text for folders and links

no need to subst

resolve message keys in titles

    • -0
    • +3
    /openacs-4/packages/xowiki/tcl/folder-procs.tcl
reduce verbosity

factor out script wrappers

    • -26
    • +18
    /openacs-4/packages/xowiki/tcl/chat-procs.tcl
undo recent changes on too global localizations

The new form-field class localized_text text solves the goals

of for providing a formfield interface to message keys in a

loca fashion rather than altering the behavior of all form

field and of all property interfaces.

    • -35
    • +5
    /openacs-4/packages/xowiki/tcl/xowiki-procs.tcl
New form-field class: localized_text

This class can be used to provide an interface for specifying

internationalized text strings saved in message keys via input

from a form. When editing the content provided via the input field

is saved together with an item-specific message keys in the

message key tables via lang::util::convert_to_i18n.

This formfield class is especially useful for xowiki items which

have no language-prefix (e.g. folders or links). In other cases it

is probably still a better idea to create same named pages with

different language prefixes.

    • -2
    • +2
    /openacs-4/packages/xowiki/tcl/xowiki-procs.tcl
improve spelling

Keep nsv variable "rp_properties request_count"

The nsv "rp_properties request_count" is still needed for bootstart loader.

Set it at the end of rp initialization

remove misleading comment. there should be no re-init

prefer db_0or1row +"where exists" over db_string + "select case"

send also HEAD requests to the request monitor

reduce usage of idiom "select 1 from dual where exists" when not necessary

some packages have high number of instances: no need to aggregate over these

prefer ad_try, since it is silent, when action is ended by a script_abort

    • -2
    • +4
    /openacs-4/packages/xowf/tcl/xowf-procs.tcl
prefer SQL max() function over sort and limit 1

    • -3
    • +4
    /openacs-4/packages/xowiki/tcl/package-procs.tcl
Upgrade CKEditor to 4.14.1

cache method "has_children" to avoid frequent (but cheap) DB calls

improve handling of errors, which are triggerd by the error template

fix comment and missing arguemnt