• last updated 15 hours ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
prefer "nsf::is object" over ":isobject" or "info commands", since it is faster, more generic and can be used in all contexts

    • -16
    • +16
    /openacs-4/packages/xowf/tcl/xowf-procs.tcl
improve ease of debugging

prefer "nsf::is object" over ":isobject" or "info commands", since it is faster, more generic and can be used in all contexts

prefer "nsf::is object" over ":isobject" or "info commands", since it is faster, more generic and can be used in all contexts

prefer "nsf::is object" over ":isobject" or "info commands", since it is faster, more generic and can be used in all contexts

    • -2
    • +2
    /openacs-4/packages/xowiki/tcl/xowiki-procs.tcl
prefer "nsf::is object" over ":isobject" or "info commands", since it is faster, more generic and can be used in all contexts

    • -3
    • +3
    /openacs-4/packages/xowiki/tcl/folder-procs.tcl
    • -5
    • +5
    /openacs-4/packages/xowiki/tcl/import-procs.tcl
    • -3
    • +3
    /openacs-4/packages/xowiki/tcl/package-procs.tcl
    • -1
    • +1
    /openacs-4/packages/xowiki/tcl/weblog-procs.tcl
    • -7
    • +7
    /openacs-4/packages/xowiki/tcl/xowiki-procs.tcl
    • -8
    • +8
    /openacs-4/packages/xowiki/www/admin/test.tcl
call isobject method with full namespace as we are not in a xotcl proc

execute the atjobs as close as possible to the full minute (see suggestion #3415)

    • -4
    • +22
    /openacs-4/packages/xowf/tcl/xowf-init.tcl
improve readability with sanitized error log

Add a test about group membership for tcl api as well (will right now fail on direct membership)

Replace deprecated proc

Replace deprecated api in this weird adp

provide proper title properties in .adp files to reduce warnings in log files

Add new private proc 'attachments::get_attachments_url', and use it to complement the logic of 'attachments::get_url'

As 'attachments::get_url' returns the value of the attachments package

'RelativeUrl' parameter, which can change at any time, it could happen

that previously mounted attachments have a different url and are not

found anymore.

We try our best here to find a mounted attachments package under

'base_url' to mitigate this, probably flawed, package logic.

In the future, probably a better method should be used for URL resolving

that is not so broken.

The whole thing is even more weird, as the attachments package is

currently a singleton that auto-mounts on /attachments, so i am tempted

to replace this whole thing with just that, but anyway...

Use 'attachments::detach_url' instead of building manually the URL

ensure ::xo::cc is available

Deprecate trivial empty_string_p

Bump version to reload message keys

Renaming of files so they are loaded after 00-icanuse-procs.tcl

    • -3800
    • +0
    /openacs-4/packages/acs-tcl/tcl/00-database-procs.tcl
    • -0
    • +3800
    /openacs-4/packages/acs-tcl/tcl/01-database-procs.tcl
file 01-database-procs-oracle.tcl was initially added on branch oacs-5-10.

file 01-database-procs.tcl was initially added on branch oacs-5-10.

    • -0
    • +0
    /openacs-4/packages/acs-tcl/tcl/01-database-procs.tcl
file 01-database-procs-postgresql.tcl was initially added on branch oacs-5-10.

file 01-database-procs-postgresql-postgresql.xql was initially added on branch oacs-5-10.

    • -0
    • +0
    /openacs-4/packages/acs-tcl/tcl/01-database-procs-postgresql-postgresql.xql
use creation_user parameter on save_new, so that the party_id is recognized as creation_user

    • -2
    • +1
    /openacs-4/packages/xowf/tcl/atjob-procs.tcl
Localize some pretty names. Many thanks to Monika Andergassen

fix typo in filename and use opportunity to rename the proc after the API call.

file 00-icanuse-procs.tcl was initially added on branch oacs-5-10.

    • -0
    • +0
    /openacs-4/packages/acs-tcl/tcl/00-icanuse-procs.tcl
use the random number generator from OpenSSL, when available

don't write sensitive information into log files

Do not add the language prefix when the lookup already found exactly the page we were trying to reference (complies with current automated tests)

    • -3
    • +4
    /openacs-4/packages/xowiki/tcl/package-procs.tcl