OpenACS

Tools

Line History

Line Count Graph
Line Count Graph

Stats

Commits this week: 3
Total Committers: 146
Last Commit: 29 Oct
Commits this week: 3
Total Lines of Code (LoC): 7,561,880
Net change in LoC this week: 10

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated 3 hours ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Wednesday 29 Oct
11:46 am

mischa

Fix name of form - avoid swallowed form error messages

Options
    • -2
    • +2
    /openacs-4/packages/acs-lang/www/admin/edit-localized-message.tcl
Monday 27 Oct
2:12 pm

gustafn

changed infinite loop into a fixed number (5) of retries

Options
    • -1
    • +6
    /openacs-4/packages/assessment/tcl/as-item-data-procs.tcl
    • -1
    • +6
    /openacs-4/packages/assessment/tcl/as-session-procs.tcl
Sunday 26 Oct
10:10 am

mischa

Dont try to substitute variables here

Options
    • -1
    • +1
    /openacs-4/packages/acs-lang/www/admin/lookup.tcl
Wednesday 22 Oct
11:56 am

gustafn

backport from HEAD.

Bumped version number to 0.67d1, leaving room for further backports

Options
    • -2
    • +2
    /openacs-4/packages/xotcl-request-monitor/xotcl-request-monitor.info
    • -11
    • +2
    /openacs-4/packages/xotcl-request-monitor/tcl/throttle_mod-procs.tcl
11:50 am

gustafn

removed duplicated definition.

Many thanks to Franz Penz for noting it

Options
    • -11
    • +2
    /openacs-4/packages/xotcl-request-monitor/tcl/throttle_mod-procs.tcl
Tuesday 21 Oct
6:17 pm

gustafn

added an additinal has function scrypt-16384-1-8 to deal with argument flipping in NaviSever 4.99

Between 4.99.20 and 4.99.31 (inclusive) there is a argument flipping bug for

::ns_crypto::scrypt (the parameters "r" and "p" were interpreted with flipped

semantics). In case you are using SCRYPT for your password hashes with an

affected version, you have to change the hash argorithm from scrypt-16384-8-1

to scrypt-16384-1-8 to check the previouly hashed passwords correctly.

NaviServer 5 is not affected by this.

Options
    • -1
    • +16
    /openacs-4/packages/acs-tcl/tcl/security-procs.tcl
Tuesday 14 Oct
3:29 pm

gustafn

backport from HEAD

Options
    • -5
    • +25
    /openacs-4/packages/xotcl-request-monitor/tcl/throttle_mod-procs.tcl
3:28 pm

gustafn

improved robustness against certain installations:

- added exception handler for failed open command

- added sensible defaults in case the ns/parameter serverlog is not defined

Options
    • -3
    • +20
    /openacs-4/packages/xotcl-request-monitor/tcl/throttle_mod-procs.tcl
Sunday 12 Oct
12:38 pm

mischa

Use noi18n instead of literal to avoid localization of eventually nested messages at this point

Options
    • -5
    • +5
    /openacs-4/packages/acs-lang/www/admin/message-list.tcl
12:30 pm

mischa

Dont localize eventually nested messages at this point

Options
    • -5
    • +5
    /openacs-4/packages/acs-lang/www/admin/message-list.tcl
Friday 10 Oct
3:07 pm

mischa

Fix anchor by prepending form name

Options
    • -2
    • +2
    /openacs-4/packages/acs-subsite/www/shared/parameters.tcl
Wednesday 08 Oct
6:44 pm

gustafn

backported change from HEAD. Fixes #3479

See also https://github.com/openacs/openacs-core/commit/91bc59a427e2d2d5c45b243285ad4c4cf8b290c9

Options
    • -2
    • +2
    /openacs-4/packages/acs-admin/www/users/member-state-change.tcl
Thursday 25 Sep
7:03 pm

gustafn

improved robstness when raw IP-V6 addresses are configured (rather than domain names)

backport from head

Options
    • -2
    • +5
    /openacs-4/packages/acs-tcl/tcl/security-procs.tcl
1:28 pm

gustafn

improved robstness when raw IP-V6 addresses are configured (rather than domain names)

Options
    • -3
    • +6
    /openacs-4/packages/acs-tcl/tcl/security-procs.tcl
Wednesday 24 Sep
5:39 pm

gustafn

bugfix(util_driver_info): reduce dependency on hardcoded driver names

- Avoid reliance on specific driver names (nsssl, nsudp, nsunix,

nsopenssl, nssocket) by falling back to generic "ns_driver info"

when available.

- Added explicit error message when "hostname" is missing on a network

driver module to prevent silent misconfiguration. This fixes a

potential infinite loop when OpenACS attempts to resolve the

"hostname" value.

This is a backport from the HEAD branch

Options
    • -3
    • +38
    /openacs-4/packages/acs-tcl/tcl/utilities-procs.tcl
5:37 pm

gustafn

bugfix(util_driver_info): reduce dependency on hardcoded driver names

- Avoid reliance on specific driver names (nsssl, nsudp, nsunix,

nsopenssl, nssocket) by falling back to generic "ns_driver info"

when available.

- Added explicit error message when "hostname" is missing on a network

driver module to prevent silent misconfiguration. This fixes a

potential infinite loop when OpenACS attempts to resolve the

"hostname" value.

Options
    • -6
    • +41
    /openacs-4/packages/acs-tcl/tcl/utilities-procs.tcl
5:23 pm

gustafn

added debugging hooks

Options
    • -1
    • +9
    /openacs-4/packages/acs-tcl/tcl/security-procs.tcl
Tuesday 29 Jul
11:36 am

antoniop

Fix typo

Options
    • -2
    • +2
    /openacs-4/packages/richtext-tinymce/tcl/richtext-procs.tcl
11:32 am

antoniop

Bump tinyMCE default version number to 8.0.1

This is a major release upgrade, with a couple breaking changes (see https://www.tiny.cloud/docs/tinymce/latest/migration-from-7x/).

As language pack for version 8 do not exist yet, we currently keep using those from 7 for any version >= 7. This should go away as soon as an own language pack is released for 8.

Options
    • -2
    • +2
    /openacs-4/packages/richtext-tinymce/richtext-tinymce.info
    • -4
    • +13
    /openacs-4/packages/richtext-tinymce/tcl/richtext-procs.tcl
Monday 21 Jul
11:36 am

gustafn

bumped version number

Options
    • -2
    • +2
    /openacs-4/packages/acs-subsite/acs-subsite.info
11:23 am

gustafn

Fix accidental removal of root site‑node read permissions (#3477)

Submitting the “/” site‑map permissions form without any changes inadvertently

omitted direct (read‑only) permissions, causing not-logged-in users to see

“The page isn’t redirecting properly” when accessing the root node.

This change ensures that existing direct permissions are preserved when

the form is submitted, even if no changes were made.

Thanks to Khy H for reporting this!

Backport from main branch

Options
    • -1
    • +2
    /openacs-4/packages/acs-subsite/www/permissions/perm-include.tcl
11:21 am

gustafn

Fix accidental removal of root site‑node read permissions (#3477)

Submitting the “/” site‑map permissions form without any changes inadvertently

omitted direct (read‑only) permissions, causing not-logged-in users to see

“The page isn’t redirecting properly” when accessing the root node.

This change ensures that existing direct permissions are preserved when

the form is submitted, even if no changes were made.

Thanks to Khy H for reporting this!

Options
    • -1
    • +2
    /openacs-4/packages/acs-subsite/www/permissions/perm-include.tcl
Sunday 20 Jul
12:48 pm

gustafn

fix for bug #3476: ilike is not supported on Oracle

Many thanks to Sung Hong for the report and fix.

backport from HEAD

Options
    • -2
    • +2
    /openacs-4/packages/acs-subsite/www/permissions/perm-user-add-include.tcl
12:46 pm

gustafn

fix for bug #3476: ilike is not supported on Oracle

Many thanks to Sung Hong for the report and fix

Options
    • -2
    • +2
    /openacs-4/packages/acs-subsite/www/permissions/perm-user-add-include.tcl
9:37 am

gustafn

Avoid noisy “table not found” errors on PostgreSQL

Previously, our localization script always queried the Oracle‐specific

view `v$nls_valid_values`. On PostgreSQL this table doesn’t exist, so

the DB driver logged a misleading “relation does not exist” error.

Now, we only perform that query when connected to Oracle. For all other

DBs (e.g. PostgreSQL) we skip it, eliminating spurious errors from

the logs.

In the the futures, one should introduce a new API call named in the

lines of "get_NLS_Info" that encapsulates the database‐specific logic

for determining language, charset, and territory.

Options
    • -22
    • +23
    /openacs-4/packages/acs-lang/www/admin/locale-edit.tcl
Wednesday 09 Jul
5:38 pm

mischa

Allow to verify emails again (fix bug introduced in https://github.com/openacs/openacs-core/commit/3657d747e189ffc9b345b190e8969ff8db78c0c1 )

Options
    • -2
    • +2
    /openacs-4/packages/acs-admin/www/users/member-state-change.tcl
Sunday 06 Jul
7:35 pm

gustafn

bumped upstream version to 5.3.7

Options
    • -2
    • +2
    /openacs-4/packages/openacs-bootstrap5-theme/openacs-bootstrap5-theme.info
    • -1
    • +1
    /openacs-4/packages/openacs-bootstrap5-theme/tcl/resource-procs.tcl
Thursday 26 Jun
11:17 am

gustafn

bump upstream version number to 12.3.0

Options
    • -1
    • +1
    /openacs-4/packages/highcharts/tcl/resource-procs.tcl
Thursday 12 Jun
7:05 pm

gustafn

improved clarity of the code and simplified structure

Options
    • -16
    • +16
    /openacs-4/packages/acs-tcl/tcl/security-procs.tcl
Wednesday 11 Jun
11:36 am

gustafn

fix for using fallback interface and wrong results for non TLS installation

Many thanks to Antonio for flagging this and provide insights

Options
    • -3
    • +8
    /openacs-4/packages/acs-tcl/tcl/security-procs.tcl