• last updated 8 hours ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
no need for curly braces

extend test cases

improve documentation and streamline code

do not allow to edit unresolve links during the exam, but allow this in the preview mode

Inform widget: do not render any input element alongside the form value

Check if o is an object only once, use nsf idiom to check for a class, unwrap idioms

Port edit-new policy rule from original policy1 object, so that unresolved links can be rendered correctly

Fixes xowf create_composite_test_item automated test

Use package_id instead of the package object

    • -2
    • +2
    /openacs-4/packages/xowiki/tcl/package-procs.tcl
fix typo

    • -2
    • +2
    /openacs-4/packages/xowiki/tcl/package-procs.tcl
Disallow "create-from-prototype" to non-admins in exam-answering workflows.

Added policy priviledge "create-from-prototype"

In certain situations, creating pages from prototype pages might not

be allowed for certain users. The off-the-shelf policies allow

"create-from-prototype" to all users having "create" permissions on

the package_id (very similar to edit-new).

Improve program comments.

    • -30
    • +48
    /openacs-4/packages/xowiki/tcl/package-procs.tcl
Don't break the page cyclus protocol if not necessary.

There is no need to call ad_script_abort in a situation,

where the local installation is broken.

Modernize parameter parsing (query and includelet paramters)

- handle invalid UTF-8 exception that might be triggered by

"ns_parsequery" in newer versions of NaviServer

- the new code is about 4 times faster than the old one

- replaced array by dict

- don't create helper procs on the fly but use "nsf::parseargs" if possible

- added icanuse rules for

* "nsf::parseargs -asdict"

* "ns_parsequery -charset"

make function private

New test to detect smells of hacking in the code, raising a warning when certain smelly keywords are found

take out for the time being the pool question as parts of the composite question

describe_form: describe components of a copound test item rather than the container

Trap errors happening when taking the picture, potentially dependent on the specific hardware/sowftware setup of the user, and abort the session in this case

Prefer the more modern api and fallback on the old idiom to support older NaviServer versions

list covered test cases

improve description of package parameters

protect against a potential division by zero

improve comment

align to the usual naming convention (use "_not_cached" suffix)

mark uncalled function as deprecated

revert escaped debug output

    • -5
    • +0
    /openacs-4/packages/xowf/tcl/xowf-procs.tcl
streamline and extend test cases for resolving in composite items and in preview workflows

    • -3
    • +8
    /openacs-4/packages/xowf/tcl/xowf-procs.tcl
streamline substitution handling

Perform same substitutions as in other test-item workflows.

improve robustness for partial exams

Address issue with .SELF. references in exams (xowf)

Since it is the goal of the exams to store all resources directly

under the questions, handling extra .SELF. references (which are

inserted by a downstream plugin for CKeditor) do not make sense. A

probably cleaner solution to this is to configure the CKeditor

to omit the .SELF. references in these cases.

    • -8
    • +4
    /openacs-4/packages/xowiki/tcl/xowiki-procs.tcl