OpenACS

Tools

Line History

Line Count Graph
Line Count Graph

Stats

Commits this week: 2
Total Committers: 146
Last Commit: 19 Jan
Commits this week: 2
Total Lines of Code (LoC): 685,548
Net change in LoC this week: 0

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated 3 hours ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Sunday 19 Jan
9:54 am

gustafn

fixed bug security::validated_host_header

Many thanks to Claudio Pasolini for reporting and identifying the problem!

Options
    • -2
    • +2
    /openacs-4/packages/acs-tcl/tcl/security-procs.tcl
Friday 27 Dec 2024
8:00 pm

gustafn

backport from oacs-head, otherwise the cache viewer is unusuable

Options
    • -2
    • +2
    /openacs-4/packages/xotcl-core/xotcl-core.info
    • -1
    • +1
    /openacs-4/packages/xotcl-core/www/cache.tcl
7:28 pm

gustafn

Bumped version number of acs-tcl to 5.10.2d2

Options
    • -2
    • +2
    /openacs-4/packages/dotlrn/dotlrn.info
    • -2
    • +2
    /openacs-4/packages/dotlrn-bootstrap3-theme/dotlrn-bootstrap3-theme.info
7:25 pm

gustafn

Fixed bug in install-from-repository (issue #3472)

Install from repository (e.g., of /dotlrn) was horribly broken, see,

e.g., issue #3472. Furthermore, this bug was hard to debug, since it

showed up just during a complex installation attempts involving

install.xml, and it requires fetching from the repository. Therefore,

the debug rounds were quite time-consuming.

There were several problems involved:

1) dotlrn/install.xml was trying to set the theme to the

dotlrn-bootstrap3-theme, which was not loaded from the repository

2) The loading order was not correct, since the theme requires an

existing dotlrn instance to register the theme templates there.

3) The tests in install::xml::action::mount checking, if the package

was already mounted were incorrect, probably since many years. It

looks to me as some refactorings of the "get_node_id" semantics

(many years ago) were not reflected in this code. This bug let

the code assume, that the package was already mounted. Therefore,

the package was never mounted, causing a long tail of subsequent

issues.

4) the site_node::instantiate_and_mount call in

install::xml::action::mount was called with incorrect parameters,

causing overwriting of the site root node, leaving the site

completely unusable.

Bumped version number of acs-tcl to 5.10.2d1

Options
    • -2
    • +2
    /openacs-4/packages/acs-tcl/acs-tcl.info
    • -8
    • +14
    /openacs-4/packages/acs-tcl/tcl/install-procs.tcl
6:31 pm

gustafn

fixed overquoting in "ad_progress_base_end"

Options
    • -2
    • +8
    /openacs-4/packages/acs-tcl/tcl/defs-procs.tcl
6:13 pm

gustafn

dirty editor buffer

Options
    • -1
    • +1
    /openacs-4/packages/dotlrn/install.xml
6:05 pm

gustafn

switch responsibilities for theme setting

Options
    • -1
    • +1
    /openacs-4/packages/dotlrn/install.xml
    • -1
    • +1
    /openacs-4/packages/dotlrn-bootstrap3-theme/install.xml
5:45 pm

gustafn

One more attempt to install bootstrap3 theme automatically

Options
    • -1
    • +1
    /openacs-4/packages/dotlrn/install.xml
    • -2
    • +4
    /openacs-4/packages/dotlrn-bootstrap3-theme/tcl/theme-procs.tcl
1:32 pm

gustafn

fixed cut&paste problem

Options
    • -1210
    • +0
    /openacs-4/packages/acs-tcl/tcl/install-procs.tcl
1:09 pm

gustafn

reset to released version to keep differences little

Options
    • -1
    • +1201
    /openacs-4/packages/acs-tcl/tcl/install-procs.tcl
    • -13
    • +9
    /openacs-4/packages/acs-tcl/tcl/site-nodes-procs.tcl
    • -2
    • +1
    /openacs-4/packages/dotlrn-bootstrap3-theme/tcl/theme-procs.tcl
12:19 pm

gustafn

deactivate automated theme setting for now

Options
    • -1
    • +1
    /openacs-4/packages/dotlrn/install.xml
10:50 am

gustafn

keep theme-stetting for dotlrn themes in dotlrn, since it requires a dotlrn instance

but when the dotlrn is installed, it requires the dotlrn-theme package to be installed

Options
    • -0
    • +2
    /openacs-4/packages/acs-tcl/tcl/site-nodes-procs.tcl
    • -1
    • +1
    /openacs-4/packages/dotlrn/install.xml
    • -2
    • +3
    /openacs-4/packages/dotlrn/tcl/apm-callback-procs.tcl
    • -1
    • +1
    /openacs-4/packages/dotlrn-bootstrap3-theme/install.xml
10:22 am

gustafn

Continue working on the install.xml issue.

Options
    • -8
    • +9
    /openacs-4/packages/acs-tcl/tcl/site-nodes-procs.tcl
10:01 am

gustafn

added more debugging info

Options
    • -2
    • +7
    /openacs-4/packages/acs-tcl/tcl/install-procs.tcl
    • -2
    • +2
    /openacs-4/packages/acs-tcl/tcl/site-nodes-procs.tcl
9:29 am

gustafn

undo one more recent change

Options
    • -3
    • +3
    /openacs-4/packages/acs-tcl/tcl/install-procs.tcl
9:15 am

gustafn

undo recent change. This was not the problem

Options
    • -5
    • +1
    /openacs-4/packages/acs-tcl/tcl/install-procs.tcl
9:00 am

gustafn

added debug statement

Options
    • -0
    • +1
    /openacs-4/packages/acs-tcl/tcl/site-nodes-procs.tcl
Thursday 26 Dec 2024
7:25 pm

gustafn

try to get a non-empty context id

Options
    • -3
    • +7
    /openacs-4/packages/acs-tcl/tcl/install-procs.tcl
6:56 pm

gustafn

added debugging line

Options
    • -1
    • +8
    /openacs-4/packages/acs-tcl/tcl/install-procs.tcl
6:32 pm

gustafn

Fixed incorrect result handling from ::acs::site_node get_node_id

When

::acs::site_node get_node_id -url /$mount_point

is executed with a non-existing mount point, the node info of the

parent_id is returned. The code assumed that for such cases, the

resulting "object_id" member is empty. Since this affects only the

two action procs

install::xml::action::mount

install::xml::action::mount-existing

i have adjusted the behavior there.

Furthermore, some tests are now less mind-twisted.

Options
    • -13
    • +11
    /openacs-4/packages/acs-tcl/tcl/install-procs.tcl
12:10 pm

gustafn

strangely, parameter CommDefaultSiteTemplate_p was set on wrong package_id

Before this change, the install from repo on dotlrn led to error below.

this change makes sure, that the used "package_id" is the package_id from dotlrn.

: ERROR: -20000: The specified package 702 AND/OR parameter CommDefaultSiteTemplate_p do not exist in the system

: CONTEXT: PL/pgSQL function apm__id_for_name(integer,character varying) line 13 at RAISE

: PL/pgSQL function apm__set_value(integer,character varying,character varying) line 6 at assignment

oacs-5-10=# select * from apm_packages where package_key like '%dotlrn%';

package_id | package_key | instance_name | default_locale

------------+-------------------------+----------------------------+----------------

1843 | dotlrn-bm | dotLRN Bulk Mail Applet |

1850 | dotlrn-faq | dotLRN FAQ Applet |

1868 | dotlrn-forums | dotLRN Forums Applet |

1886 | dotlrn-fs | dotLRN File Storage Applet |

1933 | dotlrn-news | dotLRN News Applet |

1981 | dotlrn-portlet | dotLRN Portlet |

1998 | dotlrn-assessment | dotLRN Assessment Applet |

2040 | dotlrn-bootstrap3-theme | dotLRN Bootstrap 3 Theme |

oacs-5-10=# select * from apm_packages where package_id = 702;

package_id | package_key | instance_name | default_locale

------------+-------------+------------------------+----------------

702 | acs-subsite | #acs-kernel.Main_Site# |

Options
    • -1
    • +2
    /openacs-4/packages/dotlrn-bootstrap3-theme/tcl/theme-procs.tcl
11:15 am

gustafn

moved theme setting to theme package (dotlrn-bootstrap3-theme)

This make sure that in the loading sequence, the theme is available when one

tries to switch to it.

Options
    • -1
    • +1
    /openacs-4/packages/dotlrn/install.xml
    • -0
    • +2
    /openacs-4/packages/dotlrn-bootstrap3-theme/install.xml
Wednesday 25 Dec 2024
4:34 pm

gustafn

added "dotlrn-bootstrap3-theme" to dependencies to make it installable via "install.xml" for install-from-repository

Options
    • -2
    • +3
    /openacs-4/packages/dotlrn/dotlrn.info
12:04 pm

gustafn

fixed dependencies

Options
    • -3
    • +3
    /openacs-4/packages/dotlrn-bootstrap3-theme/dotlrn-bootstrap3-theme.info
Tuesday 24 Dec 2024
5:27 pm

gustafn

improved log messages

Options
    • -2
    • +3
    /openacs-4/packages/acs-tcl/tcl/apm-install-procs.tcl
5:18 pm

gustafn

bump maturity from 1 to 2

Options
    • -3
    • +3
    /openacs-4/packages/dotlrn-bootstrap3-theme/dotlrn-bootstrap3-theme.info
Tuesday 03 Sep 2024
4:14 pm

gustafn

fixed numbers

Options
    • -2
    • +2
    /openacs-4/Announce-OpenACS-5.10.1
2:59 pm

gustafn

small fix, when cookie times out and dotlrn is active

Options
    • -1
    • +4
    /openacs-4/packages/acs-tcl/tcl/security-procs.tcl
12:43 pm

antoniop

Cleanup leftover references to files deleted in https://cvs.openacs.org/changelog/OpenACS?cs=oacs-5-10%3Aantoniop%3A20200507144307

This was not preventing the installation or functionalities of the forums package, so it has been long missed. Upon closer inspection, errors were popping up in the installation UI.

Options
    • -2
    • +2
    /openacs-4/packages/forums/forums.info
    • -4
    • +1
    /openacs-4/packages/forums/sql/oracle/forums-create.sql
    • -3
    • +0
    /openacs-4/packages/forums/sql/oracle/forums-drop.sql
    • -3
    • +0
    /openacs-4/packages/forums/sql/postgresql/forums-create.sql
    • -3
    • +0
    /openacs-4/packages/forums/sql/postgresql/forums-drop.sql
10:41 am

gustafn

release work

Options
    • -0
    • +53
    /openacs-4/Announce-OpenACS-5.10.1
    • -9
    • +1380
    /openacs-4/ChangeLog
    • -0
    • +0
    /openacs-4/packages/acs-core-docs/www/aolserver.html
    • -0
    • +0
    /openacs-4/packages/acs-core-docs/www/aolserver4.html
    • -0
    • +0
    /openacs-4/packages/acs-core-docs/www/automated-testing-best-practices.html
    • -0
    • +0
    /openacs-4/packages/acs-core-docs/www/backup-recovery.html
    • -0
    • +0
    /openacs-4/packages/acs-core-docs/www/bootstrap-acs.html
    • -0
    • +0
    /openacs-4/packages/acs-core-docs/www/credits.html
    • -0
    • +0
    /openacs-4/packages/acs-core-docs/www/cvs-guidelines.html
    • -1
    • +1
    /openacs-4/packages/acs-core-docs/www/cvs-tips.adp
    • -1
    • +1
    /openacs-4/packages/acs-core-docs/www/cvs-tips.html
    • -0
    • +0
    /openacs-4/packages/acs-core-docs/www/db-api-detailed.html
    • -0
    • +0
    /openacs-4/packages/acs-core-docs/www/db-api.html
    • -15
    • +15
    /openacs-4/packages/acs-core-docs/www/docbook-primer.adp
    • -15
    • +15
    /openacs-4/packages/acs-core-docs/www/docbook-primer.html
  16. … 64 more files in changeset.