Dashboard

Improve HTML

modernize Tcl code

prefer ad_try over catch, simplify expression

add comment and improve linebreak

- prefer bool over int - reduce number of gotos - reduce number of returns before end of function - reduce variable scopes - add "const" declaration - white-space changes

fix typos

Protect Tcl's file operations against leading dashes in file names

change "fetch first 1 row only" to "limit 1" to generic xql file, since Oracle started to support fetch first only with version 12c

merge with changes from https://github.com/tekbasse/acs-mail-lite/tree/master/tcl

in essence, these changes provide support for handling email with attachments based on nsIMAP.

see https://openacs.org/forums/message-view?message_id=5378972 for more background

    • -0
    • +2434
    /openacs-4/packages/acs-mail-lite/tcl/email-inbound-procs.tcl
    • -0
    • +877
    /openacs-4/packages/acs-mail-lite/tcl/imap-inbound-procs.tcl
  1. … 57 more files in changeset.
align prototypes with function definitions

whitespace changes

prefer bool over int, white space changes

Add ad_script_abort (thanks to Felix Moedritscher)

Use ad_script_abort after ns_return

    • -2
    • +2
    /openacs-4/packages/xml-rpc/www/index.tcl
More code cleanup

- make nsf compilable with tcl 8.7.2 and TCL_NO_DEPRECATED turned on

- prefer bool over int

- reduce nr of returns before end of function

- line bread overlong function definitions

update genstub path to recent versions of Tcl releases

Consistently use ad_script_abort after ad_returnredirect

prefer boolean over int

Reduce number of return statements beofre end of function

cleanup: fix regression, prefer boolean over int, reduce number of returns befor end of function

ease life of colon cmd cachier

Don't pass colon-prefixed method names from setter cmd to SetInstVar() to avoid potential shimmering.

Fix bad handler type error, use ad_try/finally instead of else (Thanks to Felix Moedritscher)

    • -2
    • +2
    /openacs-4/packages/xowiki/tcl/import-procs.tcl
- add Tcl_Obj caching to cget argument - redued usage of goto statements - reduced size of largish function

introduce macro ObjTypeStr for commonly used idiom

prefer boolean over int

coloncmd reform (part 4): perform validation for per-object cases, provide more detailed statistics (when compiled with COLON_CMD_STATS)

Reduce memory consumption for cache by caching just cmds in non-volatile Tcl_Objs. Add optional statistics, when COLON_CMD_STATS is defined.

simplify expression

remove unneeded variable