• last updated 23 hours ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
improve spelling

  1. … 7 more files in changeset.
Prefer 'person::name' to 'acs_user::get_element ... -name'

  1. … 4 more files in changeset.
Prefer again 'person::name', as the proc has been reimplemented using 'person::get_person_info', which uses the new 'person_info_cache' cache.

  1. … 13 more files in changeset.
Whitespace changes

  1. … 11 more files in changeset.
Prefer 'acs_user::get_element ...' to 'person::name ...', in cases when 'person' is a user, as it doesn't rely on util_memoize_cache.

  1. … 13 more files in changeset.
Similar to www/index page:

- remove divergency between oracle and postgres code

- improve localization

- add author column to UI as was probably meant to be (author was selected, but not used)

- use multirow builtin count instead of manually generated one

Remove divergency between oracle and postgres codebase

Remove leftover xql and prefer acs_user::get api, as doesn't rely on util_memoize cache

Make filters consistent with what the list displays (approved means live_revision not nulll and latest revision = live_revision)

UI improvements and fix

- make sql portable

- bring all sql inline

- reduce query duplication

- simplify if idioms

- fix UI by unclobbering revision_id variable and allowing to select revision correctly

Improvement and fixes for this UI

- improve localization

- exploit builtin multirow feature

- reduce divergencies between oracle and postgres codebase

- remove unused sql columns

- invert boolean logics for approved and live to reflect sql clause behavior

Use cached user api to retrieve comment author

Resurrect xql files lost in previous commit, reduce differences between oracle and postgres codebase

    • -0
    • +37
    ./tcl/general-comments-procs-oracle.xql
    • -0
    • +39
    ./tcl/general-comments-procs-postgresql.xql
Do not trust 'print_attachments_p'

Rework adp boolean expressions

  1. … 25 more files in changeset.
Prefer literal in adp axpressions + Whitespace changes

  1. … 29 more files in changeset.
Prefer literal in adp axpressions

  1. … 8 more files in changeset.
Follow the "ugly" smell

rework of general-comments rendering so that the templating system is used, instead of handcrafted markup. Also, allow theming in the future.

    • -96
    • +0
    ./tcl/general-comments-procs-oracle.xql
    • -101
    • +0
    ./tcl/general-comments-procs-postgresql.xql
    • -124
    • +61
    ./tcl/general-comments-procs.tcl
make spelling more consistent

regenerated documentation

  1. … 27 more files in changeset.
Rework variable assignment (set -> lassign) + Whitespace changes

  1. … 3 more files in changeset.
Fix typos

Fix boolean expressions in -adp files, make termination after connection closing commands explicit

  1. … 12 more files in changeset.
Reduce divergencies between oracle and postgres codebase

  1. … 3 more files in changeset.
merged changes from the oacs-5-9 branch and resolved conflicts

    • -6
    • +7
    ./catalog/general-comments.de_DE.ISO-8859-1.xml
    • -0
    • +1
    ./catalog/general-comments.en_US.ISO-8859-1.xml
    • -3
    • +4
    ./catalog/general-comments.es_ES.ISO-8859-1.xml
    • -8
    • +9
    ./catalog/general-comments.it_IT.ISO-8859-1.xml
    • -1
    • +7
    ./tcl/general-comments-callback-procs.tcl
    • -1
    • +2
    ./tcl/general-comments-procs-oracle.xql
    • -1
    • +1
    ./tcl/general-comments-procs-postgresql.xql
  1. … 7820 more files in changeset.
regenerated ducumentation

  1. … 250 more files in changeset.
- do not depend on beta or development versions

- make sure that released versions are not beta or development

- align version numbers (e.g. use also 5.9.1 for xotcl-core)

- bump version numbers to 5.9.1

  1. … 83 more files in changeset.
bump version numbers to 5.9.1b9 respectively to 2.9.1b9 to prepare for release

  1. … 91 more files in changeset.
Fix spelling errors

    • -1
    • +1
    ./tcl/general-comments-callback-procs.tcl
  1. … 9 more files in changeset.
- bump version number of OpenACS to 5.9.1b3 and DotLRN to 2.9.1b3

  1. … 79 more files in changeset.