• last updated 5 hours ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
improve spelling

  1. … 2 more files in changeset.
Move 'util::content_size_pretty' into 'acs-lang' and rename it to 'lc_content_size_pretty', localicing 'bytes' and adapting automated tests. Bump 'acs-lang' version.

  1. … 41 more files in changeset.
Prettify data size using 'util::content_size_pretty'

  1. … 1 more file in changeset.
Fix typo

Remove obsolete xql files

improve spelling

  1. … 21 more files in changeset.
Bring files on oacs-5-10 in sync with HEAD

    • -0
    • +37
    ./tcl/general-comments-procs-oracle.xql
    • -0
    • +39
    ./tcl/general-comments-procs-postgresql.xql
  1. … 2 more files in changeset.
Bring files on oacs-5-10 in sync with HEAD

  1. … 148 more files in changeset.
improve spelling

  1. … 7 more files in changeset.
Prefer 'person::name' to 'acs_user::get_element ... -name'

  1. … 4 more files in changeset.
Prefer again 'person::name', as the proc has been reimplemented using 'person::get_person_info', which uses the new 'person_info_cache' cache.

  1. … 13 more files in changeset.
Whitespace changes

  1. … 11 more files in changeset.
Prefer 'acs_user::get_element ...' to 'person::name ...', in cases when 'person' is a user, as it doesn't rely on util_memoize_cache.

  1. … 13 more files in changeset.
Similar to www/index page:

- remove divergency between oracle and postgres code

- improve localization

- add author column to UI as was probably meant to be (author was selected, but not used)

- use multirow builtin count instead of manually generated one

Remove divergency between oracle and postgres codebase

Remove leftover xql and prefer acs_user::get api, as doesn't rely on util_memoize cache

Make filters consistent with what the list displays (approved means live_revision not nulll and latest revision = live_revision)

UI improvements and fix

- make sql portable

- bring all sql inline

- reduce query duplication

- simplify if idioms

- fix UI by unclobbering revision_id variable and allowing to select revision correctly

Improvement and fixes for this UI

- improve localization

- exploit builtin multirow feature

- reduce divergencies between oracle and postgres codebase

- remove unused sql columns

- invert boolean logics for approved and live to reflect sql clause behavior

Use cached user api to retrieve comment author

file general-comments-procs-oracle.xql was added on branch oacs-5-10 on 2019-02-16 09:33:45 +0000

    • -0
    • +0
    ./tcl/general-comments-procs-oracle.xql
file general-comments-procs-postgresql.xql was added on branch oacs-5-10 on 2019-02-16 09:33:45 +0000

    • -0
    • +0
    ./tcl/general-comments-procs-postgresql.xql
Resurrect xql files lost in previous commit, reduce differences between oracle and postgres codebase

    • -0
    • +37
    ./tcl/general-comments-procs-oracle.xql
    • -0
    • +39
    ./tcl/general-comments-procs-postgresql.xql
Do not trust 'print_attachments_p'

Rework adp boolean expressions

  1. … 25 more files in changeset.
Prefer literal in adp axpressions + Whitespace changes

  1. … 29 more files in changeset.
Prefer literal in adp axpressions

  1. … 8 more files in changeset.
Follow the "ugly" smell

rework of general-comments rendering so that the templating system is used, instead of handcrafted markup. Also, allow theming in the future.

    • -96
    • +0
    ./tcl/general-comments-procs-oracle.xql
    • -101
    • +0
    ./tcl/general-comments-procs-postgresql.xql
    • -124
    • +61
    ./tcl/general-comments-procs.tcl
make spelling more consistent

regenerated documentation

  1. … 27 more files in changeset.