OpenACS

openacs-4

Tools

Line History

Line Count Graph
Line Count Graph

Stats

Commits this week: 6
Total Committers: 144
Last Commit: 14:46
Commits this week: 6
Total Lines of Code (LoC): 6,319,988
Net change in LoC this week: 47,825

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated 7 hours ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Friday 19 Jul
1:46 pm

antoniop

Remove xowiki dependency from CKEditor4

Rationale: CKEditor4 is EOL for its free version and the paid LTS version will be discontinued in December 2026.

We now do not set an explicit default for the preferred richtext editor. Instead, the first richtext-* package that will be installed with check whether a preferred editor was chosen. If not, they will set themselves as the xowiki editor. This should not change the behavior for existing installations already using ckeditor4, or a different editor.

Options
    • -0
    • +16
    ./packages/richtext-ckeditor5/tcl/richtext-init.tcl
1:46 pm

antoniop

Remove xowiki dependency from CKEditor4

Rationale: CKEditor4 is EOL for its free version and the paid LTS version will be discontinued in December 2026.

We now do not set an explicit default for the preferred richtext editor. Instead, the first richtext-* package that will be installed with check whether a preferred editor was chosen. If not, they will set themselves as the xowiki editor. This should not change the behavior for existing installations already using ckeditor4, or a different editor.

Options
    • -0
    • +16
    ./packages/richtext-ckeditor4/tcl/richtext-init.tcl
    • -0
    • +16
    ./packages/richtext-tinymce/tcl/richtext-init.tcl
    • -0
    • +16
    ./packages/richtext-xinha/tcl/richtext-init.tcl
    • -4
    • +3
    ./packages/xowiki/xowiki.info
1:11 pm

gustafn

Fixed several issue with the regression test case

- don't hard-code locales

- don't base decision to perform decimal comma tests on the fact that the locale is enabled

(it might be enabled but not loaded)

- perform test, when a locale with decimal point is enabled and loaded and the locale

of the test user can be set to it

Options
    • -9
    • +23
    ./packages/xowiki/tcl/test/xowiki-test-procs.tcl
12:57 pm

gustafn

load catalog when enabling a locale

Options
    • -1
    • +2
    ./packages/acs-lang/tcl/lang-install-procs.tcl
12:55 pm

gustafn

The internationalization admin page is not only package specific, move it up

Options
    • -1
    • +1
    ./packages/acs-admin/lib/site-wide-services.adp
Thursday 18 Jul
7:52 pm

gustafn

improved test coverage

Options
    • -2
    • +4
    ./packages/acs-automated-testing/tcl/test/acs-automated-testing-procs.tcl
    • -2
    • +5
    ./packages/file-storage/tcl/test/file-storage-procs.tcl
7:52 pm

gustafn

reduce verbosity

Options
    • -1
    • +1
    ./packages/acs-content-repository/tcl/revision-procs.tcl
5:24 pm

antoniop

Rely on the system configuration to figure out the right richtext editor and its configuration

Options
    • -1
    • +1
    ./packages/xowf/tcl/test-item-procs.tcl
4:38 pm

gustafn

reduce verbosity

Options
    • -2
    • +2
    ./packages/acs-api-browser/tcl/acs-api-documentation-procs.tcl
    • -3
    • +3
    ./packages/acs-api-browser/tcl/test/acs-api-browser-procs.tcl
    • -3
    • +3
    ./packages/acs-lang/tcl/localization-procs.tcl
4:08 pm

gustafn

Provide log statistics including full startup

Bump version number to 5.10.1b2 to make sure, that recent zz-postload.tcl is installed

Options
    • -2
    • +2
    ./packages/acs-bootstrap-installer/acs-bootstrap-installer.info
    • -4
    • +2
    ./packages/acs-bootstrap-installer/bootstrap.tcl
    • -6
    • +15
    ./packages/acs-bootstrap-installer/installer/tcl/zz-postload.tcl
12:36 pm

gustafn

fixed test server_startup_ok

Previously, the test was returning different results depending on the order of

tests.

While it is in general better to avoid error entries in the log file during

regression test, since these testing expected behavior, while error entries

in the log file should indicated unexpected behavior. However, it is still

a long way to let the regression test run cleanly.

Options
    • -2
    • +7
    ./packages/acs-bootstrap-installer/bootstrap.tcl
    • -1
    • +1
    ./packages/acs-tcl/tcl/test/acs-tcl-test-procs.tcl
12:05 pm

gustafn

Fixed regression test and make more use of "aa_test_start" and "aa_test_end"

This change reduces the errors in the log file a lets run the

regression test (on my site) without reported errors as reported by

acs_kernel__server_startup_ok.

Options
    • -1
    • +3
    ./packages/acs-automated-testing/tcl/aa-test-procs.tcl
    • -6
    • +13
    ./packages/acs-bootstrap-installer/tcl/00-proc-procs.tcl
    • -5
    • +10
    ./packages/acs-tcl/tcl/apm-xml-procs.tcl
    • -5
    • +9
    ./packages/acs-tcl/tcl/text-html-procs.tcl
12:02 pm

antoniop

Adjust TinyMCE behavior for the cornercase of a nested compound field with inline editor

Options
    • -2
    • +13
    ./packages/xowiki/tcl/form-field-procs.tcl
10:56 am

gustafn

mark the new aa_test* calls to be covered

Options
    • -0
    • +3
    ./packages/acs-automated-testing/tcl/test/acs-automated-testing-procs.tcl
10:50 am

gustafn

Skip test, when the optional parameter DiskCache is not defined.

Otherwise, the attempt to set the parameter will fail and will output

an error message to the log file.

Options
    • -3
    • +17
    ./packages/acs-tcl/tcl/test/acs-cache-procs.tcl
10:45 am

gustafn

Spelling changes

Options
    • -3
    • +3
    ./packages/acs-tcl/tcl/test/acs-tcl-test-procs.tcl
10:44 am

gustafn

Provide an API to check/set/clear the state of the regression test

The new calls are:

- aa_test_running_p

- aa_test_start

- aa_test_end

Options
    • -8
    • +31
    ./packages/acs-automated-testing/tcl/aa-test-procs.tcl
    • -3
    • +3
    ./packages/acs-tcl/tcl/security-procs.tcl
9:56 am

antoniop

Unset the "required" HTML5 attribute after the superclass initialization, because the textarea superclass will set it back again otherwise

Options
    • -2
    • +2
    ./packages/xowiki/tcl/form-field-procs.tcl
9:54 am

antoniop

Claim additional coverage

Options
    • -1
    • +5
    ./packages/acs-tcl/tcl/test/text-html-procs.tcl
Wednesday 17 Jul
3:56 pm

gustafn

skip hopeless tests, where mail server is not configured

Options
    • -6
    • +6
    ./packages/acs-authentication/tcl/authentication-procs.tcl
    • -4
    • +15
    ./packages/acs-authentication/tcl/test/acs-authentication-procs.tcl
3:55 pm

gustafn

fixed regression test to use [::acs::test::url] instead of [ad_url] during regression test

Options
    • -2
    • +2
    ./packages/acs-authentication/tcl/test/sync-test-procs.tcl
3:53 pm

gustafn

::acs_mail_lite::configured_p: check, if we can connect to the mail server

This new function has the goal to centralize tests to check, whether

the SMTP server is properly configured and ready to accept mail

requests. This is currently just used in the regression test to skip

hopeless tests.

Later, we should extend the regression test to test whether

sending of real emails works.

Options
    • -2
    • +31
    ./packages/acs-mail-lite/tcl/acs-mail-lite-procs.tcl
    • -9
    • +4
    ./packages/acs-mail-lite/tcl/test/acs-mail-lite-procs.tcl
3:12 pm

antoniop

Extend test suite to check URL protocol validation

Options
    • -0
    • +52
    ./packages/acs-tcl/tcl/test/text-html-procs.tcl
2:53 pm

antoniop

Complete the URL earlier, so that protocol-relative URLs can be correctly determined as external or not

Options
    • -7
    • +11
    ./packages/acs-tcl/tcl/text-html-procs.tcl
2:52 pm

antoniop

Extend test suite to check behavior validating external URLs

Options
    • -0
    • +63
    ./packages/acs-tcl/tcl/test/text-html-procs.tcl
2:34 pm

gustafn

Fixes for regression test: util_http_json_encoding

This change corrects 2 bugs, causing the regression test to fail under certain circumstances:

1) use for test location [::acs::test::url] instead of [ad_url]

The call [::acs::test::url] should be used for all tests in the regression tests and avoids

problems with wrong URLs when running e.g. in a container

2) When running on a setup with self-signed certificates, the curl requests require a "-k"

flag to be passed. Otherwise, the regression test fails.

Options
    • -10
    • +11
    ./packages/acs-tcl/tcl/http-client-procs.tcl
    • -4
    • +7
    ./packages/acs-tcl/tcl/test/http-client-procs.tcl
2:29 pm

antoniop

Rework URL validation in ad_dom_sanitize_html

We now prefer higher level api to determine:

- if a URL is external

- what protocol should be assumed for a URL when this is relative or protocol-relative

Options
    • -81
    • +38
    ./packages/acs-tcl/tcl/text-html-procs.tcl
1:23 pm

antoniop

Fix test case

Options
    • -1
    • +1
    ./packages/acs-tcl/tcl/test/text-html-procs.tcl
11:39 am

antoniop

Extend test suite

Options
    • -0
    • +5
    ./packages/acs-tcl/tcl/test/text-html-procs.tcl
8:47 am

mischa

Don't append a dot to the confirmation_url to avoid 'dead URL'-problems in e-mail clients. Put the URL in quotes.

Options
    • -1
    • +1
    ./packages/acs-subsite/catalog/acs-subsite.ru_RU.utf-8.xml