OpenACS

openacs-4

Tools

Line History

Line Count Graph
Line Count Graph

Stats

Commits this week: 3
Total Committers: 144
Last Commit: 18 Sep
Commits this week: 3
Total Lines of Code (LoC): 6,319,975
Net change in LoC this week: -9

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated 11 hours ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Wednesday 17 Jul
3:12 pm

antoniop

Extend test suite to check URL protocol validation

Options
    • -0
    • +52
    ./packages/acs-tcl/tcl/test/text-html-procs.tcl
2:53 pm

antoniop

Complete the URL earlier, so that protocol-relative URLs can be correctly determined as external or not

Options
    • -7
    • +11
    ./packages/acs-tcl/tcl/text-html-procs.tcl
2:52 pm

antoniop

Extend test suite to check behavior validating external URLs

Options
    • -0
    • +63
    ./packages/acs-tcl/tcl/test/text-html-procs.tcl
2:34 pm

gustafn

Fixes for regression test: util_http_json_encoding

This change corrects 2 bugs, causing the regression test to fail under certain circumstances:

1) use for test location [::acs::test::url] instead of [ad_url]

The call [::acs::test::url] should be used for all tests in the regression tests and avoids

problems with wrong URLs when running e.g. in a container

2) When running on a setup with self-signed certificates, the curl requests require a "-k"

flag to be passed. Otherwise, the regression test fails.

Options
    • -10
    • +11
    ./packages/acs-tcl/tcl/http-client-procs.tcl
    • -4
    • +7
    ./packages/acs-tcl/tcl/test/http-client-procs.tcl
2:29 pm

antoniop

Rework URL validation in ad_dom_sanitize_html

We now prefer higher level api to determine:

- if a URL is external

- what protocol should be assumed for a URL when this is relative or protocol-relative

Options
    • -81
    • +38
    ./packages/acs-tcl/tcl/text-html-procs.tcl
1:23 pm

antoniop

Fix test case

Options
    • -1
    • +1
    ./packages/acs-tcl/tcl/test/text-html-procs.tcl
11:39 am

antoniop

Extend test suite

Options
    • -0
    • +5
    ./packages/acs-tcl/tcl/test/text-html-procs.tcl
8:47 am

mischa

Don't append a dot to the confirmation_url to avoid 'dead URL'-problems in e-mail clients. Put the URL in quotes.

Options
    • -1
    • +1
    ./packages/acs-subsite/catalog/acs-subsite.ru_RU.utf-8.xml
8:43 am

mischa

Don't append a dot to the confirmation_url to avoid 'dead URL'-problems in e-mail clients.

Options
    • -1
    • +1
    ./packages/acs-subsite/catalog/acs-subsite.de_DE.ISO-8859-1.xml
Tuesday 16 Jul
7:12 pm

gustafn

provide a better domain name for temporal accounts in regression test

Options
    • -2
    • +2
    ./packages/acs-tcl/tcl/test/community-core-test-procs.tcl
7:11 pm

gustafn

fixed regression test, when mailserver is not yet set up (nssmtpd only)

Options
    • -3
    • +7
    ./packages/acs-mail-lite/tcl/acs-mail-lite-procs.tcl
    • -27
    • +39
    ./packages/acs-mail-lite/tcl/test/acs-mail-lite-procs.tcl
    • -1
    • +1
    ./packages/acs-mail-lite/tcl/test/email-inbound-procs.tcl
3:31 pm

gustafn

made test for valid protocols case invariant

Options
    • -7
    • +13
    ./packages/acs-tcl/tcl/text-html-procs.tcl
Monday 15 Jul
5:34 pm

antoniop

Reflect api changes in the test suite

Options
    • -1
    • +7
    ./packages/acs-tcl/tcl/test/utilities-procs.tcl
2:07 pm

gustafn

improved spelling consistency

Options
    • -2
    • +2
    ./packages/forums/tcl/forums-procs.tcl
2:04 pm

gustafn

improved spelling

Options
    • -2
    • +2
    ./packages/acs-authentication/tcl/sync-procs.tcl
    • -2
    • +2
    ./packages/acs-automated-testing/tcl/aa-test-procs.tcl
    • -2
    • +2
    ./packages/acs-lang/tcl/lang-message-procs.tcl
    • -2
    • +2
    ./packages/acs-lang/tcl/locale-procs.tcl
    • -2
    • +2
    ./packages/acs-tcl/tcl/security-procs.tcl
    • -2
    • +2
    ./packages/acs-templating/tcl/spellcheck-init.tcl
    • -242
    • +0
    ./packages/acs-templating/www/admin/test/if.adp
    • -25
    • +0
    ./packages/acs-templating/www/admin/test/if.tcl
    • -1
    • +1
    ./packages/assessment/tcl/as-install-procs.tcl
    • -2
    • +2
    ./packages/notifications/tcl/notification-email-procs.tcl
    • -2
    • +2
    ./packages/oacs-dav/tcl/oacs-dav-install-procs.tcl
    • -1
    • +1
    ./packages/xooauth/tcl/oauth-procs.tcl
    • -2
    • +2
    ./packages/xowf/tcl/test-item-procs.tcl
    • -3
    • +3
    ./packages/xowiki/tcl/form-field-procs.tcl
    • -2
    • +2
    ./packages/xowiki/tcl/xowiki-www-procs.tcl
1:44 pm

gustafn

adapt to latest cluster management changes in acs-tcl

Options
    • -6
    • +9
    ./packages/acs-admin/www/cluster.tcl
1:43 pm

gustafn

improved Tcl9 compatibility

Options
    • -1
    • +9
    ./packages/acs-api-browser/tcl/acs-api-documentation-procs.tcl
1:42 pm

gustafn

improved typesetting in email to admin to increase readability

Options
    • -4
    • +5
    ./packages/xotcl-request-monitor/tcl/throttle_mod-procs.tcl
1:41 pm

gustafn

improved spelling

Options
    • -2
    • +2
    ./packages/xotcl-core/tcl/05-db-procs.tcl
    • -2
    • +2
    ./packages/xotcl-core/tcl/bgdelivery-procs.tcl
Thursday 11 Jul
7:19 am

gustafn

Cluster updates: better support when running in containers

- generalized servers running with an INADDR_ANY address

- handling of running server with ephemeral ports

- streamline function and variable names

- added ./tcl/acs-container-procs.tcl

* make container definitions independent of cluster handling

* create container mapping based on a JSON file, which

can be obtained from docker to get information about

external addresses

* The final interface is a mapping file in Tcl providing at least

the Tcl dict ::docker::containerMapping containing the docker

mapping. A dict key like "8080/tcp" (internal port) will return a

dict containing the keys "host", "port" and "proto" (e.g. proto

https host 192.168.1.192 port 58115).

Options
    • -0
    • +100
    ./packages/acs-tcl/tcl/acs-container-procs.tcl
    • -4
    • +5
    ./packages/acs-tcl/tcl/cluster-init.tcl
    • -61
    • +202
    ./packages/acs-tcl/tcl/cluster-procs.tcl
    • -4
    • +10
    ./packages/acs-tcl/tcl/server-cluster-procs.tcl
7:19 am

gustafn

file acs-container-procs.tcl was initially added on branch oacs-5-10.

Options
    • -0
    • +0
    ./packages/acs-tcl/tcl/acs-container-procs.tcl
Wednesday 10 Jul
3:57 pm

antoniop

In the end we do phase out the util_expand_entities* procs for being too lame

Good riddance

Options
    • -7
    • +10
    ./packages/acs-tcl/tcl/text-html-procs.tcl
    • -77
    • +0
    ./packages/acs-tcl/tcl/test/text-html-procs.tcl
3:12 pm

gustafn

a protocol relative URL is not complete, but it can be understood as external

Options
    • -8
    • +21
    ./packages/acs-tcl/tcl/utilities-procs.tcl
    • -1
    • +23
    ./packages/acs-tcl/tcl/test/acs-tcl-test-procs.tcl
2:42 pm

antoniop

Make util_complete_url_p recognize protocl-relative URLs

Options
    • -9
    • +5
    ./packages/acs-tcl/tcl/utilities-procs.tcl
2:41 pm

antoniop

Extend the test cases for util_complete_url_p with a case of protocol-relative URL

Options
    • -0
    • +1
    ./packages/acs-tcl/tcl/test/acs-tcl-test-procs.tcl
Monday 08 Jul
5:17 pm

antoniop

Reimplement util_expand_entities_ie_style

This proc turned out to be long broken. We could consider phasing it out, but as it is a public interface used in a few places we prefer to keep it around and try to fix it.

The intended behavior has been reconstructed from the documentation. The new approach uses a single regexp to extract entities, which does not risk to loop indefinitely as before.

Options
    • -44
    • +29
    ./packages/acs-tcl/tcl/text-html-procs.tcl
5:10 pm

antoniop

Test util_expand_entities and util_expand_entities_ie_style

This test will show that since the long broken parenthesys in util_expand_entities_ie_style were fixed in a recent commit, this proc will just not work.

Options
    • -0
    • +77
    ./packages/acs-tcl/tcl/test/text-html-procs.tcl
4:15 pm

antoniop

Fix typo

Options
    • -2
    • +2
    ./packages/acs-automated-testing/tcl/aa-test-procs.tcl
4:10 pm

antoniop

After further consideration, ns_absoluteurl is actually sufficient to preform location header completion on its own and does not need a wrapper utility

Options
    • -5
    • +2
    ./packages/acs-automated-testing/tcl/aa-test-procs.tcl
    • -3
    • +1
    ./packages/acs-tcl/tcl/http-client-procs.tcl
    • -46
    • +1
    ./packages/acs-tcl/tcl/utilities-procs.tcl
    • -104
    • +0
    ./packages/acs-tcl/tcl/test/utilities-procs.tcl
3:20 pm

gustafn

Streamline terminology with other occurrences in OpenACS and NaviServer/AOLserver

- the term "location" is usually used in OpenACS/NaviServer/AOLserver for the

part of a URL before the path (i.e. SCHEME+HOST+PORT)

- the new function util::absolute_url is a value-added version of NaviServer's "ns_absoluteurl".

This is now documented with its differences, and aligned with its terminology

Options
    • -3
    • +3
    ./packages/acs-tcl/tcl/http-client-procs.tcl
    • -29
    • +29
    ./packages/acs-tcl/tcl/utilities-procs.tcl
    • -62
    • +66
    ./packages/acs-tcl/tcl/test/utilities-procs.tcl