• last updated 7 hours ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Spelling changes

Provide an API to check/set/clear the state of the regression test

The new calls are:

- aa_test_running_p

- aa_test_start

- aa_test_end

    • -3
    • +3
    ./packages/acs-tcl/tcl/security-procs.tcl
Unset the "required" HTML5 attribute after the superclass initialization, because the textarea superclass will set it back again otherwise

    • -2
    • +2
    ./packages/xowiki/tcl/form-field-procs.tcl
Claim additional coverage

skip hopeless tests, where mail server is not configured

fixed regression test to use [::acs::test::url] instead of [ad_url] during regression test

::acs_mail_lite::configured_p: check, if we can connect to the mail server

This new function has the goal to centralize tests to check, whether

the SMTP server is properly configured and ready to accept mail

requests. This is currently just used in the regression test to skip

hopeless tests.

Later, we should extend the regression test to test whether

sending of real emails works.

Extend test suite to check URL protocol validation

Complete the URL earlier, so that protocol-relative URLs can be correctly determined as external or not

    • -7
    • +11
    ./packages/acs-tcl/tcl/text-html-procs.tcl
Extend test suite to check behavior validating external URLs

Fixes for regression test: util_http_json_encoding

This change corrects 2 bugs, causing the regression test to fail under certain circumstances:

1) use for test location [::acs::test::url] instead of [ad_url]

The call [::acs::test::url] should be used for all tests in the regression tests and avoids

problems with wrong URLs when running e.g. in a container

2) When running on a setup with self-signed certificates, the curl requests require a "-k"

flag to be passed. Otherwise, the regression test fails.

    • -10
    • +11
    ./packages/acs-tcl/tcl/http-client-procs.tcl
Rework URL validation in ad_dom_sanitize_html

We now prefer higher level api to determine:

- if a URL is external

- what protocol should be assumed for a URL when this is relative or protocol-relative

    • -81
    • +38
    ./packages/acs-tcl/tcl/text-html-procs.tcl
Fix test case

Extend test suite

Don't append a dot to the confirmation_url to avoid 'dead URL'-problems in e-mail clients. Put the URL in quotes.

Don't append a dot to the confirmation_url to avoid 'dead URL'-problems in e-mail clients.

provide a better domain name for temporal accounts in regression test

fixed regression test, when mailserver is not yet set up (nssmtpd only)

made test for valid protocols case invariant

    • -7
    • +13
    ./packages/acs-tcl/tcl/text-html-procs.tcl
Reflect api changes in the test suite

improved spelling consistency

    • -2
    • +2
    ./packages/forums/tcl/forums-procs.tcl
improved spelling

    • -2
    • +2
    ./packages/acs-lang/tcl/lang-message-procs.tcl
    • -2
    • +2
    ./packages/acs-lang/tcl/locale-procs.tcl
    • -2
    • +2
    ./packages/acs-tcl/tcl/security-procs.tcl
    • -242
    • +0
    ./packages/acs-templating/www/admin/test/if.adp
    • -25
    • +0
    ./packages/acs-templating/www/admin/test/if.tcl
    • -1
    • +1
    ./packages/assessment/tcl/as-install-procs.tcl
    • -1
    • +1
    ./packages/xooauth/tcl/oauth-procs.tcl
    • -2
    • +2
    ./packages/xowf/tcl/test-item-procs.tcl
    • -3
    • +3
    ./packages/xowiki/tcl/form-field-procs.tcl
    • -2
    • +2
    ./packages/xowiki/tcl/xowiki-www-procs.tcl
adapt to latest cluster management changes in acs-tcl

improved Tcl9 compatibility

improved typesetting in email to admin to increase readability

improved spelling

    • -2
    • +2
    ./packages/xotcl-core/tcl/05-db-procs.tcl
    • -2
    • +2
    ./packages/xotcl-core/tcl/bgdelivery-procs.tcl
Cluster updates: better support when running in containers

- generalized servers running with an INADDR_ANY address

- handling of running server with ephemeral ports

- streamline function and variable names

- added ./tcl/acs-container-procs.tcl

* make container definitions independent of cluster handling

* create container mapping based on a JSON file, which

can be obtained from docker to get information about

external addresses

* The final interface is a mapping file in Tcl providing at least

the Tcl dict ::docker::containerMapping containing the docker

mapping. A dict key like "8080/tcp" (internal port) will return a

dict containing the keys "host", "port" and "proto" (e.g. proto

https host 192.168.1.192 port 58115).

    • -0
    • +100
    ./packages/acs-tcl/tcl/acs-container-procs.tcl
    • -4
    • +5
    ./packages/acs-tcl/tcl/cluster-init.tcl
    • -61
    • +202
    ./packages/acs-tcl/tcl/cluster-procs.tcl
file acs-container-procs.tcl was initially added on branch oacs-5-10.

    • -0
    • +0
    ./packages/acs-tcl/tcl/acs-container-procs.tcl
In the end we do phase out the util_expand_entities* procs for being too lame

Good riddance

    • -7
    • +10
    ./packages/acs-tcl/tcl/text-html-procs.tcl
a protocol relative URL is not complete, but it can be understood as external

    • -8
    • +21
    ./packages/acs-tcl/tcl/utilities-procs.tcl
    • -1
    • +23
    ./packages/acs-tcl/tcl/test/acs-tcl-test-procs.tcl