• last updated 2 hours ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Normalize indentation

Decouple a bit formatting from data

Give templating a chance

move all hardcoded styling to the adp template, which might be styled by the theme. Also, biring some order in the login proc, e.g. don't open and read a file to include a javascript all the time.

Modernize XoTcl idioms

Whitespace changes + add editor hints

  1. … 26 more files in changeset.
Remove superflous parentheses

  1. … 29 more files in changeset.
Align case of acs_object_type with that of the actual table (fixes automated tests)

This change intentionally ignores Oracle, as its behavior with respect to case is not clear to me.

    • -0
    • +8
    ./sql/postgresql/upgrade/upgrade-5.0-5.0.1d0.sql
Trim whitespace

Use finer grained api for user name

Add better explanation in UI for the 'Archive' option

use more appropriate status codes for error messages

  1. … 1 more file in changeset.
Reduce divergency between oracle and postgres codebase

Moderator is really a generic party and not always a user

Reduce divergency between oracle and postgres codebase

    • -11
    • +0
    ./www/moderator-revoke-postgresql.xql
Whitespace changes

  1. … 5 more files in changeset.
Avoid unnecesary existence checks.

  1. … 5 more files in changeset.
Retract package parameter configuration, as chat is not a singleton package... not clear if we will want a global paremeter for this in the future

Reduce joining

Replace leftover Naviserver-only cache idioms with retro compatible ones

Create chat room cache in a way to provide compatibility with AOLserver

make timeout and cache size configurable.

Revert massive replacement of empty list creation sentences. The use of '[list]' instead of '{}' adds semantics that could be used for performance improvements in the future, such as using a different internal representation. There is already work in this direction, avoiding the generation of the string representation during comparison of empty strings (huge thanks to Stefan Sobernig for the pointer: https://core.tcl.tk/tcl/info/44527c632ed609c2).

  1. … 474 more files in changeset.
Rework variable assignment (set -> lassign) + Whitespace changes

  1. … 17 more files in changeset.
Prefer '{}' to '[list]' when creating empty lists

  1. … 225 more files in changeset.
Prefer '{}' to '[list]' when creating empty lists

  1. … 204 more files in changeset.
Fix typos

  1. … 28 more files in changeset.
fix typos

  1. … 2 more files in changeset.
Fix boolean expressions in -adp files, make termination after connection closing commands explicit

  1. … 14 more files in changeset.
merged changes from the oacs-5-9 branch and resolved conflicts

    • -1
    • +21
    ./catalog/chat.de_DE.ISO-8859-1.xml
    • -3
    • +12
    ./catalog/chat.en_US.ISO-8859-1.xml
    • -2
    • +11
    ./catalog/chat.es_ES.ISO-8859-1.xml
    • -0
    • +139
    ./catalog/chat.it_IT.ISO-8859-1.xml
    • -0
    • +255
    ./sql/oracle/upgrade/upgrade-5.0d10-5.0d11.sql
    • -295
    • +69
    ./sql/postgresql/chat-create.sql
    • -0
    • +114
    ./sql/postgresql/upgrade/upgrade-5.0d10-5.0d11.sql
    • -0
    • +57
    ./sql/postgresql/upgrade/upgrade-5.0d11-5.0d12.sql
    • -0
    • +18
    ./sql/postgresql/upgrade/upgrade-5.0d12-5.0d13.sql
    • -32
    • +50
    ./sql/postgresql/upgrade/upgrade-5.0d4-5.0d5.sql
  1. … 7820 more files in changeset.
- do not depend on beta or development versions

- make sure that released versions are not beta or development

- align version numbers (e.g. use also 5.9.1 for xotcl-core)

- bump version numbers to 5.9.1

  1. … 83 more files in changeset.
Use ad_script_abort everytime one issues ad_return_complaint, or subsequent errors will trigger without the user noticing