• last updated 12 hours ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Provide a specific message key for when messages are not available

Many thanks to Sebastian Scheder

Clear out old java codebase and update the docs referring to the previous java implementation

    • -132
    • +0
    ./java/adChatClientListener.java
  1. … 3 more files in changeset.
Move the main chat rendering in an include to allow reuse in other contexts

file chat.adp was initially added on branch oacs-5-10.

file chat.tcl was initially added on branch oacs-5-10.

skip "-url" in "export_vars -url" since it is the default

  1. … 11 more files in changeset.
bumped version numbers to 5.10.1b1

  1. … 85 more files in changeset.
Make sure only one tuple per room is returned

room_id is required

Improved SQL query significantly by using "acs_permission.permission_p_recursive_array"

Before, a sample query used 300K buffers, now it is down to 2.6 buffers.

Under bad conditions, the old query used 2s or more.

Fixed broken oracle.xql file (broken since 5 years)

Handle persisting messages from outside of a connection, e.g. in the chat sweeper

Also cleanup acs_attribute

Cleanup the vestigial moderated_p flag

  1. … 2 more files in changeset.
Get rid of the intermediate "room-enter" page and enforce all of the relevant permission in place in the "chat" page, cleanup variables and update automated tests

  1. … 1 more file in changeset.
Use better message key

Basic webtest of chat room creation

file webtest-procs.tcl was initially added on branch oacs-5-10.

    • -0
    • +0
    ./tcl/test/webtest-procs.tcl
Follow-up for https://cvs.openacs.org/changelog/OpenACS?cs=oacs-5-10%3Agustafn%3A20230313120323

- make sure the anonymous users nsv is created when the chat is instantiated

- make sure xo::cc is available when the anonymous identifier is generated

- handle in the Chat package, that the uid may not be a user, but an IP address

- adapt other chat skins to the new anonymous user logics

  1. … 5 more files in changeset.
Don't hardcode login requirement (to be continued)

Do not add additional style around the chat includelet, regardless if this is a "chat_room" or a "chat"

  1. … 3 more files in changeset.
Allow to pass down the skin configuration to the chat_room includelet

Complete coverage for the package

Fix syntax for proc coverage

Expect arbitrary arguments on inherited methods, detect instance variables that should be passed to the object creation in save_new

Test chat room creation

This test now fails because certain acs_object metadata are not taken from instance variables, but from the context

file chat-test-procs.tcl was initially added on branch oacs-5-10.

    • -0
    • +0
    ./tcl/test/chat-test-procs.tcl
prefer adp:icon over old-style .gif images

  1. … 13 more files in changeset.
improve Oracle compatibility

Deprecate export_entire_form_as_url_vars and replace occurrences, add a new -formvars flag to export vars to implement the behavior of the proc, that is, export a subset of the variables coming from the current request

  1. … 5 more files in changeset.