• last updated 6 hours ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Commented out obsolete and broken proc

    • -183
    • +187
    ./tcl/navigation-procs.tcl
- perform nonce-computation independent of user_id computation

- put resetting of untrusted user_id to the right place

- provide initial value for untrusted user_id

- setting nonce always (also for non-authenticated requests)

Some more Tcl cleanup

- use curly brackes to enable byte code compilation

- don't use "[expr ...]" when not needed

- prefer "incr i -1" over "set i [expr {$i - 1}] "

  1. … 14 more files in changeset.
- imporve ad_html_qualify_links in various ways (better argument name, better comments, removed superflous slashes, ...

- add a function ad_html_qualify_links to make e.g. relative URL handing in notifications easier

- use variable names consistently

- fix handling of csrf token

Increase timeout to 5 minutes for util::http and pure ns_http implementations (required on slow connections)

- one more typo

- fix recent editing bug

Fix typo in proc doc

Remove changes not meant to be committed

Fix bug when uninstalling packages having been upgraded over time

- no need for element-wise setting of array columns

- no need for intermediary variable

- fix documentation of acs_user::get: list full set of returned

attributes in documentation

- acs_user::get: return dict, when no argument "-array" is provided

- make sure, that the sec_handler's global variables are always set (also in error cases, blocked bots, etc.)

- use more consistent quoting

    • -12
    • +13
    ./tcl/request-processor-procs.tcl
- add warning in case site_node::get_node_id_from_object_id returns first of many urls

- replace onchange handlers in widget code by event listeners

- prefer subst over double quotes to reduce quoring hell

- avoid deprecated function ns_unregister_proc

- make handling of URLs pointing to unresolvable package_keys more robust

    • -44
    • +42
    ./tcl/request-processor-procs.tcl
- avoid potential errors in the error.log for urls which are not pointing to mounted packages (where [ad_conn package_key] is empty)

    • -37
    • +47
    ./tcl/request-processor-procs.tcl
- remove "global" statements and use "::" prefix instead

- fix code that can't work. ... anyhow, package_key seems not be used here

- Use get_referrer instead of ad hoc regexp to determine relative URLs.

- Fixed Regex used by "get_referrer -relative", which failed for root URLs

(i.e: http://www.openacs.org/). Thanks to Thomas Renner for the fix.

  1. … 1 more file in changeset.
- fix one more old bug with ad_text_to_html, where a mailto: was inserted incorrectly: part of URL was interpreted as a mail address: http://www.postgresql.org/message-id/20060329203545.M43728@narrowpathinc.com

- make sure cache is large enough to keep security tokes (needed, when signed attributes are used)