• last updated 7 hours ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
- fix handling of csrf token

Increase timeout to 5 minutes for util::http and pure ns_http implementations (required on slow connections)

- one more typo

- fix recent editing bug

Fix typo in proc doc

Remove changes not meant to be committed

Fix bug when uninstalling packages having been upgraded over time

- no need for element-wise setting of array columns

- no need for intermediary variable

- fix documentation of acs_user::get: list full set of returned

attributes in documentation

- acs_user::get: return dict, when no argument "-array" is provided

- make sure, that the sec_handler's global variables are always set (also in error cases, blocked bots, etc.)

- use more consistent quoting

    • -12
    • +13
    ./tcl/request-processor-procs.tcl
- add warning in case site_node::get_node_id_from_object_id returns first of many urls

- replace onchange handlers in widget code by event listeners

- prefer subst over double quotes to reduce quoring hell

- avoid deprecated function ns_unregister_proc

- make handling of URLs pointing to unresolvable package_keys more robust

    • -44
    • +42
    ./tcl/request-processor-procs.tcl
- avoid potential errors in the error.log for urls which are not pointing to mounted packages (where [ad_conn package_key] is empty)

    • -37
    • +47
    ./tcl/request-processor-procs.tcl
- remove "global" statements and use "::" prefix instead

- fix code that can't work. ... anyhow, package_key seems not be used here

- Use get_referrer instead of ad hoc regexp to determine relative URLs.

- Fixed Regex used by "get_referrer -relative", which failed for root URLs

(i.e: http://www.openacs.org/). Thanks to Thomas Renner for the fix.

  1. … 1 more file in changeset.
- fix one more old bug with ad_text_to_html, where a mailto: was inserted incorrectly: part of URL was interpreted as a mail address: http://www.postgresql.org/message-id/20060329203545.M43728@narrowpathinc.com

- make sure cache is large enough to keep security tokes (needed, when signed attributes are used)

Put again >= in place as before

Reverting previous change: I don't know since when in 4.99.12 dev versions we have dropped ns_ssl. Just stick to plain 4.99.12

Use 4.99.11 as comparison version to say: "from 4.99.12 upwards"

- provide a long description for maturity_deprecated

    • -1
    • +9
    ./catalog/acs-tcl.en_US.ISO-8859-1.xml
- use for hex codes 2-digit notation \xHH to make it compatible for tcl8.6

  1. … 5 more files in changeset.
- change special markers in text_to_html from \x001 and \x002 to \u0002 (start of text) and \u0003 (end of text). The previous coding did not work always reliably, regsub was missing some entries, probably due to a mess-up of the internal representation.

- fixing a probably old bug: changed the markers in ad_text_to_html since the old markers with the funy camel case led to problems (at least with current regexp implementations)

in the text below, only 5 of the 8 urls were correctly transformed into anchor markup. The new markers uses uniqe single char starting and ending marker, marking also regexp much simpler.

- the function is further generalized (unifying http/https/ftp urls with mailto urls) and probably faster

A welcome contribution would be e.g. an extension of the api-browser for callbacks (listing contracts/implementations, etc.).

[1] http://openacs.org/api-doc/proc-view?proc=callback&source_p=1

[2] https://github.com/openacs/openacs-core/blob/oacs-5-9/packages/search/tcl/search-procs.tcl#L309

[3] https://github.com/openacs/forums/blob/master/tcl/forums-callback-procs.tcl#L104

[4] https://github.com/openacs/openacs-core/blob/oacs-5-9/packages/acs-tcl/tcl/apm-procs.tcl

[5] http://openacs.org/api-doc/proc-view?source_p=1&proc=apm_arg_names_for_callback_type

[6] https://github.com/openacs/xowiki/blob/oacs-5-9/tcl/xowiki-callback-procs.tcl

[7] https://github.com/openacs/openacs-core/blob/oacs-5-9/packages/acs-subsite/tcl/subsite-callback-procs.tcl#L69

[8] https://github.com/openacs/xotcl-core/blob/oacs-5-9/tcl/06-param-procs.tcl#L386

- fix variable name

- remove erroneous warnings

- reduce the number of regsub operations in ad_text_to_html

- improve/fix souce code comments