• last updated 7 hours ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
removed unclear test

Whitespace changes + Editor hints

Relax error level

whitespace changes

    • -9
    • +8
    ./tcl/site-node-apm-integration-procs.tcl
  1. … 2 more files in changeset.
Mark 'whos_online::interval' as public, as it is used in 'acs-subsite'

Make a bunch of apm procs public, as they are used in 'acs-admin'.

Could be worth considering moving the ones used only in 'acs-admin' to that package, and making them private again, leaving public only those who may be useful to other packages/applications (i.e. CI/CD logic).

Mark 'apm_application_new_checkbox' as public, as it is used in the site-map

Mark 'sec_get_random_cached_token_id' as public, as it is used in 'acs-subsite'

Mark 'apm_mark_version_for_reload' as public, as it is used in 'acs-automated-testing'

Check also token value in nsv in 'secret_tokens_get' test case

fix and extend regression test, when bread-crumb label needs quoting

Whitespace changes

Change test category and rollback after execution

Add new 'secret_tokens_get' and refactor 'test_set_cookie_procs' to include cases handled by the deleted ancient tests in 'acs-admin/www/test/signed-cookies-test'

    • -64
    • +118
    ./tcl/test/test-set-cookie-procs.tcl
Improve robustness over invalid configurations

Previouly, the configuration of invalid hostnames (i.e. hostnames,

which cannot be resolved via the OS means) for a network driver

lead to runtime errors under certain conditions.

Fix typos (many thanks to Nathan Coulter)

Fix typo, many thanks to Nathan Coulter

Port of downstream fix: make sure the encoding for the proxied interpreter is the same as the main interpreter

Fixes acs-tcl.exec_binary_input automated test

Many thanks to Nathan Coulter

Port of new automated test exposing that with certain system encodings, proxied exec will not behave as the regular exec with respect to line translation

Many thanks to Nathan Coulter

file proxy-test-procs.tcl was initially added on branch oacs-5-10.

    • -0
    • +0
    ./tcl/test/proxy-test-procs.tcl
make "util_close_html_tags" public since it is called from public pages

Remove extra url decoding, ns_parsequery embeds it already

Remove extra decoding ns_parsequery provides it already

Use naviserver api to parse URL variables

  1. … 1 more file in changeset.
Use naviserver api to parse URL variables

  1. … 3 more files in changeset.
Use built-in "ns_parsequery" instead of manual parsing of query parameters

improve code orthogonality: support "acs_object::get ... -element" similar to "party::get"; return dict from acs_object::get

add tests for "acs_object::get ... -element"; use "string equal" instead of "string match" (since the latter is semantically incorrect)

    • -19
    • +17
    ./tcl/test/object-test-case-procs.tcl
whitespace changes: break overlong lines

remove dependency of general-comments on acs-mail-lite

  1. … 2 more files in changeset.