OpenACS / openacs-4 / packages

acs-tcl

Tools

Line History

Line Count Graph
Line Count Graph

Stats

Commits this week: 0
Total Committers: 73
Last Commit: 21 Nov
Commits this week: 0
Total Lines of Code (LoC): 74,867
Net change in LoC this week: 0

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated 6 hours ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Wednesday 13 Nov
9:43 am

gustafn

prefer more efficient approach to iterate over all key/values of an ns_set

Options
    • -18
    • +5
    ./tcl/tcl-documentation-procs.tcl
Thursday 07 Nov
12:54 pm

antoniop

Extend user_message feature so that a "severity" information can be passed alongside the message

This allows theme templates to color code messages according to their severity. Severity follows the Bootstrap nomenclature of "info", "success", "warning" and "danger".

Default severity has been set to "success" consistent with styling applied so far by OpenACS to the user messages.

Options
    • -3
    • +3
    ./acs-tcl.info
    • -4
    • +14
    ./tcl/utilities-procs.tcl
  3. … 7 more files in changeset.
Tuesday 29 Oct
4:58 pm

antoniop

Extend test suite to cover :multiple and :array

Options
    • -0
    • +93
    ./tcl/test/acs-tcl-test-procs.tcl
Monday 28 Oct
7:05 pm

gustafn

improved documentation, removed AOLserver stuff

Options
    • -140
    • +81
    ./tcl/acs-cache-procs.tcl
5:04 pm

gustafn

Remove AOLserver cruft

- reduced complexity of registering/invoking filters

- move more deprecated procs in acs-tcl to acs-tcl/tcl/deprecated-procs.tcl

Options
    • -3
    • +3
    ./acs-tcl.info
    • -2
    • +2
    ./tcl/admin-procs.tcl
    • -3
    • +103
    ./tcl/deprecated-procs.tcl
    • -3
    • +3
    ./tcl/request-processor-init.tcl
    • -137
    • +8
    ./tcl/request-processor-procs.tcl
  6. … 4 more files in changeset.
3:25 pm

antoniop

Consider documentation the presence of an author

Options
    • -1
    • +2
    ./tcl/test/doc-check-procs.tcl
Sunday 27 Oct
5:51 pm

gustafn

New API function: ad_docbook_xml_to_html

This function converts DocBook XML as used in the OpenACS

documentation to HTML. This is not a full implementation of all

possible DocBook markup, but just a subset sufficient for rendering a

substantial subset of the OpenACS documentation.

The function can be used via

set html [ad_html_text_convert -from application/docbook+xml -to text/html $text]

or

set txt [ad_html_text_convert -from application/docbook+xml -to text/plain $text]

Options
    • -2
    • +159
    ./tcl/text-html-procs.tcl
5:50 pm

gustafn

fixedm typo in comment

Options
    • -1
    • +1
    ./tcl/cluster-procs.tcl
Thursday 24 Oct
6:53 pm

gustafn

rework register_icanuse "domDoc asTclValue" since w cannot use apm_version_names_compare during startup

Options
    • -1
    • +9
    ./tcl/00-icanuse-procs.tcl
5:36 pm

antoniop

Extend test suite

Options
    • -0
    • +7
    ./tcl/test/acs-tcl-test-procs.tcl
4:09 pm

gustafn

make use of new NaviServer command: ns_joinurl

the implementation provides a fallback when used with older versions of

NaviServer

Options
    • -0
    • +64
    ./tcl/00-icanuse-procs.tcl
    • -26
    • +5
    ./tcl/utilities-procs.tcl
Wednesday 23 Oct
7:34 pm

gustafn

fix comment of per_request_cache

Options
    • -3
    • +4
    ./tcl/acs-cache-procs.tcl
    • -0
    • +1
    ./tcl/test/doc-check-procs.tcl
7:08 pm

gustafn

generalized handling of nx classes and objects not defined by OpenACS

Options
    • -19
    • +26
    ./tcl/test/doc-check-procs.tcl
  2. … 1 more file in changeset.
7:07 pm

gustafn

added inline documentation for API browser

Options
    • -2
    • +13
    ./tcl/cluster-procs.tcl
7:05 pm

gustafn

improved spelling

Options
    • -3
    • +7
    ./tcl/acs-cache-procs.tcl
12:28 pm

gustafn

added inline documentation for objects for the API browser

Options
    • -4
    • +18
    ./tcl/acs-cache-init.tcl
    • -2
    • +7
    ./tcl/acs-permissions-init.tcl
12:18 pm

gustafn

added inline documentation for API browser

Options
    • -33
    • +73
    ./tcl/site-nodes-procs.tcl
11:28 am

gustafn

added inline documentation for API browser

Options
    • -6
    • +89
    ./tcl/acs-db-00-procs.tcl
Tuesday 22 Oct
6:35 pm

gustafn

exclude more content provided from outside of OpenACS

Options
    • -1
    • +12
    ./tcl/test/doc-check-procs.tcl
6:20 pm

gustafn

exclude low-level slot classes

Options
    • -0
    • +3
    ./tcl/test/doc-check-procs.tcl
6:19 pm

gustafn

improve spelling

Options
    • -1
    • +1
    ./tcl/acs-cache-procs.tcl
3:42 pm

gustafn

provide full link to entities with missing text documentation

Options
    • -3
    • +10
    ./tcl/test/doc-check-procs.tcl
3:40 pm

gustafn

extended documentation for API browser

Options
    • -43
    • +99
    ./tcl/acs-cache-procs.tcl
12:29 pm

gustafn

remove objects and classes defined in NaviServer from the listing

Options
    • -0
    • +1
    ./tcl/test/doc-check-procs.tcl
12:00 pm

gustafn

reduced reported error cases by ~1500 by omitting slot objects

Options
    • -0
    • +1
    ./tcl/test/doc-check-procs.tcl
11:37 am

gustafn

Use tdom 0.9.5 feature when available

Prefer the builtin json2dict implementation of tDOM when available

Options
    • -0
    • +1
    ./tcl/00-icanuse-procs.tcl
    • -47
    • +53
    ./tcl/json-procs.tcl
    • -1
    • +0
    ./tcl/test/json-test-procs.tcl
Monday 21 Oct
5:49 pm

gustafn

improved inline documentation

Options
    • -24
    • +40
    ./tcl/01-database-procs.tcl
    • -1
    • +4
    ./tcl/utilities-procs.tcl
Sunday 20 Oct
12:13 pm

gustafn

improved API documentation

Options
    • -6
    • +6
    ./tcl/01-database-procs.tcl
    • -13
    • +22
    ./tcl/utilities-procs.tcl
Friday 18 Oct
2:02 pm

gustafn

fixed test cases and improve documentation, added :util::block_request

Options
    • -6
    • +36
    ./tcl/utilities-procs.tcl
Wednesday 16 Oct
11:21 am

gustafn

Added code to skip suspicious looking query variables

On openacs.org, we are experiencing numerous requests with

multiply very long and strange query variables like in the example

below. So far, it is not clear, whether these requests are the

consequence of a double encoding or a deliberate attack. Many (most)

of the requests contain the query variable names containing the

(decoded) pattern "*amp;*".

This is a relatively new phenomenon. I cannot exclude that this is a

bug introduced lately in OpenACS, or a bug in an external bot, or

whatever. The problem with these query variables is that OpenACS

propagates these further, e.g., when updating query variables in

ad_dimensional, via export_vars, or return_urls.

Since OpenACS never uses these query-variables, these can be safely

skipped, without loosing functionality in OpenACS. It is possible to

construct examples, where skipping such variables can change the

semantics. Therefore, the change introduces a single function

util::suspicious_query_variable where in case of problems, the

skipping feature can be deactivated.

GET /api-doc/proc-browse?amp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3btype=All&amp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3borderby=name&type=All&amp%3btype=All&amp%3bamp%3btype=All&amp%3bamp%3bamp%3btype=All&amp%3bamp%3bamp%3bamp%3btype=All&amp%3bamp%3bamp%3bamp%3bamp%3btype=All&amp%3bamp%3bamp%3bamp%3bamp%3bamp%3btype=All&amp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3btype=All&amp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3btype=All&amp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3borderby=name&amp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3btype=Private&amp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3btype=All&amp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3btype=All&amp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3btype=All&amp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3borderby=name&amp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3bamp%3btype=All HTTP/1.1" 200 62378 "" "Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/605.1.15 (KHTML, like Gecko; compatible; FriendlyCrawler/1.0) Chrome/120.0.6099.216 Safari/605.1.15" "1729029614.331581 0.109805 0.000434 0.004026 0.215927

Options
    • -2
    • +2
    ./acs-tcl.info
    • -4
    • +56
    ./tcl/utilities-procs.tcl
  3. … 5 more files in changeset.