• last updated 1 hour ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Fix typos

  1. … 8 more files in changeset.
Fix typo in proc doc

Fix typos in proc doc

Make ad_sanitize_html not hardly dependant on a connection being there (thanks to Markus moser for the report)

Also, update documentation and make idioms less awkward.

(this passes automated tests)

Make util_current_location robust such it does not raise an exception when not connected. In these cases, the configured ad_url is returned. This is not perfect either, since it would not work with host-node mapped subsites, and maybe, there are cases, where one wants just information based on the actual connection. so, maybe, one should provide either a higher level API and/or parameterize util_current_location in the future.

improve comments

    • -3
    • +4
    ./tcl/site-node-apm-integration-procs.tcl
  1. … 3 more files in changeset.
Fix typos

  1. … 4 more files in changeset.
Trailing space cleanup

Whitespace changes

Fix typos in proc doc

Provide tests for public procs: min and max

Provide tests for public procs: util_escape_quotes_for_csv

Provide tests for public procs: util_commify_number

Refactor test case for util_absolute_path_p

Provide tests for public procs: util_complete_url_p

Fix doc typo

Provide tests for public procs: util_absolute_path_p

Provide tests for public procs: util::trim_leading_zeros

Whitespace changes

    • -165
    • +165
    ./tcl/test/acs-tcl-test-procs.tcl
Mention explicitly the tested procs in the test cases.

    • -49
    • +102
    ./tcl/test/acs-tcl-test-procs.tcl
note, that change_state_member tests checks implicitly as well membership_rel::change_state

    • -1
    • +2
    ./tcl/test/test-membership-rel-procs.tcl
Fixed bug with SuppressHttpPort on admin/index page of acs-subsite

for details see: https://openacs.org/forums/message-view?message_id=5399931

  1. … 2 more files in changeset.
set error-level to warning for documentation__check_proc_testcase (similar to datamodel__named_constraints)

don't be so quick on phasing out deprecated code

add flag "-suppress_port" to util::configured_location

fix bug with SuppressHttpPort on admin/index page of acs-subsite

see: https://openacs.org/forums/message-view?message_id=5399931

  1. … 2 more files in changeset.
Deprecate util_search_list_of_lists, as since Tcl 8.5 its behavior can be achieved natively through lsearch

Move image::get_info together with its pals procs in the content repository... just to realize it should probably go away at some point

  1. … 1 more file in changeset.
Add 'documentation__check_proc_testcase' test, for checking public procs without test cases. Many thanks to Monika Andergassen.

fix for redirect-to-secure, when SuppressHttpPort is set

This changes as well:

- improve symmetry security::get_insecure_location and security::get_secure_location

- add regression test to cover basic cases

- bumb version number of acs-tcl to 5.10.0d19

    • -0
    • +52
    ./tcl/test/location-procs.tcl