Activity OpenACS/openacs-4/packages/acs-tcl

Tree
Accordion

Stats

Commits this week: 0

Total Committers:	73
Last Commit:	01 Jul
Commits this week:	0
Total Lines of Code (LoC):	68,337
Net change in LoC this week:	0

Commit Activity

last updated 7 hours ago

Constraints

Constraints: committers

Committer:

Log Comment:

Constraints: files

File Extension:

File Name:

Constraints: dates

Start Date:

End Date:

Friday 11 Nov 2016

6:05 pm

gustafn

- make sure, that the sec_handler's global variables are always set (also in error cases, blocked bots, etc.)

- -1
- +12
./tcl/security-procs.tcl
- History
- Source
- Diff
./tcl/security-procs.tcl

6:01 pm

gustafn

- use more consistent quoting

- -12
- +13
./tcl/request-processor-procs.tcl
- History
- Source
- Diff
./tcl/request-processor-procs.tcl

Thursday 10 Nov 2016

4:23 pm

gustafn

- add warning in case site_node::get_node_id_from_object_id returns first of many urls

- -2
- +10
./tcl/site-nodes-procs.tcl
- History
- Source
- Diff
./tcl/site-nodes-procs.tcl

Tuesday 08 Nov 2016

12:29 pm

gustafn

- replace onchange handlers in widget code by event listeners

- prefer subst over double quotes to reduce quoring hell

- -7
- +12
./tcl/navigation-procs.tcl
- History
- Source
- Diff
./tcl/navigation-procs.tcl
- -6
- +16
./tcl/widgets-procs.tcl
- History
- Source
- Diff
./tcl/widgets-procs.tcl

Saturday 05 Nov 2016

6:27 pm

gustafn

- avoid deprecated function ns_unregister_proc

- -7
- +9
./tcl/request-processor-init.tcl
- History
- Source
- Diff
./tcl/request-processor-init.tcl

2:35 pm

gustafn

- make handling of URLs pointing to unresolvable package_keys more robust

- -44
- +42
./tcl/request-processor-procs.tcl
- History
- Source
- Diff
./tcl/request-processor-procs.tcl

Thursday 03 Nov 2016

1:48 pm

gustafn

- avoid potential errors in the error.log for urls which are not pointing to mounted packages (where [ad_conn package_key] is empty)

- -37
- +47
./tcl/request-processor-procs.tcl
- History
- Source
- Diff
./tcl/request-processor-procs.tcl

1:26 pm

gustafn

- remove "global" statements and use "::" prefix instead

- -9
- +8
./tcl/request-processor-procs.tcl
- History
- Source
- Diff
./tcl/request-processor-procs.tcl

1:21 pm

gustafn

- fix code that can't work. ... anyhow, package_key seems not be used here

- -2
- +2
./tcl/request-processor-procs.tcl
- History
- Source
- Diff
./tcl/request-processor-procs.tcl

Friday 28 Oct 2016

12:30 pm

hectorr

- Use get_referrer instead of ad hoc regexp to determine relative URLs.

- Fixed Regex used by "get_referrer -relative", which failed for root URLs

(i.e: http://www.openacs.org/). Thanks to Thomas Renner for the fix.

- -2
- +2
./tcl/utilities-procs.tcl
- History
- Source
- Diff
./tcl/utilities-procs.tcl
… 1 more file in changeset.

Thursday 27 Oct 2016

10:56 am

gustafn

- fix one more old bug with ad_text_to_html, where a mailto: was inserted incorrectly: part of URL was interpreted as a mail address: http://www.postgresql.org/message-id/20060329203545.M43728@narrowpathinc.com

- -3
- +5
./tcl/text-html-procs.tcl
- History
- Source
- Diff
./tcl/text-html-procs.tcl

Friday 21 Oct 2016

8:16 am

gustafn

- make sure cache is large enough to keep security tokes (needed, when signed attributes are used)

- -2
- +2
./tcl/security-init.tcl
- History
- Source
- Diff
./tcl/security-init.tcl

Tuesday 18 Oct 2016

8:24 pm

antoniop

Put again >= in place as before

- -1
- +1
./tcl/http-client-procs.tcl
- History
- Source
- Diff
./tcl/http-client-procs.tcl

8:13 pm

antoniop

Reverting previous change: I don't know since when in 4.99.12 dev versions we have dropped ns_ssl. Just stick to plain 4.99.12

- -1
- +1
./tcl/http-client-procs.tcl
- History
- Source
- Diff
./tcl/http-client-procs.tcl

8:09 pm

antoniop

Use 4.99.11 as comparison version to say: "from 4.99.12 upwards"

- -1
- +1
./tcl/http-client-procs.tcl
- History
- Source
- Diff
./tcl/http-client-procs.tcl

10:05 am

gustafn

- provide a long description for maturity_deprecated

- -1
- +9
./catalog/acs-tcl.en_US.ISO-8859-1.xml
- History
- Source
- Diff
./catalog/acs-tcl.en_US.ISO-8859-1.xml

Friday 14 Oct 2016

8:58 pm

gustafn

- use for hex codes 2-digit notation \xHH to make it compatible for tcl8.6

- -3
- +3
./tcl/utilities-procs.tcl
- History
- Source
- Diff
./tcl/utilities-procs.tcl
… 5 more files in changeset.

Thursday 13 Oct 2016

10:05 am

- change special markers in text_to_html from \x001 and \x002 to \u0002 (start of text) and \u0003 (end of text). The previous coding did not work always reliably, regsub was missing some entries, probably due to a mess-up of the internal representation.

- -12
- +14
./tcl/text-html-procs.tcl
- History
- Source
- Diff
./tcl/text-html-procs.tcl

Wednesday 12 Oct 2016

12:14 pm

gustafn

- fixing a probably old bug: changed the markers in ad_text_to_html since the old markers with the funy camel case led to problems (at least with current regexp implementations)

in the text below, only 5 of the 8 urls were correctly transformed into anchor markup. The new markers uses uniqe single char starting and ending marker, marking also regexp much simpler.

- the function is further generalized (unifying http/https/ftp urls with mailto urls) and probably faster

A welcome contribution would be e.g. an extension of the api-browser for callbacks (listing contracts/implementations, etc.).

[1] http://openacs.org/api-doc/proc-view?proc=callback&source_p=1

[2] https://github.com/openacs/openacs-core/blob/oacs-5-9/packages/search/tcl/search-procs.tcl#L309

[3] https://github.com/openacs/forums/blob/master/tcl/forums-callback-procs.tcl#L104

[4] https://github.com/openacs/openacs-core/blob/oacs-5-9/packages/acs-tcl/tcl/apm-procs.tcl

[5] http://openacs.org/api-doc/proc-view?source_p=1&proc=apm_arg_names_for_callback_type

[6] https://github.com/openacs/xowiki/blob/oacs-5-9/tcl/xowiki-callback-procs.tcl

[7] https://github.com/openacs/openacs-core/blob/oacs-5-9/packages/acs-subsite/tcl/subsite-callback-procs.tcl#L69

[8] https://github.com/openacs/xotcl-core/blob/oacs-5-9/tcl/06-param-procs.tcl#L386