• last updated 16 hours ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
don't create a cache, which is not needed

Do not improperly rely on apm_version_names_compare to check for NaviServer version number, use a more reliable capability check instead

Change the regexp so that we catch multiple kinds of error pattern indicating the subcommand does not exist: NaviServer and Tcl return sligthly different error messages

Extend test to expose that we need a better idiom to detect also NaviServer commands

Use a different idiom to detect if a command supports a subcommand, fixing acs-tcl.acs__command_has_subcommand automated test

Fix wording

New test for acs::cmd_has_subcommand exposing how flags at the beginning and end of the error message are not properly recognized

file 00-icanuse-procs.tcl was initially added on branch oacs-5-10.

    • -0
    • +0
    ./test/00-icanuse-procs.tcl
Keep supporting the previous proc signature, throwing a warning

util::http should provide enough fallback via curl already without targeting specific Naviserver versions, use other fallbacks only when no implementation is available

Fix webserver version check using 'apm_version_names_compare' for rc versions.

Between 4.99.6 and 4.99.20rc1, for example, 'apm_version_names_compare' will consider the latter to be the lowest.

As this is not the expected behavior for webserver version check, this patch just removes the rc part of the version before comparing in the few cases where this is done, and should be removed if the behavior changes in the future.

Fix version check

Tear down a lot of boilerplate used to support native HTTP api on Naviserver versions < 4.99.15, which will now fallback to curl

Doc formatting changes

Avoid markup in documentation

Reduce people expectations

Fix acs-tcl.logout_from_everywhere test case and support again invalidating of all existing user logins, useful e.g. to make sure no device still holds a valid login when we change our password on a device

Test the use case supposedly supported by sec_change_user_auth_token: invalidate all existing login cookies (e.g. when the users change their password) so that all devices need to log in again

the test exposes a long standing regression (~17 years) where this was broken in order to support persistent login. See e.g. https://openacs.org/forums/message-view?message_id=1691183#msg_1691183

file security-procs.tcl was initially added on branch oacs-5-10.

    • -0
    • +0
    ./test/security-procs.tcl
improve spelling (follow LDP)

  1. … 12 more files in changeset.
the Linux Documentation Project recommends to write "lowercase" as a single word

perform a more sane test to check, whether the util_memoize cache was created already

fix for issue #3448

Don't rely on configured "location" value of driver, since this does not work for virtual hosting

Instead, get the "host", "port" and "defaultport" directly from "ns_driver info" when available

"ns_driver info" has no key "host", but "address" (which might be multiple addresses)

Exclude deprecated procs from the test

Include tests with string containing an extension, put also a ß in the mix

Basic test for ad_sanitize_filename

file utilities-procs.tcl was initially added on branch oacs-5-10.

    • -0
    • +0
    ./test/utilities-procs.tcl
Bring existing doc in the api-doc, so that documentation__check_proc_doc test case does not complain