OpenACS / openacs-4 / packages / acs-tcl

tcl

Tools

Line History

Line Count Graph
Line Count Graph

Stats

Commits this week: 0
Total Committers: 71
Last Commit: 08 May
Commits this week: 0
Total Lines of Code (LoC): 65,995
Net change in LoC this week: 0

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated 19 hours ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Wednesday 13 Jan 2021
10:44 am

antoniop

Avoid markup in documentation

Options
    • -72
    • +69
    ./http-client-procs.tcl
10:37 am

antoniop

Reduce people expectations

Options
    • -1
    • +2
    ./http-client-procs.tcl
Tuesday 12 Jan 2021
6:36 pm

antoniop

Fix acs-tcl.logout_from_everywhere test case and support again invalidating of all existing user logins, useful e.g. to make sure no device still holds a valid login when we change our password on a device

Options
    • -15
    • +24
    ./security-procs.tcl
6:32 pm

antoniop

Test the use case supposedly supported by sec_change_user_auth_token: invalidate all existing login cookies (e.g. when the users change their password) so that all devices need to log in again

the test exposes a long standing regression (~17 years) where this was broken in order to support persistent login. See e.g. https://openacs.org/forums/message-view?message_id=1691183#msg_1691183

Options
    • -0
    • +64
    ./test/security-procs.tcl
6:32 pm

antoniop

file security-procs.tcl was initially added on branch oacs-5-10.

Options
    • -0
    • +0
    ./test/security-procs.tcl
Tuesday 05 Jan 2021
6:10 pm

gustafn

improve spelling (follow LDP)

Options
    • -2
    • +2
    ./memoize-procs-naviserver.tcl
    • -3
    • +3
    ./parameter-procs.tcl
    • -2
    • +2
    ./request-processor-procs.tcl
    • -2
    • +2
    ./xml-1-dom-procs.tcl
  5. … 12 more files in changeset.
Saturday 26 Dec 2020
5:40 pm

gustafn

the Linux Documentation Project recommends to write "lowercase" as a single word

Options
    • -2
    • +2
    ./test/utilities-procs.tcl
5:39 pm

gustafn

perform a more sane test to check, whether the util_memoize cache was created already

Options
    • -6
    • +10
    ./memoize-procs-naviserver.tcl
5:17 pm

gustafn

fix for issue #3448

Options
    • -2
    • +2
    ./memoize-procs-naviserver.tcl
    • -5
    • +26
    ./test/memoizing-procs.tcl
4:32 pm

gustafn

Don't rely on configured "location" value of driver, since this does not work for virtual hosting

Instead, get the "host", "port" and "defaultport" directly from "ns_driver info" when available

Options
    • -9
    • +35
    ./security-procs.tcl
1:05 pm

gustafn

"ns_driver info" has no key "host", but "address" (which might be multiple addresses)

Options
    • -2
    • +2
    ./security-procs.tcl
Wednesday 16 Dec 2020
6:14 pm

antoniop

Exclude deprecated procs from the test

Options
    • -2
    • +4
    ./test/doc-check-procs.tcl
Thursday 10 Dec 2020
3:00 pm

antoniop

Include tests with string containing an extension, put also a ß in the mix

Options
    • -8
    • +43
    ./test/utilities-procs.tcl
Wednesday 09 Dec 2020
4:07 pm

antoniop

Basic test for ad_sanitize_filename

Options
    • -0
    • +56
    ./test/utilities-procs.tcl
4:07 pm

antoniop

file utilities-procs.tcl was initially added on branch oacs-5-10.

Options
    • -0
    • +0
    ./test/utilities-procs.tcl
3:36 pm

antoniop

Bring existing doc in the api-doc, so that documentation__check_proc_doc test case does not complain

Options
    • -14
    • +16
    ./00-icanuse-procs.tcl
3:28 pm

antoniop

Add semicolon ";" to the list of forbidden characters to be stripped when a filename is sanitized

It is not allowed to create a filename with a semicolon on Windows, but it is e.g. on MacOS and Linux, creating a possible interoperability issue

Options
    • -4
    • +4
    ./utilities-procs.tcl
Tuesday 08 Dec 2020
8:38 pm

gustafn

added backward compatibility proc for AOLserver "ns_trim"

Options
    • -1
    • +30
    ./00-icanuse-procs.tcl
  2. … 1 more file in changeset.
3:33 pm

gustafn

whitespace changes: break overlong lines

Options
    • -4
    • +11
    ./01-database-procs.tcl
3:31 pm

gustafn

don't throw error message on transaction rollbacks (these are no errors, but use the same exception handling)

Options
    • -3
    • +9
    ./01-database-procs.tcl
Sunday 06 Dec 2020
9:45 am

gustafn

modernize Tcl code: replace array by dict

Options
    • -19
    • +20
    ./html-procs.tcl
9:43 am

gustafn

improved wording in comment

Options
    • -10
    • +15
    ./acs-cache-procs.tcl
9:42 am

gustafn

added commit for extending usage of OpenACS filters for other HTTP methods (e.g. in the REST context)

Options
    • -2
    • +11
    ./request-processor-init.tcl
Tuesday 01 Dec 2020
10:27 am

gustafn

fix typo

Options
    • -2
    • +2
    ./apm-procs.tcl
10:26 am

gustafn

reduce verbosity

Options
    • -2
    • +2
    ./site-nodes-procs.tcl
Friday 27 Nov 2020
10:52 am

gustafn

added example line to ease spotting of the creation of unnamed mutexes

Options
    • -0
    • +1
    ./tcltrace-init.tcl
10:27 am

gustafn

provide name for mutexes to ease spotting potential locks

Options
    • -4
    • +3
    ./tcl-documentation-procs.tcl
    • -2
    • +2
    ./utilities-procs.tcl
Tuesday 24 Nov 2020
8:02 pm

gustafn

avoid burst cache hits by using nsvs instead of ns_cache for secret token caching

The problem with the prevision version was that ns_cache has no equivalent

to nsv_array to get in an atomic fashion all key value pairs from the cache.

thefore, for the per-thread caching, a tight loop was used processing

the result of ns_cache_keys. If this was necessary in a high number of

threads, higher lock times were possible (~100ms). The new version

should not face this problem.

Options
    • -26
    • +66
    ./security-procs.tcl
Monday 23 Nov 2020
3:11 pm

antoniop

Important, although very simple reform in the page-contract filters: do not kill the case in the filter specs, or filters such as "w:oneof(One|Two)" or "locale:oneof(en_US|de_DE)" would not have a chance to match

Note that this makes the contracts stricter with respect to case, which might break obscure use cases...

Options
    • -2
    • +4
    ./tcl-documentation-procs.tcl
Saturday 21 Nov 2020
5:45 pm

gustafn

avoid to try to return an error to client in request processor when connection was already closed

Options
    • -1
    • +6
    ./request-processor-procs.tcl