• last updated 5 hours ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Replace catch idiom, improve proc contract, make it clear that we return a list

Bring sql inline, reduce duplication

Simplify idiom, bring sql inline

add support for expiryDays

update upstream version number

for expiry days to work correctly, one needs probably the following fix

https://github.com/insites/cookieconsent/pull/534

Trailing whitespace cleanup

    • -42
    • +42
    ./packages/acs-templating/tcl/data-procs.tcl
Take advantage of oldie utility template::util::list_to_multirow to refactor and simplify the code

    • -21
    • +16
    ./packages/categories/www/cadmin/index.tcl
Fix typo

    • -2
    • +2
    ./packages/categories/www/cadmin/index.tcl
Fix missing variable

    • -2
    • +2
    ./packages/categories/www/cadmin/index.tcl
Move away portraits created as children of the -100 object that might be still around after acs-kernel/sql/postgresql/upgrade/upgrade-5.10.0d13-5.10.0d14.sql

file upgrade-5.10.0d17-5.10.0d18.sql was initially added on branch oacs-5-10.

Remove duplicate column

it seems, that "-ulevel" is used more often than "-level"

    • -3
    • +3
    ./packages/acs-tcl/tcl/utilities-procs.tcl
use "-level" instead of "-ulevel", since "-level" is used e.g. in

template::util::multirow_to_list or template::util::list_of_ns_sets_to_multirow

as well.

    • -5
    • +6
    ./packages/acs-tcl/tcl/utilities-procs.tcl
Added switch "-ulevel" to proc "util::var_subst_quotehtml";

ad_form: quote form field values in validation error messages to prevent XSS attacks

    • -3
    • +8
    ./packages/acs-tcl/tcl/utilities-procs.tcl
Quote form field values in validation error messages to prevent XSS attacks

    • -13
    • +13
    ./packages/acs-templating/tcl/data-procs.tcl
Prettify code

Mode is in fact the value of the nsv

Force the encoding on the channel to utf-8 in every case (fixes umlaut characters when using ns_connchan backend)

fix issue #3392, improve testability via paramterization of clock value, add regression test, improve Tcl sanity

    • -160
    • +180
    ./packages/acs-templating/tcl/date-procs.tcl
white space changes

Deprecate unamusing template::util::date::now_min_interval_plus_hour

    • -2
    • +8
    ./packages/acs-templating/tcl/date-procs.tcl
Fix obvious bug; Note that the proc is still buggy, as it blindly incr's the hour value, even if it is 23 o'clock

    • -2
    • +2
    ./packages/acs-templating/tcl/date-procs.tcl
Fix log warning message

    • -3
    • +3
    ./packages/acs-templating/tcl/tag-procs.tcl
Delete unneeded line

    • -2
    • +1
    ./packages/acs-tcl/tcl/security-procs.tcl
Use testing authority in auth_create_user test

improve protection against attacked cookies

    • -3
    • +3
    ./packages/acs-tcl/tcl/security-procs.tcl
Do not depend on dt_systime

Apparently, this makes xolp tests more robust with respect to issue discussed in https://stackoverflow.com/questions/49031790/how-can-i-debug-a-tcl-8-6-error-in-clock-tcl#49033144

    • -1
    • +1
    ./packages/xolp/tcl/xolp-indicator-procs.tcl
Add a quick run of the basic CRUD operations on ORM to avoid issues when e.g. no particular object member is explicitly supplied

    • -0
    • +23
    ./packages/xotcl-core/tcl/test/xotcl-test-procs.tcl
Check for existance of :context_id

    • -2
    • +3
    ./packages/xotcl-core/tcl/cr-procs.tcl
Make sure init test classes are named differently, or xowiki tests will interfere with xowf ones

    • -3
    • +3
    ./packages/xowf/tcl/test/xowf-test-procs.tcl