• last updated 2 hours ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
cache group::group_p in partitioned cache as well

    • -18
    • +10
    ./packages/acs-subsite/tcl/group-procs.tcl
note, that change_state_member tests checks implicitly as well membership_rel::change_state

cache base function "group::get", base "group::title" on "group::get"

    • -21
    • +32
    ./packages/acs-subsite/tcl/group-procs.tcl
changes for group::get:

make array optional

return dict of values which can be more easily passed around

remove unneeded code (flushing of get_title from memoize cache, but function does not exist

remove redundant SQL code in group::delete

rCVS: ----------------------------------------------------------------------

    • -27
    • +9
    ./packages/acs-subsite/tcl/group-procs.tcl
Fixed bug with SuppressHttpPort on admin/index page of acs-subsite

for details see: https://openacs.org/forums/message-view?message_id=5399931

    • -3
    • +3
    ./packages/acs-subsite/acs-subsite.info
    • -3
    • +15
    ./packages/acs-subsite/www/admin/index.tcl
move caching of group memberships from util_memoize cache into separate, partitioned cache (group_cache)

to reduce stress on util_memoize and improve scalability

    • -0
    • +13
    ./packages/acs-subsite/tcl/group-init.tcl
    • -10
    • +21
    ./packages/acs-subsite/tcl/group-procs.tcl
set error-level to warning for documentation__check_proc_testcase (similar to datamodel__named_constraints)

remove obsolte comments

probably it was meant that packages can be passed in via "package_ids" parameter

whitespace cleanup

align callback implementation with definition

fix documentation of parameter

    • -2
    • +2
    ./packages/categories/tcl/categories-procs.tcl
update documentation

add flag no_automatic_membership_rel to group::add_member to make it potentially usable from DotLRN

    • -2
    • +11
    ./packages/acs-subsite/tcl/group-procs.tcl
fix typo

whitespace cleanup

replace deprecated proc util_search_list_of_lists

don't be so quick on phasing out deprecated code

    • -23
    • +2
    ./packages/acs-tcl/tcl/deprecated-procs.tcl
    • -1
    • +21
    ./packages/acs-tcl/tcl/utilities-procs.tcl
add flag "-suppress_port" to util::configured_location

    • -3
    • +3
    ./packages/acs-tcl/tcl/utilities-procs.tcl
Whitespace changes

    • -483
    • +483
    ./packages/acs-templating/tcl/form-procs.tcl
Fix duplicate wording

    • -2
    • +2
    ./packages/acs-templating/tcl/form-procs.tcl
Whitespace cleanup

Fix doc typos

prefer acs_object__new/9 over acs_object__new/7

fix bug with SuppressHttpPort on admin/index page of acs-subsite

see: https://openacs.org/forums/message-view?message_id=5399931

    • -3
    • +3
    ./packages/acs-subsite/acs-subsite.info
    • -3
    • +16
    ./packages/acs-subsite/www/admin/index.tcl
    • -3
    • +3
    ./packages/acs-tcl/tcl/utilities-procs.tcl
Remove smelly comment, as parameter is there

Deprecate util_search_list_of_lists, as since Tcl 8.5 its behavior can be achieved natively through lsearch

    • -2
    • +23
    ./packages/acs-tcl/tcl/deprecated-procs.tcl
    • -16
    • +1
    ./packages/acs-tcl/tcl/utilities-procs.tcl
Modernize tcl

Whitespace removal

Move image::get_info together with its pals procs in the content repository... just to realize it should probably go away at some point

    • -42
    • +0
    ./packages/acs-tcl/tcl/image-procs.tcl