• last updated 56 mins ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Modify user interface to allow/disallow attachments per forum, on forum creation and editing. Added message keys and bumped version as well.

Cleanup trailing whitespace

Extend 'forum::attachments_enabled_p' with 'forum_id', so attachments ca be enabled per forum (see previous commit), and update underliying logic to make use of it.

Fix oracle upgrade, remembering to keep privilege creation, which should indeed happen in the upgrade

Skip column and attribute creation in this upgrade: people will get it from xotcl ORM in version 6.* and this upgrade would conflict

Use Duden-conformant Formulation

there are many other terms, which would have do be changed

for general gender neutrility, unless we continue to stick with the

generic masculine.

https://de.wikipedia.org/wiki/Generisches_Maskulinum

https://de.wikipedia.org/wiki/Geschlechtergerechte_Sprache

    • -6
    • +6
    ./acs-kernel/catalog/acs-kernel.de_DE.ISO-8859-1.xml
provide a default for pass_through option

    • -2
    • +2
    ./acs-admin/www/users/member-state-change.tcl
Add column 'attachments_allowed_p' to 'forums_forums', to be used to allow/disallow attachments on a per forum basis. Currently, the attachment logic is package instance wise, so if the forums instance has an attachment instance mounted below, then attachments are assumed to be enabled for all forums in that package instance. The idea with this change is to check for both the attachments instance mounted under a particular forum instance, and the 'attachments_allowed_p' column on 'forums_forums', to decide if attachments are enabled or not (both should be true). Next step would be to rewrite the logic to achieve that.

file upgrade-1.3.1d12-1.3.1d13.sql was initially added on branch oacs-5-10.

    • -0
    • +0
    ./forums/sql/oracle/upgrade/upgrade-1.3.1d12-1.3.1d13.sql
Trailing whitespace cleanup

    • -1
    • +1
    ./richtext-ckeditor4/tcl/ckfinder-init.tcl
    • -2
    • +2
    ./richtext-ckeditor4/tcl/ckfinder-procs.tcl
Use 'ckfinder::file_attach' instead of 'ckfinder::image_attach', which is not implemented.

    • -4
    • +4
    ./richtext-ckeditor4/tcl/ckfinder-init.tcl
Make doc and logging consistent with implementation (image_attach -> file_attach)

    • -3
    • +3
    ./richtext-ckeditor4/tcl/ckfinder-procs.tcl
Fix translation

    • -2
    • +2
    ./acs-kernel/catalog/acs-kernel.de_DE.ISO-8859-1.xml
Keep accepting empty values as proper ids, as deprecated ad_var_type_check_integer_p would have done

Specify an explicit format that clock scan can recognize, otherwise results will be unexpected (port from downstream)

Use provided email only when a party exists, in all other cases keep the previous behavior (fixes automated tests)

    • -5
    • +3
    ./acs-automated-testing/tcl/aa-test-procs.tcl
Fix regression on enabling/disabling locales

Use a german gender-neutral wording for "members"

    • -1
    • +1
    ./acs-kernel/catalog/acs-kernel.de_DE.ISO-8859-1.xml
make object adressing more consistent

fix typo

improve spelling

    • -1
    • +1
    ./file-storage/catalog/file-storage.en_US.ISO-8859-1.xml
replace hardcoded /tmp by API function [ad_tmpdir]

    • -2
    • +2
    ./acs-api-browser/tcl/acs-api-documentation-procs.tcl
    • -2
    • +2
    ./acs-content-repository/tcl/image-procs.tcl
    • -2
    • +2
    ./acs-subsite/tcl/email-image-procs.tcl
    • -2
    • +2
    ./acs-templating/tcl/spellcheck-procs.tcl
    • -2
    • +2
    ./acs-tcl/tcl/test/openacs-kernel-procs.tcl
    • -1
    • +1
    ./file-storage/tcl/test/tclwebtest-procs.tcl
    • -3
    • +3
    ./xotcl-core/tcl/http-client-procs.tcl
template::reset_request_vars must be executed for all requests in the cleanup

this is already happening via "ns_ictl trace freeconn", but we keep

for the time being this as a reminder, when merging with different versions, etc.

    • -2
    • +8
    ./acs-templating/tcl/acs-integration-procs.tcl
don't hardcode /tmp/

simplify file delivery modes

don't start accidentially thread via monitoring

    • -2
    • +2
    ./xotcl-request-monitor/www/running.tcl
improve spelling

    • -1
    • +1
    ./acs-lang/tcl/test/acs-lang-test-procs.tcl
replace deprecated function ad_var_type_check_number_p which was used improperly

    • -9
    • +18
    ./acs-lang/www/admin/set-system-timezone.tcl
replace deprecated functions ad_var_type_check_integerlist_p and ad_var_type_check_number_p

    • -3
    • +5
    ./acs-mail-lite/tcl/email-inbound-procs.tcl
    • -2
    • +2
    ./acs-mail-lite/tcl/legacy-inbound-procs.tcl
replace deprecated ad_var_type_check_number_p by "string is double -strict "