• last updated 14 hours ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Localize file-size limits in the UI

Introduce a client-side check for the maximum file size, inform user of current limit and improve file-size related localization

Prettify code

Make 'util_user_message' quote the message when the parameter 'html_p' is false, not otherwise, restoring pre-refactoring behavior and making it coherent with the parameter doc

Remove obsolete xql files

    • -31
    • +0
    ./file-storage/www/version-delete-oracle.xql
    • -26
    • +0
    ./file-storage/www/version-delete-postgresql.xql
    • -25
    • +0
    ./file-storage/www/version-delete.xql
improve log messages

    • -5
    • +5
    ./acs-api-browser/tcl/acs-api-documentation-procs.tcl
Simplify code and exploit parameter contract (we know flags are boolean)

    • -17
    • +10
    ./acs-tcl/tcl/utilities-procs.tcl
Bugfixes et al:

- don't throw a server error if one clicks submit on the empty form without specifying a file

- allow to upload the same zipfile multiple times without throwing an error

- streamline idioms

Whitespace changes

    • -69
    • +68
    ./acs-service-contract/tcl/acs-service-contract-procs.tcl
Add @see and fix typo in proc doc

    • -2
    • +4
    ./acs-service-contract/tcl/acs-service-contract-procs.tcl
Fix typo in proc doc

Repeat this block of code here as well, as vars in the checks are not kept in the script body

Fix typos in proc doc

    • -2
    • +2
    ./acs-templating/tcl/richtext-or-file-procs.tcl
    • -1
    • +1
    ./acs-templating/tcl/richtext-procs.tcl
Fix typo in proc doc

    • -2
    • +2
    ./acs-templating/tcl/richtext-or-file-procs.tcl
Chat Redesign: add float clear after user block in user list (also in 'classic' skin)

Chat Redesign: add float clear after user block in user list

don't load deleted messages into the cache and drop conceptually broken parameter

    • -10
    • +7
    ./acs-lang/tcl/lang-message-procs.tcl
Put some sanity in ancient proc docs with 'pre' tags that were breaking api-doc

    • -65
    • +23
    ./acs-tcl/tcl/utilities-procs.tcl
Chat Redesign:

+ Add specific container for the chat includelet (xowiki-chat-includelet).

+ Set a sensible default for the 'xowiki-chat-includelet' size.

+ Move the 'my-user-id' hidden element in the chat adp to the chat procs.

+ Rename 'my-user-id' element to 'xowiki-my-user-id'.

+ Get the ChatSkin parameter inside the login proc.

+ Include the skin parameter in the chat includelet.

Make parameter comment coherent with the real default value

Chat Redesign: bump version number after parameter cleanup.

Chat Redesign: cleanup of obsolete parameters ('AppletHeight','AppletWidth','DefaultClient','ServerHost','ServerPort').

    • -4
    • +1
    ./chat-includelet/lib/chat-includelet.adp
    • -1
    • +0
    ./chat-includelet/lib/chat-includelet.tcl
Chat Redesign:

+ Skin support.

+ New 'ChatSkin' instance parameter, with currently two possible values: 'classic' and 'bubbles'.

+ Skins are located in the new packages/xowiki/www/resources/chat-skins/ directory.

+ New 'bubbles' skin, default for the chat package.

+ Old skin renamed to 'classic', default for the xowiki includelet.

+ New skins can be created by just adding the css and js files in the skins directory, and naming them accordingly. For example, being '$skin' the name of the new skin, the files should be named chat-$skin-common.js and chat-$skin.css.

+ New '-skin' parameter to the Chat login proc, containing the name of the skin (i.e. 'classic' or 'bubbles').

+ Bump version number.

    • -211
    • +0
    ./xowiki/www/resources/chat-common.js
    • -0
    • +270
    ./xowiki/www/resources/chat-skins/chat-bubbles-common.js
    • -0
    • +371
    ./xowiki/www/resources/chat-skins/chat-bubbles.css
    • -0
    • +211
    ./xowiki/www/resources/chat-skins/chat-classic-common.js
    • -0
    • +251
    ./xowiki/www/resources/chat-skins/chat-classic.css
File storage max upload limit reform:

the max upload limit will now default to empty. Rationale: this value is

one that ages quickly with respect to new storage requirements, and is

currently set to something incompatible with the vanilla Naviserver configuration

(500MB fs vs 20MB ns).

The upgrade script will make so that instances setting this parameter

higher than the server upload limit configuration will be

set empty as well (this would never have an effect, as server

will prevent the upload altogheter anyway).

Max upload limit in bytes is now retrieved from a proc implementing

this fallback to server configuration logics. Other than centralizing,

its purpose is to be used in client-side code checks in the future

so we could prevent a doomed upload in advance.

    • -2
    • +28
    ./file-storage/tcl/file-storage-install-procs.tcl
    • -1
    • +27
    ./file-storage/tcl/file-storage-procs.tcl
    • -2
    • +2
    ./file-storage/www/admin/upload-size-limit.tcl
Refer to the parameter in the file-storage instance instead than on a local one to decide the maximum upload size and deprecate the one here

Rationale: makes little sense that we set and maintain separate limits referring to the same file-storage instance

Remove trivial default, already set by the api

Whitespace removal

Remove obsolete queries and bring remaining one inline

    • -94
    • +0
    ./attachments/www/file-add-2-oracle.xql
    • -87
    • +0
    ./attachments/www/file-add-2-postgresql.xql
Speed up referential integrity by avoiding sequential scans

Whitespace changes

    • -27
    • +27
    ./acs-tcl/tcl/acs-kernel-procs.tcl