OpenACS / openacs-4

packages

Tools

Line History

Line Count Graph
Line Count Graph

Stats

Commits this week: 34
Total Committers: 137
Last Commit:
Commits this week: 34
Total Lines of Code (LoC): 5,097,039
Net change in LoC this week: 26

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated 4 hours ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Friday 09 Apr
7:48 pm

antoniop

Recover logic went missing after refactoring (with some remarks)

Options
    • -2
    • +33
    ./file-storage/tcl/file-storage-procs.tcl
7:17 pm

antoniop

Comment deprecated proc, which was before defined as private, because of a false positive in acs-api-browser.callgraph__bad_library_calls: the "Authenticate" operation in the spec of auth::authentication::create_contract is mistakenly interpreted as the deprecated proc

Options
    • -16
    • +16
    ./acs-authentication/tcl/authentication-procs.tcl
4:01 pm

antoniop

Make proc public, as was intended

Options
    • -2
    • +2
    ./acs-authentication/tcl/authentication-procs.tcl
9:02 am

gustafn

passing "-debug" flag explicitly to nsf::proc

Options
    • -3
    • +8
    ./acs-bootstrap-installer/tcl/00-proc-procs.tcl
8:59 am

gustafn

whitespace changes

Options
    • -9
    • +8
    ./acs-tcl/tcl/site-node-apm-integration-procs.tcl
    • -2
    • +3
    ./acs-content-repository/tcl/content-item-procs.tcl
    • -19
    • +1
    ./acs-content-repository/tcl/content-revision-procs.tcl
Thursday 08 Apr
10:25 pm

gustafn

fix last commit (many thanks to Thomas Renner)

Options
    • -2
    • +3
    ./xowf/lib/inclass-exam-answer.wf
10:15 pm

gustafn

made includelet "categories" folder aware (on can pass "parent" in form of a page-ref to the includelet)

refactored some of the code to increase reusability

Options
    • -30
    • +1
    ./xowiki/tcl/folder-procs.tcl
    • -9
    • +62
    ./xowiki/tcl/includelet-procs.tcl
10:11 pm

gustafn

make treeview more compact

Options
    • -4
    • +3
    ./xowiki/tcl/tree-procs.tcl
    • -0
    • +7
    ./xowiki/www/resources/xowiki-bootstrap3-specific.css
6:18 pm

antoniop

Deprecated trivial private ad_user_login wrapper, which is already a public api

Options
    • -7
    • +11
    ./acs-authentication/tcl/authentication-procs.tcl
    • -2
    • +2
    ./acs-authentication/tcl/password-procs.tcl
5:52 pm

antoniop

Promote logics in auth::authentication::Authenticate to a public api, which unfortunately cannot be the same due to the inconsistent naming, hence we have to create a new alias

Rationale:

- the proc provides some value to the user by choosing the right contract implementation depending on the authority

- we found occurrences in other packages downstream, and as internally this proc is calling only public api, one could just duplicate the whole thing and be compliant with our standards, which is not an improvement IMO

- the proc was already tested and documented

Options
    • -3
    • +20
    ./acs-authentication/tcl/authentication-procs.tcl
    • -4
    • +4
    ./acs-authentication/tcl/test/acs-authentication-procs.tcl
    • -2
    • +5
    ./acs-core-docs/www/xml/kernel/ext-auth-design.xml
5:44 pm

antoniop

Update doc following the acs_named_objects phasing out, this escaped the commit back in the days

Options
    • -14
    • +3
    ./acs-core-docs/www/tutorial-categories.adp
    • -14
    • +3
    ./acs-core-docs/www/tutorial-categories.html
    • -16
    • +4
    ./acs-core-docs/www/xml/developers-guide/tutorial-advanced.xml
2:27 pm

hectorr

Remove leftover

Options
    • -1
    • +0
    ./acs-automated-testing/www/admin/index.adp
1:26 pm

antoniop

Refactoring, as proctoring files are not only pictures, make api public, write automated test

Options
    • -2
    • +2
    ./proctoring-support/lib/proctoring-upload.tcl
    • -2
    • +2
    ./proctoring-support/tcl/proctoring-procs.tcl
    • -0
    • +57
    ./proctoring-support/tcl/test/proctoring-test-procs.tcl
Wednesday 07 Apr
10:07 pm

gustafn

break overlong lines

Options
    • -18
    • +53
    ./file-storage/tcl/file-storage-procs.tcl
9:54 pm

gustafn

stick to content-repository API instead of duplicating code here.

Options
    • -9
    • +0
    ./file-storage/tcl/file-storage-procs-oracle.xql
    • -66
    • +0
    ./file-storage/tcl/file-storage-procs-postgresql.xql
    • -55
    • +24
    ./file-storage/tcl/file-storage-procs.tcl
    • -21
    • +0
    ./file-storage/tcl/file-storage-procs.xql
1:45 pm

antoniop

Use better timing idiom

Options
    • -1
    • +1
    ./proctoring-support/tcl/proctoring-support-init.tcl
10:41 am

hectorr

Fixed var name and add warning for 'cr_file_name' being empty (the latter ported from downstream, originally made by Günter Ernst)

Options
    • -13
    • +22
    ./acs-content-repository/tcl/content-revision-procs.tcl
Tuesday 06 Apr
9:16 pm

gustafn

new function: ::content::revision::export_to_filesystem

This change moves functionality from file-storage to acs-content-repository.

all application packages should be free of internals, such as the storage

type. Storage_type should be handeled in the content-repository package.

We are not yet done, there is still more to do in this respect in

the file-storage package.

Options
    • -5
    • +8
    ./acs-content-repository/acs-content-repository.info
    • -3
    • +10
    ./acs-content-repository/tcl/content-revision-procs-oracle.xql
    • -1
    • +9
    ./acs-content-repository/tcl/content-revision-procs-postgresql.xql
    • -1
    • +70
    ./acs-content-repository/tcl/content-revision-procs.tcl
    • -3
    • +3
    ./file-storage/file-storage.info
    • -16
    • +0
    ./file-storage/tcl/file-storage-procs-oracle.xql
    • -16
    • +0
    ./file-storage/tcl/file-storage-procs-postgresql.xql
    • -43
    • +8
    ./file-storage/tcl/file-storage-procs.tcl
8:25 pm

gustafn

break overlong lines

Options
    • -5
    • +18
    ./file-storage/tcl/file-storage-procs.tcl
7:56 pm

gustafn

improve comments

Options
    • -12
    • +17
    ./xotcl-core/tcl/cr-procs.tcl
7:42 pm

gustafn

make actions changed from the background state-safe

Options
    • -3
    • +3
    ./xowf/lib/inclass-exam.wf
4:10 pm

antoniop

Implement a checksum + cache mechanism to check whether user is sending the same file multiple times:

this is needed to address the problem of timeouts, where the server might process a request even when the client has given up and rescheduled the upload. We now store the latest checksum that has been received and compare it with the new picture.

Options
    • -0
    • +16
    ./proctoring-support/lib/proctoring-upload.tcl
    • -0
    • +33
    ./proctoring-support/tcl/proctoring-procs.tcl
    • -0
    • +19
    ./proctoring-support/tcl/proctoring-support-init.tcl
4:10 pm

antoniop

file proctoring-support-init.tcl was initially added on branch oacs-5-10.

Options
    • -0
    • +0
    ./proctoring-support/tcl/proctoring-support-init.tcl
3:35 pm

hectorr

Whitespace changes + Editor hints

Options
    • -26
    • +32
    ./news-aggregator/www/opml-import-2.tcl
3:33 pm

hectorr

Replace deprecated API

Options
    • -4
    • +4
    ./news-aggregator/www/opml-import-2.tcl
3:20 pm

hectorr

Update spanish message keys

Options
    • -5
    • +5
    ./xowf/xowf.info
    • -0
    • +7
    ./xowf/catalog/xowf.es_ES.ISO-8859-1.xml
3:07 pm

hectorr

Update spanish message keys

Options
    • -2
    • +2
    ./news-aggregator/news-aggregator.info
    • -0
    • +16
    ./news-aggregator/catalog/news-aggregator.es_ES.ISO-8859-1.xml
    • -0
    • +4
    ./xolp/catalog/xolp.es_ES.ISO-8859-1.xml
1:31 pm

antoniop

Improve fix: do not even fetch the context_id for revisions, so we do not touch it when saving

Options
    • -8
    • +8
    ./xotcl-core/tcl/cr-procs.tcl
11:31 am

antoniop

Make sure that the context_id of a CRItem is always fetched from that of the item, rather than the revision, otherwise we could break object_id = context_id constraint on saving

Options
    • -1
    • +11
    ./xotcl-core/tcl/cr-procs.tcl
Monday 05 Apr
11:24 pm

gustafn

write mutual overwrites to the system log

Options
    • -2
    • +2
    ./xowiki/tcl/xowiki-www-procs.tcl