• last updated 4 hours ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Recover logic went missing after refactoring (with some remarks)

    • -2
    • +33
    ./file-storage/tcl/file-storage-procs.tcl
Comment deprecated proc, which was before defined as private, because of a false positive in acs-api-browser.callgraph__bad_library_calls: the "Authenticate" operation in the spec of auth::authentication::create_contract is mistakenly interpreted as the deprecated proc

    • -16
    • +16
    ./acs-authentication/tcl/authentication-procs.tcl
Make proc public, as was intended

    • -2
    • +2
    ./acs-authentication/tcl/authentication-procs.tcl
passing "-debug" flag explicitly to nsf::proc

    • -3
    • +8
    ./acs-bootstrap-installer/tcl/00-proc-procs.tcl
whitespace changes

    • -9
    • +8
    ./acs-tcl/tcl/site-node-apm-integration-procs.tcl
    • -2
    • +3
    ./acs-content-repository/tcl/content-item-procs.tcl
    • -19
    • +1
    ./acs-content-repository/tcl/content-revision-procs.tcl
fix last commit (many thanks to Thomas Renner)

made includelet "categories" folder aware (on can pass "parent" in form of a page-ref to the includelet)

refactored some of the code to increase reusability

make treeview more compact

Deprecated trivial private ad_user_login wrapper, which is already a public api

    • -7
    • +11
    ./acs-authentication/tcl/authentication-procs.tcl
    • -2
    • +2
    ./acs-authentication/tcl/password-procs.tcl
Promote logics in auth::authentication::Authenticate to a public api, which unfortunately cannot be the same due to the inconsistent naming, hence we have to create a new alias

Rationale:

- the proc provides some value to the user by choosing the right contract implementation depending on the authority

- we found occurrences in other packages downstream, and as internally this proc is calling only public api, one could just duplicate the whole thing and be compliant with our standards, which is not an improvement IMO

- the proc was already tested and documented

    • -3
    • +20
    ./acs-authentication/tcl/authentication-procs.tcl
    • -4
    • +4
    ./acs-authentication/tcl/test/acs-authentication-procs.tcl
Update doc following the acs_named_objects phasing out, this escaped the commit back in the days

    • -14
    • +3
    ./acs-core-docs/www/tutorial-categories.adp
    • -14
    • +3
    ./acs-core-docs/www/tutorial-categories.html
Remove leftover

Refactoring, as proctoring files are not only pictures, make api public, write automated test

    • -2
    • +2
    ./proctoring-support/lib/proctoring-upload.tcl
    • -2
    • +2
    ./proctoring-support/tcl/proctoring-procs.tcl
    • -0
    • +57
    ./proctoring-support/tcl/test/proctoring-test-procs.tcl
break overlong lines

    • -18
    • +53
    ./file-storage/tcl/file-storage-procs.tcl
stick to content-repository API instead of duplicating code here.

    • -9
    • +0
    ./file-storage/tcl/file-storage-procs-oracle.xql
    • -66
    • +0
    ./file-storage/tcl/file-storage-procs-postgresql.xql
    • -55
    • +24
    ./file-storage/tcl/file-storage-procs.tcl
    • -21
    • +0
    ./file-storage/tcl/file-storage-procs.xql
Use better timing idiom

    • -1
    • +1
    ./proctoring-support/tcl/proctoring-support-init.tcl
Fixed var name and add warning for 'cr_file_name' being empty (the latter ported from downstream, originally made by Günter Ernst)

    • -13
    • +22
    ./acs-content-repository/tcl/content-revision-procs.tcl
new function: ::content::revision::export_to_filesystem

This change moves functionality from file-storage to acs-content-repository.

all application packages should be free of internals, such as the storage

type. Storage_type should be handeled in the content-repository package.

We are not yet done, there is still more to do in this respect in

the file-storage package.

    • -5
    • +8
    ./acs-content-repository/acs-content-repository.info
    • -3
    • +10
    ./acs-content-repository/tcl/content-revision-procs-oracle.xql
    • -1
    • +9
    ./acs-content-repository/tcl/content-revision-procs-postgresql.xql
    • -1
    • +70
    ./acs-content-repository/tcl/content-revision-procs.tcl
    • -16
    • +0
    ./file-storage/tcl/file-storage-procs-oracle.xql
    • -16
    • +0
    ./file-storage/tcl/file-storage-procs-postgresql.xql
    • -43
    • +8
    ./file-storage/tcl/file-storage-procs.tcl
break overlong lines

    • -5
    • +18
    ./file-storage/tcl/file-storage-procs.tcl
improve comments

make actions changed from the background state-safe

Implement a checksum + cache mechanism to check whether user is sending the same file multiple times:

this is needed to address the problem of timeouts, where the server might process a request even when the client has given up and rescheduled the upload. We now store the latest checksum that has been received and compare it with the new picture.

    • -0
    • +16
    ./proctoring-support/lib/proctoring-upload.tcl
    • -0
    • +33
    ./proctoring-support/tcl/proctoring-procs.tcl
    • -0
    • +19
    ./proctoring-support/tcl/proctoring-support-init.tcl
file proctoring-support-init.tcl was initially added on branch oacs-5-10.

    • -0
    • +0
    ./proctoring-support/tcl/proctoring-support-init.tcl
Whitespace changes + Editor hints

    • -26
    • +32
    ./news-aggregator/www/opml-import-2.tcl
Replace deprecated API

    • -4
    • +4
    ./news-aggregator/www/opml-import-2.tcl
Update spanish message keys

    • -0
    • +7
    ./xowf/catalog/xowf.es_ES.ISO-8859-1.xml
Update spanish message keys

    • -2
    • +2
    ./news-aggregator/news-aggregator.info
    • -0
    • +16
    ./news-aggregator/catalog/news-aggregator.es_ES.ISO-8859-1.xml
    • -0
    • +4
    ./xolp/catalog/xolp.es_ES.ISO-8859-1.xml
Improve fix: do not even fetch the context_id for revisions, so we do not touch it when saving

Make sure that the context_id of a CRItem is always fetched from that of the item, rather than the revision, otherwise we could break object_id = context_id constraint on saving

write mutual overwrites to the system log