• last updated 7 hours ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
fix for issue #3463

Many thanks to Tony Kirkham for the fix!

    • -1
    • +2
    ./acs-mail-lite/tcl/acs-mail-lite-procs.tcl
fixed bug in redirects and disabled acs-testing package, changed node info from array to dict

    • -20
    • +22
    ./acs-tcl/tcl/request-processor-procs.tcl
minor styling improvements

added message key for sub-question, fixed cut&paste error.

    • -0
    • +1
    ./xowf/catalog/xowf.de_DE.ISO-8859-1.xml
    • -1
    • +2
    ./xowf/catalog/xowf.en_US.ISO-8859-1.xml
- fix collateral damage from earlier submissions download change (error: can't read "__form_fields")

- improve styling (many thanks to Monika Andergassen and Stephan Adelsberger)

for composite questions in 2-col layout

Declare test as production_safe

    • -2
    • +4
    ./acs-kernel/tcl/test/acs-kernel-procs.tcl
New automated test checking that the latest startup seqence was completed without errors

    • -0
    • +58
    ./acs-kernel/tcl/test/acs-kernel-procs.tcl
file acs-kernel-procs.tcl was initially added on branch oacs-5-10.

    • -0
    • +0
    ./acs-kernel/tcl/test/acs-kernel-procs.tcl
Update es_ES translation

    • -1
    • +10
    ./xowf/catalog/xowf.es_ES.ISO-8859-1.xml
Update es_ES translation

    • -0
    • +6
    ./acs-templating/catalog/acs-templating.es_ES.ISO-8859-1.xml
    • -3
    • +3
    ./xowf-monaco-plugin/xowf-monaco-plugin.info
    • -0
    • +1
    ./xowf-monaco-plugin/catalog/xowf-monaco-plugin.es_ES.ISO-8859-1.xml
    • -0
    • +2
    ./file-storage/catalog/file-storage.es_ES.ISO-8859-1.xml
fix case where the manual slash-parsing in the sitenode code is confused with percent-substitutions

This is just a "quick fix", since the Proper solution in more complex:

# A URL path /%2f/ is syntactically permissible,

# but this is not supported in the current site-nodes code. It

# would be correct, to avoid the parsing of the slashes here and

# to process instead the result of [ns_conn urlv], which is

# already parsed (before the percent substitutions). This would

# probably require the request processor to perform some mangling

# of urlv in vhost cases to set a a proper [ad_conn urlv] ... and

# of course to pass the "urlv" instead of the "url" to the

# slash-parsing functions.

improve German message catalog

add log warnings when include-contract is violated, since (in most cases) the passed values should be pre-checked

    • -4
    • +13
    ./acs-tcl/tcl/tcl-documentation-procs.tcl
improve documentation

Change value-checker form "html" to "allhtml", otherwise already saved news articles containing data urls can't be viewed

Port of downstream hotfix from Gustaf Neumann

Port of downstream modification: apply trimming of zeros to all fields in advance

This allows to treat fields as real numbers without the need to trim case by case. One can also reduce dependency to api and just use plain tcl expressions to evaluate conditions

    • -18
    • +19
    ./acs-templating/tcl/date-procs.tcl
Improve doc, remove needless properties

    • -2
    • +1
    ./proctoring-support/lib/proctoring-configure.tcl
file proctoring-configure.tcl was initially added on branch oacs-5-10.

    • -0
    • +0
    ./proctoring-support/lib/proctoring-configure.tcl
UI include to configure proctoring on an arbitrary ACS object, meant to be integrated downstream into custom UIs

    • -2
    • +3
    ./proctoring-support/proctoring-support.info
    • -0
    • +3
    ./proctoring-support/catalog/proctoring-support.de_DE.ISO-8859-1.xml
    • -0
    • +3
    ./proctoring-support/catalog/proctoring-support.en_US.ISO-8859-1.xml
    • -0
    • +1
    ./proctoring-support/lib/proctoring-configure.adp
    • -0
    • +79
    ./proctoring-support/lib/proctoring-configure.tcl
file proctoring-configure.adp was initially added on branch oacs-5-10.

    • -0
    • +0
    ./proctoring-support/lib/proctoring-configure.adp
Port of downstream HTML5 date and time form widgets by Günter Ernst

These widgets provide a better and more consistent user experience and client-side validation across multiple platforms. They should in time become the preferred alternative for dates and time for template forms.

    • -0
    • +6
    ./acs-templating/catalog/acs-templating.en_US.ISO-8859-1.xml
    • -1
    • +329
    ./acs-templating/tcl/date-procs.tcl
Comment noop result of a 18 years old typo, add remarks

    • -9
    • +15
    ./acs-templating/tcl/date-procs.tcl
Arrays might or not have been a better choice for the date object, however, such decision happened very long ago and it has worked good enough... cleanup concerning remarks

Whitespace change

Review concerning remark: the algotirhm is indeed correct, assuming the year is expressed in the Gregorian calendar

    • -3
    • +12
    ./acs-templating/tcl/date-procs.tcl
Replace deprecated idiom

Uniform documentation formatting and indentation, add missing documentation

    • -775
    • +911
    ./acs-templating/tcl/date-procs.tcl
For Postgres, take advantage of exclusive database api to check for permissions more efficiently, improve doc

    • -13
    • +41
    ./xotcl-core/tcl/06-package-procs.tcl
Notification request cleanup refactoring

One of the most expensive operations in large site is the cleanup for

notification_requests in situations, where the user has lost

permissions on an object, on which the user wanted to receive

notifications. This check was performed previously in

notification::sweep::cleanup_notifications via a permission check over

all notification requests, which can be very costly on large

sites. This change moves this cleanup into the actual notification

sending, where the permissions have to be sent anyhow.

    • -18
    • +54
    ./notifications/tcl/sweep-procs.tcl
Fix typo

    • -2
    • +2
    ./acs-templating/www/doc/no-quote-upgrade.adp
    • -1
    • +1
    ./acs-templating/www/doc/no-quote-upgrade.html