• last updated 2 hours ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Fix xotcl-core cr-items test: modifying IP comes in fact from the cr_item's acs_object (it is also on the revision, but on the items seems to take into account e.g. proxying)

    • -5
    • +4
    ./xotcl-core/tcl/test/xotcl-test-procs.tcl
Fix 3 inconsistent log messages in the test

Fix typo

improve spelling

    • -2
    • +2
    ./xowiki-portlet/tcl/xowiki-admin-portlet-procs.tcl
    • -2
    • +2
    ./xowiki-portlet/tcl/xowiki-portlet-procs.tcl
    • -2
    • +2
    ./survey/www/admin/process-response.tcl
    • -2
    • +2
    ./dotlrn/www/doc/permission-portals.adp
    • -1
    • +1
    ./evaluation-portlet/tcl/test/evaluation-portlet-procs.tcl
    • -13
    • +13
    ./evaluation-portlet/tcl/test/tclwebtest-procs.tcl
improve spelling

    • -3
    • +3
    ./acs-content-repository/tcl/content-type-procs.tcl
    • -1
    • +1
    ./acs-content-repository/tcl/publish-procs.tcl
    • -1
    • +1
    ./acs-core-docs/www/docbook-primer.adp
    • -20
    • +20
    ./ajaxhelper/www/doc/head-procs.tcl
  1. … 3 more files in changeset.
Rework acs-lang 'package-list' query 'packages_locale_status' query (89ms -> 4ms)

    • -52
    • +27
    ./acs-lang/www/admin/package-list.xql
Rework acs-lang 'package-list' query 'packages_locale_status_default' query (48ms -> 2ms)

    • -28
    • +20
    ./acs-lang/www/admin/package-list.xql
Prefer portable current_timestamp idiom to NOW()

Exploit existing acs::test::user::create api

Normalize indentation, add editor hints

    • -39
    • +46
    ./xolp/tcl/xolp-activity-procs.tcl
    • -14
    • +21
    ./xolp/tcl/xolp-competency-procs.tcl
    • -37
    • +44
    ./xolp/tcl/xolp-evaluation-procs.tcl
    • -54
    • +61
    ./xolp/tcl/xolp-indicator-procs.tcl
    • -859
    • +866
    ./xolp/tcl/test/xolp-test-procs.tcl
Modernize XoTcl idioms

    • -10
    • +10
    ./xolp/tcl/xolp-activity-procs.tcl
    • -11
    • +9
    ./xolp/tcl/xolp-evaluation-procs.tcl
    • -17
    • +17
    ./xolp/tcl/xolp-indicator-procs.tcl
Use xotcl-core indentation convention

Whitespace cleanup, normalize indentation, add editor hints

    • -94
    • +100
    ./xolp/tcl/xolp-apm-procs.tcl
Use xotcl db idioms

Rollback tests or they will interfere with the others

Reimplement query to obtain user competencies to fix xolp.user_get_competencies automated test

Personal perplexities:

- why do we specify the competency_set_id on the indicator facts? If one fact can be e.g. an exam, this might be related with multiple competency sets

- should we take into account also the validity of an activity?

Add deleted column to acs-lang 'package-list', and fixed number of messages depending on status, making it coherent with 'message-list'. Also fixed translated/untranslated count on default locale in 'message-list'. Version bump.

    • -53
    • +32
    ./acs-lang/www/admin/package-list.tcl
    • -0
    • +97
    ./acs-lang/www/admin/package-list.xql
file package-list.xql was initially added on branch oacs-5-10.

    • -0
    • +0
    ./acs-lang/www/admin/package-list.xql
Port downstream commit cab327aeda04f1f1f6b8f2310ddc88c7c081a84f from Günter Ernst:

Minor adjustments to ensure install- and uninstallability

Port of downstream commit 9cbc3f04aad075e902e64d0c67d53158160a933c from Felix Möedritscher:

feature / issue #10359: added message keys, extended the xolp API - get_competencies, get_activities_of_package, update_title

    • -0
    • +4
    ./xolp/catalog/xolp.de_DE.ISO-8859-1.xml
    • -0
    • +4
    ./xolp/catalog/xolp.en_US.ISO-8859-1.xml
    • -0
    • +12
    ./xolp/tcl/xolp-competency-procs.tcl
Fix untranslated count and view on acs-lang 'message-list' + some refactoring

    • -20
    • +24
    ./acs-lang/www/admin/message-list.tcl
remove .SELF. prefix also in link_info dict

fix typo in anonymous array

Insert missing performance indicators for the user

    • -0
    • +10
    ./xolp/tcl/test/xolp-test-procs.tcl
Fix typo

As xolp_indicator_facts_check1 wants end_timestamp <= storage_timestamp, force end_timestamp some time in the past (api won't allow to specify storage_timestamp)

As the original test expects it, make sure begin timestamp and end timestamp are the same

Fix indicator_create test case:

- handle timezone correctly

- don't rely on database language

    • -22
    • +19
    ./xolp/tcl/test/xolp-test-procs.tcl
Add documentation or make procs private to please documentation__check_proc_doc test

    • -5
    • +15
    ./xolp/tcl/xolp-indicator-procs.tcl
State dependency from acs-datetime, as we use dt_* api