• last updated 19 hours ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Major overhaul of the CKEditor support

- support for ckfinder interface "imageUploadUrl"

(as used in the "uploadimage" plugin)

- Improved configurability through config files

    • -3
    • +3
    ./richtext-ckeditor4/richtext-ckeditor4.info
    • -0
    • +142
    ./richtext-ckeditor4/tcl/ckfinder-init.tcl
    • -32
    • +92
    ./richtext-ckeditor4/tcl/richtext-procs.tcl
Small improvement for portrait management (deletion)

Exploit existing on delete cascade constraints when we delete a portrait, instead of deleting stuff manually.

Also, put remaining logics into a proc and use it in acs_user::delete to address legit use case of people wanting

to remove a user permanently without removing portrait in advance.

    • -33
    • +5
    ./acs-subsite/www/user/portrait/erase.tcl
    • -46
    • +0
    ./acs-subsite/www/user/portrait/erase.xql
    • -1
    • +24
    ./acs-tcl/tcl/community-core-procs.tcl
fix: make sure to pass displayed_object_id always to the next master template

    • -0
    • +1
    ./b-responsive-theme/lib/plain-master.adp
    • -0
    • +1
    ./layout-managed-subsite/lib/plain-master.adp
    • -0
    • +1
    ./openacs-default-theme/lib/plain-master.adp
fix: make sure to pass displayed_object_id always to the next master template

    • -0
    • +1
    ./openacs-default-theme/lib/plain-master.adp
Turn off shared workflow definition as indicated in the last message

Add Feature: Shared Workflow Definitions

Background: so far, xowf stored workflow definitions in the workflow

context, which is generated for every instantiated workflow instance

due to the needs of the State Pattern. While the old approach works

perfectly fine, when pre request only one or a few workflow instances

are created, but is inefficient, when e.g. 100 or more instances of

the workflow definition are created.

Now, the instances can share the definition, which is shared based on

the revision_id of the workflow FormPage.

OLD: obj <-> obj::wf_ctx

NEW: obj <-> obj::wf_ctx <(n)----> wf_definition

OLD scenario:

- the wf_definition was part of the context (no distinction)

- navigation from wf_ctx (and wf_definition) to object was possible

via "info parent"

NEW scenario:

- the wf_definition is separate

- one wf_definition can be used for multiple wf_ctx

- new methods are required instead of "info parent"

to navigate between these cooperating objects

* xowf::WorkflowPage.wf_context

* xowf::WorkflowConstruct.wf_context

* xowf::Context.wf_container

The navigation from a WorkflowConstruct (e.g. State) to the wf_ctx

is slow and fragile if not following usual programming conventions

and should e avoided (the methods of these constructs have the obj

passed in, so this path should not be necessary in most situations)

- as long the contents of the wf_container is constant, it can be

shared in the per-thread cache.

For now, the new feature is turned off by default via variable

::xowf::sharedWorkflowDefinition, but this will change in the future.

Make so that refreshing of theming subsite parameters doesn't include locally modified subsites

This includes also moving of logic to identify local modifications in a proc

    • -23
    • +73
    ./acs-subsite/tcl/subsite-procs.tcl
    • -25
    • +4
    ./acs-subsite/www/admin/themes/index.tcl
Regenerate ADP files

    • -1
    • +1
    ./xowiki/resources/templates/oacs-view.adp
    • -1
    • +1
    ./xowiki/resources/templates/view-book.adp
Add feature: overwrite generated ADP files only when necessary

Cases might be:

- ADP file list

- Generator updated

    • -9
    • +15
    ./xowiki/tcl/adp-generator-procs.tcl
Fix: close link target (<a name ...>); backport from HEAD

Fix: close link target (<a name ...>)

Added procs to quickly issue refresh of subsite theme parameters from current theme defaults. This is useful in a context with many subsites using the same theme, when desired behavior at upgrade is to have them reload all parameters automatically.

    • -1
    • +53
    ./acs-subsite/tcl/subsite-procs.tcl
Fix typo

Remove dependency on calender for message-key

merged changes from the oacs-5-9 branch and resolved conflicts

    • -0
    • +78
    ./acs-admin/catalog/acs-admin.de_DE.ISO-8859-1.xml
    • -0
    • +84
    ./acs-admin/catalog/acs-admin.it_IT.ISO-8859-1.xml
    • -0
    • +6
    ./acs-admin/lib/developer-services.tcl
    • -2
    • +3
    ./acs-admin/lib/service-parameters-oracle.xql
    • -2
    • +3
    ./acs-admin/lib/service-parameters-postgresql.xql
    • -1
    • +1
    ./acs-admin/lib/service-parameters.adp
    • -14
    • +29
    ./acs-admin/lib/service-parameters.tcl
    • -4
    • +11
    ./acs-admin/lib/site-wide-services.adp
    • -3
    • +19
    ./acs-admin/lib/site-wide-services.tcl
    • -0
    • +6
    ./acs-admin/tcl/acs-admin-callback-procs.tcl
    • -45
    • +54
    ./acs-admin/tcl/apm-admin-init.tcl
    • -35
    • +72
    ./acs-admin/tcl/apm-admin-procs.tcl
  1. … 7820 more files in changeset.
undo untested last minute check

    • -2
    • +8
    ./acs-tcl/tcl/apm-install-procs-oracle.xql
    • -2
    • +8
    ./acs-tcl/tcl/apm-install-procs-postgresql.xql
Fix typo

Flush cache also for ancestors of nodes when mounting a package

Unify version comparison logics so we always use apm_version_names_compare instead of other db api as apm_package_version__version_name_greater plus handcrafted queries which also might behave slightly differently

    • -8
    • +2
    ./acs-tcl/tcl/apm-install-procs-oracle.xql
    • -8
    • +2
    ./acs-tcl/tcl/apm-install-procs-postgresql.xql
Fix version number for the forums package

Update documentation

    • -1
    • +1
    ./simulation/www/doc/object-orientation-notes.html
    • -1
    • +2
    ./simulation/www/doc/package-install.html
    • -1
    • +2
    ./simulation/www/doc/simulation-lifecycle.html
Fix linebreaks in german message catalog

    • -2
    • +16
    ./acs-subsite/catalog/acs-subsite.de_DE.ISO-8859-1.xml
regenerated ducumentation

    • -4
    • +4
    ./acs-authentication/www/doc/configure-batch-sync.adp
    • -9
    • +9
    ./acs-authentication/www/doc/ext-auth-ldap-install.adp
    • -2
    • +2
    ./acs-authentication/www/doc/ext-auth-pam-install.adp
    • -1
    • +1
    ./acs-authentication/www/doc/ims-sync-driver-design.adp
    • -1
    • +1
    ./acs-authentication/www/doc/index.adp
    • -1
    • +1
    ./acs-automated-testing/www/doc/index.adp
    • -1
    • +1
    ./acs-automated-testing/www/doc/install.adp
    • -6
    • +6
    ./acs-automated-testing/www/doc/usage.adp
    • -1
    • +1
    ./acs-content-repository/www/doc/design.adp
    • -1
    • +1
    ./acs-content-repository/www/doc/index.adp
    • -3
    • +3
    ./acs-content-repository/www/doc/install.adp
  1. … 237 more files in changeset.
- do not depend on beta or development versions

- make sure that released versions are not beta or development

- align version numbers (e.g. use also 5.9.1 for xotcl-core)

- bump version numbers to 5.9.1

    • -5
    • +5
    ./acs-api-browser/acs-api-browser.info
    • -6
    • +6
    ./acs-authentication/acs-authentication.info
    • -4
    • +4
    ./acs-automated-testing/acs-automated-testing.info
    • -4
    • +4
    ./acs-bootstrap-installer/acs-bootstrap-installer.info
    • -7
    • +7
    ./acs-content-repository/acs-content-repository.info
    • -6
    • +6
    ./acs-developer-support/acs-developer-support.info
  1. … 69 more files in changeset.
make links in docbook clickable

updated changelog in docbook

Make forgotten_password_url subsite aware and fully qualified

    • -1
    • +7
    ./acs-authentication/tcl/password-procs.tcl
Removed reference to non-existing message key

    • -1
    • +1
    ./acs-subsite/catalog/acs-subsite.de_DE.ISO-8859-1.xml
align variable names

    • -5
    • +5
    ./acs-authentication/tcl/password-procs.tcl
allow to send forgotten-password-url in registration mail (similar to reset_password_url)

    • -1
    • +5
    ./acs-authentication/tcl/password-procs.tcl