• last updated 6 hours ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Specialize the way chat::Chat class retrieves the package_id: use the context_id of the chat room (if this is a valid chat room)

This will allow to embed a chat::Chat instance in a xowiki page pinting to an existing chat room and let it use the chat package specific features to e.g. keep transcripts of a conversation

  1. … 1 more file in changeset.
Fade out obsolete code

Use 'export_vars' to export 'room_id'

Whitespace cleanup + Add editor hints

Chat reform:

- rework xotcl-core chat machinery to return its responses through JSON and include information about active users

- depend on xowiki instead of xotcl-core only

- exploit xowiki "Comet" server push implementation when the browser supports it

- reduce code duplication

- drop plain HTML chat

- reduce hardcoded styling

- minor cleanups

    • -73
    • +0
    ./www/ajax/scripted-streaming-chat.js
  1. … 9 more files in changeset.
Converge render method for chat and xotcl-core package

  1. … 1 more file in changeset.
Add editor hints + Whitespace changes

Better separate data from formatting

Normalize indentation

Decouple a bit formatting from data

Give templating a chance

move all hardcoded styling to the adp template, which might be styled by the theme. Also, biring some order in the login proc, e.g. don't open and read a file to include a javascript all the time.

Modernize XoTcl idioms

Whitespace changes + add editor hints

  1. … 26 more files in changeset.
Remove superflous parentheses

  1. … 29 more files in changeset.
Align case of acs_object_type with that of the actual table (fixes automated tests)

This change intentionally ignores Oracle, as its behavior with respect to case is not clear to me.

    • -0
    • +8
    ./sql/postgresql/upgrade/upgrade-5.0-5.0.1d0.sql
Trim whitespace

Use finer grained api for user name

Add better explanation in UI for the 'Archive' option

use more appropriate status codes for error messages

  1. … 1 more file in changeset.
Reduce divergency between oracle and postgres codebase

Moderator is really a generic party and not always a user

Reduce divergency between oracle and postgres codebase

    • -11
    • +0
    ./www/moderator-revoke-postgresql.xql
Whitespace changes

  1. … 5 more files in changeset.
Avoid unnecesary existence checks.

  1. … 5 more files in changeset.
Retract package parameter configuration, as chat is not a singleton package... not clear if we will want a global paremeter for this in the future

Reduce joining

Replace leftover Naviserver-only cache idioms with retro compatible ones

Create chat room cache in a way to provide compatibility with AOLserver

make timeout and cache size configurable.

Revert massive replacement of empty list creation sentences. The use of '[list]' instead of '{}' adds semantics that could be used for performance improvements in the future, such as using a different internal representation. There is already work in this direction, avoiding the generation of the string representation during comparison of empty strings (huge thanks to Stefan Sobernig for the pointer: https://core.tcl.tk/tcl/info/44527c632ed609c2).

  1. … 474 more files in changeset.
Rework variable assignment (set -> lassign) + Whitespace changes

  1. … 17 more files in changeset.