OpenACS / openacs-4 / packages

acs-tcl

Tools

Line History

Line Count Graph
Line Count Graph

Stats

Commits this week: 1
Total Committers: 73
Last Commit: 07 Nov
Commits this week: 1
Total Lines of Code (LoC): 74,880
Net change in LoC this week: 10

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated 13 hours ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Thursday 07 Feb 2019
3:08 pm

antoniop

Exploit new -with_headers flag in db_list_of_lists to reimplement db_foreach in a way that only one db handle is used

Advantages:

- api is now transaction safe (with respect to database operations executed in the code block)

- nested db_foreach statements won't risk to occupy all available handles anymore

Possible drawbacks:

- query result needs to be completely stored inside a list before looping

- calling stack is now one level deeper...

This passes automated tests

Options
    • -52
    • +53
    ./tcl/00-database-procs.tcl
2:07 pm

antoniop

Reduce code duplication

Options
    • -20
    • +13
    ./tcl/00-database-procs.tcl
1:45 pm

antoniop

Introduce -with_headers flag in db_list_of_lists so names of returned column values can be returned as well as the first list in the result

Options
    • -4
    • +20
    ./tcl/00-database-procs.tcl
12:18 pm

antoniop

Reduce code duplication (passes automated tests)

Options
    • -27
    • +16
    ./tcl/00-database-procs.tcl
Tuesday 05 Feb 2019
4:19 pm

gustafn

improve security of ad_forms by binding request to a user

Options
    • -4
    • +16
    ./tcl/form-processing-procs.tcl
4:18 pm

gustafn

fix bracket in last commit

Options
    • -1
    • +1
    ./tcl/form-processing-procs.tcl
4:09 pm

gustafn

use usual idioms, white space changes

Options
    • -78
    • +77
    ./tcl/form-processing-procs.tcl
Thursday 31 Jan 2019
6:07 pm

hectorr

Remove backtick from the list of characters to be replaced by 'ad_sanitize_filename', as 'util::zip' deals with them properly now

Options
    • -4
    • +4
    ./tcl/utilities-procs.tcl
6:02 pm

hectorr

util::zip reform.

+ Use '::zipfile::mkzip', introduced in tcllib 1.18, if available.

+ For unix-like systems, with older tcllib versions, bash was used for changing directories. This method was problematic when using certain characters for the filenames, such as backticks, for example. In order to avoid this and properly quote everything, we use tclsh instead, in a convoluted and funny way (thanks to Nathan Coulter for the hack).

+ TODO: test this method also on windows, and unify the legacy implementations if it works.

Options
    • -20
    • +73
    ./tcl/utilities-procs.tcl
8:44 am

gustafn

ad_return_url: change default value for default_url to "."

this is not terribly important, but probably a better approximation

Options
    • -3
    • +3
    ./tcl/defs-procs.tcl
Wednesday 30 Jan 2019
10:16 pm

gustafn

switch from security::nonce_token to ::security::csp::nonce and update comments

Options
    • -9
    • +9
    ./tcl/security-procs.tcl
2:49 pm

gustafn

Allow ad_return_url to be called also, when connection is closed.

This might be the case e.g. for the search renderer. In this case, a default_url is used

Options
    • -2
    • +2
    ./acs-tcl.info
    • -15
    • +19
    ./tcl/defs-procs.tcl
  3. … 2 more files in changeset.
Saturday 26 Jan 2019
12:49 am

antoniop

Deprecate duplicated api and replace its only occurence in upstream codebase

Options
    • -3
    • +10
    ./tcl/00-database-procs.tcl
  2. … 2 more files in changeset.
Monday 21 Jan 2019
7:19 pm

hectorr

Add '`' to the list of sanitazable characters by 'ad_sanitize_filename'

Options
    • -4
    • +4
    ./tcl/utilities-procs.tcl
Friday 18 Jan 2019
2:07 pm

gernst

fixed embedded variable name in message-key

Options
    • -1
    • +1
    ./catalog/acs-tcl.de_DE.ISO-8859-1.xml
Thursday 17 Jan 2019
6:51 pm

hectorr

Whitespace changes

Options
    • -173
    • +171
    ./lib/page-error.tcl
    • -118
    • +117
    ./tcl/admin-procs.tcl
6:46 pm

hectorr

Fix typos

Options
    • -3
    • +3
    ./lib/page-error.tcl
    • -2
    • +2
    ./tcl/admin-procs.tcl
6:02 pm

hectorr

Remove trailing whitespace

Options
    • -3
    • +3
    ./tcl/acs-permissions-procs.xql
    • -14
    • +14
    ./tcl/exception-procs.tcl
    • -10
    • +10
    ./tcl/membership-rel-procs.tcl
Tuesday 15 Jan 2019
7:30 pm

gustafn

replace broken redirect with standard redirect function (auth::require_login)

Options
    • -9
    • +8
    ./tcl/security-procs.tcl
Friday 28 Dec 2018
12:24 pm

antoniop

Greatly reduce complexity of code required to support -export flag for ad_form:

instead of juggle variables around to mimick export_vars, just set -export flag

value as a form property, then use the real export_vars on it later when form

is rendered. This will support all current features (e.g. :multiple, :sign, :array)

more reliably and reduce code duplication.

Options
    • -80
    • +5
    ./tcl/form-processing-procs.tcl
  2. … 1 more file in changeset.
Saturday 22 Dec 2018
11:24 am

gustafn

no need for eagerly releasing handles

Options
    • -2
    • +1
    ./tcl/security-procs.tcl
10:39 am

gustafn

make sure not to release handles active in an transaction, transactions are based on handles

Options
    • -1
    • +10
    ./tcl/00-database-procs.tcl
Thursday 20 Dec 2018
7:27 pm

gustafn

revert escaped change

Options
    • -5
    • +2
    ./tcl/request-processor-procs.tcl
7:25 pm

gustafn

allow parameter::get_from_package_key to be called before acs-tcl/tcl/utilities-procs.tcl are called

Options
    • -3
    • +3
    ./tcl/parameter-procs.tcl
7:14 pm

gustafn

don't raise exception when folder_path is empty

Options
    • -2
    • +5
    ./tcl/request-processor-procs.tcl
    • -2
    • +6
    ./tcl/utilities-procs-naviserver.tcl
Tuesday 18 Dec 2018
10:25 pm

gustafn

activate usage of "ns_db currenthandles" when available

Options
    • -6
    • +15
    ./tcl/00-database-procs.tcl
Monday 17 Dec 2018
9:46 pm

gustafn

add error, when we are running out of handles

Options
    • -3
    • +7
    ./tcl/00-database-procs.tcl
9:17 pm

gustafn

reduce verbosity, deactivate usage 'ns_db currenthandles' for now

Options
    • -13
    • +13
    ./tcl/00-database-procs.tcl
3:35 pm

gustafn

fix typo

Options
    • -2
    • +2
    ./tcl/00-database-procs.tcl
3:29 pm

gustafn

db_handle reform

Use "ns_db currenthandles" (when available) to implement "db_with_handle"

instead of the old approach based on the global db_state variables.

The enws approach has the advantantge that it is

- more robust (deletion and creation of the per-request variables,

no coherency problem),

- simpler, and

- faster (less overhead per db_with_handle call, simple queries up to 20% faster)

time {db_string . {select object_id from acs_objects limit 1}} 1000

old: 200-230 microseconds per iteration

new: 160-180 microseconds per iteration

Options
    • -113
    • +334
    ./tcl/00-database-procs.tcl