OpenACS / openacs-4 / packages / acs-tcl

tcl

Tools

Line History

Line Count Graph
Line Count Graph

Stats

Commits this week: 0
Total Committers: 71
Last Commit: 14:41
Commits this week: 0
Total Lines of Code (LoC): 65,995
Net change in LoC this week: 0

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated 7 hours ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Friday 22 Nov 2019
7:41 pm

gustafn

bugfix: unmounting a package could lead to a deletion of services used in other packages

A new API call "site_node::unmount_services" can be used to unmount all services in a first step.

unmount services before calling "site_node::delete -node_id $node_id -delete_subnodes -delete_package"

prevents collateral damage.

Options
    • -1
    • +20
    ./site-nodes-procs.tcl
  2. … 3 more files in changeset.
5:21 pm

gustafn

prefer all caps spelling for SQL

Options
    • -3
    • +3
    ./01-database-procs.tcl
    • -2
    • +2
    ./acs-kernel-procs.tcl
    • -2
    • +2
    ./install-procs.tcl
    • -3
    • +3
    ./sql-statement-procs.tcl
    • -2
    • +2
    ./widgets-procs.tcl
  6. … 6 more files in changeset.
5:20 pm

gustafn

be more liberal for accepted network driver names

Options
    • -4
    • +4
    ./utilities-procs.tcl
11:51 am

antoniop

Deprecate country_widget proc

Options
    • -2
    • +13
    ./widgets-procs.tcl
Thursday 21 Nov 2019
8:08 pm

antoniop

Deprecate exists_and_not_null proc as it does not comply with openacs naming convention and can be replaced with plain tcl idioms

Options
    • -2
    • +7
    ./utilities-procs.tcl
  2. … 3 more files in changeset.
Wednesday 20 Nov 2019
5:46 pm

hectorr

Check the namespace as well in the 'naming__proc_naming' testcase

Options
    • -3
    • +7
    ./test/doc-check-procs.tcl
3:06 pm

antoniop

Deprecate exists_and_equals and replace its occurrences

Options
    • -2
    • +6
    ./utilities-procs.tcl
  2. … 1 more file in changeset.
12:27 pm

antoniop

Rename build_mime_message to ad_build_mime_message to comply with naming convention, replace occurrences, create deprecated wrapper

Options
    • -2
    • +18
    ./html-email-procs.tcl
    • -3
    • +3
    ./test/html-email-procs.tcl
  3. … 4 more files in changeset.
Saturday 16 Nov 2019
5:54 pm

gustafn

moved "safe_eval" under the "ad_" prefix and marked the original function as deprecated

Options
    • -5
    • +15
    ./utilities-procs.tcl
  2. … 4 more files in changeset.
5:35 pm

gustafn

added test to check, if names of Tcl procsfollow the naming guidelines of OpenACS

Options
    • -1
    • +40
    ./test/doc-check-procs.tcl
4:56 pm

gustafn

reduced clobbing of global namespace

Options
    • -3
    • +3
    ./request-processor-procs.tcl
4:45 pm

gustafn

moved "populate_secrect" to "sec_*" prefix to reduce clobbering of global namespace

Options
    • -3
    • +3
    ./security-init.tcl
    • -2
    • +2
    ./security-procs-oracle.xql
    • -2
    • +2
    ./security-procs-postgresql.xql
    • -7
    • +7
    ./security-procs.tcl
  5. … 3 more files in changeset.
4:34 pm

gustafn

move rp filter consistently under the rp_* prefix

Options
    • -3
    • +3
    ./request-processor-procs.tcl
3:49 pm

gustafn

don't clobber toplevel namespace

Options
    • -6
    • +7
    ./test/ad-proc-test-procs.tcl
Thursday 14 Nov 2019
9:24 am

gustafn

point out pre UNICODE character handling that should be fixed

Options
    • -2
    • +6
    ./utilities-procs.tcl
Wednesday 13 Nov 2019
6:04 pm

gustafn

addres kernel_id always via variable rathen than via method

Options
    • -11
    • +32
    ./security-procs.tcl
6:02 pm

gustafn

fix wrong argument (many thank to Franz Penz for reporting the bug)

Options
    • -3
    • +3
    ./navigation-procs.tcl
Thursday 07 Nov 2019
4:23 pm

gustafn

Provide a more straightforward approach of gzipping

Options
    • -10
    • +10
    ./utilities-procs.tcl
2:11 pm

antoniop

Support gzip versions < 1.6

Options
    • -2
    • +10
    ./utilities-procs.tcl
Tuesday 05 Nov 2019
11:12 am

gustafn

backport security patch from oacs-5-10

Options
    • -1
    • +12
    ./security-procs.tcl
  2. … 1 more file in changeset.
Monday 04 Nov 2019
6:30 pm

gustafn

add IPv6 loopback address as well as "always accepted" for web testing

Options
    • -2
    • +2
    ./security-procs.tcl
Saturday 02 Nov 2019
5:09 pm

gustafn

allow always 127.0.0.1 in logindata as valid peer

Options
    • -5
    • +5
    ./security-procs.tcl
Friday 01 Nov 2019
2:16 pm

gustafn

Deprecate ad_quotehtml. use ns_quotehtml instead.

Options
    • -2
    • +2
    ./01-database-procs.tcl
    • -8
    • +8
    ./deprecated-procs.tcl
    • -4
    • +4
    ./text-html-procs.tcl
  4. … 9 more files in changeset.
Thursday 31 Oct 2019
7:15 pm

gustafn

don't trust login_cookie, when no session_cookie is provided

Options
    • -1
    • +13
    ./security-procs.tcl
7:12 pm

gustafn

avoid multiple but identical calls

Options
    • -6
    • +7
    ./utilities-procs.tcl
7:11 pm

gustafn

improve cross references in apidoc

Options
    • -4
    • +16
    ./security-procs.tcl
    • -1
    • +3
    ./utilities-procs-naviserver.tcl
Tuesday 29 Oct 2019
7:41 am

antoniop

No need to force-cache the value of every parameter of every package instance

We are just adding a new parameter: this should in fact not exist and therefore no cache should be present and needed to be flushed. Furthermore, in most cases one would immediately restart the server, as this normally happens in the context of a package upgrade.

Options
    • -5
    • +1
    ./apm-procs.tcl
    • -10
    • +0
    ./apm-procs.xql
Monday 28 Oct 2019
6:38 pm

antoniop

Replace deprecated idioms

Options
    • -3
    • +2
    ./test/community-core-test-procs.tcl
Sunday 20 Oct 2019
2:52 pm

gustafn

- Fix a tricky Tcl_Obj sharing bug triggered by the usage of C-level

IndexObjs based on volatile tables. Consider the following example:

proc foo {x} {

return [bar -value x ...]

}

The Tcl_Obj "x" is shared as name of argument and as a value of the

non-positional parameter "-value". When bar (e.g. C-implemented)

uses Tcl_GetIndexFromObj*() to lookup "x" in a table of options,

which is volatile, the involved Tcl_Obj will be converted to an

indexObj.

On a call with wrong number of arguments( e.g."foo 1 2 3"), Tcl

will try to give a nice error message, saying that "foo x" can be

called only with one argument. When printing argument "x", it sees

that "x" is an indexObj, and for these kinds of objects, "x" might

be an abbreviated version of a full name. Since the table behind

the indexObj is in the case above volatile, a crash might happen.

The committed fix above is just a temporary measure. NaviServer should

try to avoid such Tcl_Obj conversions in these cases. It is also

questionable, whether the attempt to interpret a argument name as

an abbreviated.

Options
    • -6
    • +7
    ./utilities-procs-naviserver.tcl
Friday 18 Oct 2019
6:07 pm

antoniop

Whitespace cleanup

Options
    • -14
    • +13
    ./utilities-procs-naviserver.tcl