• last updated 20 hours ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Deprecate a bunch of old and weird api used nowhere

Delete this proc: does not comply with naming convention, uses the wrong table (even when the dependency package is installed), cannot be themed... you name it

Deprecate merge_form_with_query proc

Move root_of_host to acs:: namespace, replace occurrences, create deprecated wrapper

  1. … 1 more file in changeset.
Deprecate value_if_exists proc, replace occurrences with plain tcl idioms

  1. … 4 more files in changeset.
Add more borderline cases for those tempted to reimplement these procs

Move min and max procs in the util:: namespace, improve documentation, improve tests, create deprecated wrappers

Rename 'random', 'randomInit' and 'randomRange' procs to something compliant to OpenACS naming convention, replace occurrences, create deprecated wrapper

  1. … 3 more files in changeset.
provde a global variable as transitional code for controlling passing of password as query variable

  1. … 2 more files in changeset.
don't pass sensitive information (e.g. password) as query variable, but use client properties instead.

see also issue #3344

  1. … 5 more files in changeset.
unify spelling

reduce verbosity

Rename future_years_list as ad_future_years_list, create deprecated wrapper

fix typo

provide a better name (site_node::delete_service_nodes) amd delete nodes of services packages as well

  1. … 1 more file in changeset.
bugfix: unmounting a package could lead to a deletion of services used in other packages

A new API call "site_node::unmount_services" can be used to unmount all services in a first step.

unmount services before calling "site_node::delete -node_id $node_id -delete_subnodes -delete_package"

prevents collateral damage.

  1. … 3 more files in changeset.
prefer all caps spelling for SQL

  1. … 6 more files in changeset.
be more liberal for accepted network driver names

Deprecate country_widget proc

Deprecate exists_and_not_null proc as it does not comply with openacs naming convention and can be replaced with plain tcl idioms

  1. … 3 more files in changeset.
Check the namespace as well in the 'naming__proc_naming' testcase

Deprecate exists_and_equals and replace its occurrences

  1. … 1 more file in changeset.
Rename build_mime_message to ad_build_mime_message to comply with naming convention, replace occurrences, create deprecated wrapper

  1. … 4 more files in changeset.
moved "safe_eval" under the "ad_" prefix and marked the original function as deprecated

  1. … 4 more files in changeset.
added test to check, if names of Tcl procsfollow the naming guidelines of OpenACS

reduced clobbing of global namespace

moved "populate_secrect" to "sec_*" prefix to reduce clobbering of global namespace

  1. … 3 more files in changeset.
move rp filter consistently under the rp_* prefix

don't clobber toplevel namespace

point out pre UNICODE character handling that should be fixed