• last updated 1 hour ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Fix regression shown by test

Increate proc coverage

file subsite-procs.tcl was initially added on branch oacs-5-10.

    • -0
    • +0
    ./test/subsite-procs.tcl
Reform of permissions UI in acs-subsite:

- use simplified tabular view "perm-include" per default, but

allow user to switch to old list-based view

- show number of inherited permissions by default instead of full list

(list can be long). Admin can switch to full list.

- improved configurability of permissions/one.tcl

* ability to pass privileges to be displayed

* provided flag to show inherited_permissions

* provided flag to show detailed permissions (list view)

- improved configurability of permissions/perm-include.tcl

* provided flag "detailed_permissions_p" to provide access

to the old style interface, where all types of privileges

can be provided to all types of parties

- improved functionality of www/permissions/perm-user-add-include

* added search field for filtering users

- modernized idioms

- improved spelling

- extended internationalization

- bumped version of acs-subsite to 5.10.1d9

  1. … 19 more files in changeset.
improve Oracle compatibility (many thanks to Raul Rodriguez)

  1. … 1 more file in changeset.
use values with size dimensions

Deprecate application_group::child_application_groups

Deprecate template::util::is_true, implemented as a simple string command oneliner since 2015 and inline occurrences

  1. … 31 more files in changeset.
Extend test depending on the setting of EmailForgottenPasswordP

Fix missing variable, test the bug

  1. … 1 more file in changeset.
fix cut&paste issue

    • -1
    • +1
    ./subsite-callback-procs-postgresql.xql
Fixes for Oracle 19c recursive query

Oracle has a slightly differnt syntax for CTEs require arguments, keyword "recursive" is not allowed.

This fixes the following error during initial installation:

nsoracle.c:1367:OracleSelect: error in `OCIStmtExecute ()': ORA-00905: missing keyword

SQL:

with recursive !>>>!object_hierarchy as (

select object_type, supertype

from acs_object_types

where object_type = coalesce(:object_type, (select object_type

from acs_objects

where object_id = :object_id))

union all

select t.object_type, t.supertype

from acs_object_types t,

object_hierarchy s

where t.object_type = s.supertype

)

select distinct callback, callback_type as type

from subsite_callbacks

where event_type = :event_type

and object_type in (select object_type from object_hierarchy)

    • -0
    • +30
    ./subsite-callback-procs-oracle.xql
    • -0
    • +30
    ./subsite-callback-procs-postgresql.xql
Streamline ns_set idiom

  1. … 2 more files in changeset.
improve safety of SQL queries

  1. … 2 more files in changeset.
whitespace changes

Make package_id explicit

Add 'acs_subsite_rel_segment_new' test case, covering 'rel_segment::new', 'rel_segment::delete' and 'group::get_rel_segment'

Add 'acs_subsite_application_group_new' test case, covering 'application_group::new' and 'application_group::delete'

Add 'acs_subsite_rel_type_roles' test case, covering 'rel_types::create_role' and 'rel_types::create_role'

Add 'acs_subsite_relation_procs' test case, covering 'relation_add', 'relation_remove', 'relation::get_object_one', 'relation::get_object_two', 'relation::get_objects' and 'relation::get_id'

Whitespace changes

improve test coverage

Add 'acs_subsite_attribute_datatypes' test case, covering 'attribute::translate_datatype' and 'attribute::datatype_validator_exists_p' procs

Remove unnecessary aliases

Add 'attribute::value_add' and 'attribute::value_delete' to the 'acs_subsite_attributes' test case

complete listing of covered procs in test cases

  1. … 14 more files in changeset.
Remove leftovers

Whitespace changes

Add new test 'acs_subsite_attributes' covering the 'attribute::add', 'attribute::exists_p' and 'attribute::delete' procs

prefer ns_dbquotevalue over db_quote, mark latter as deprecated

  1. … 3 more files in changeset.