• last updated 3 hours ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Improve robustness of "file delete" operations

  1. … 16 more files in changeset.
Make sure that the file-creation.log exists, without using "exec touch", which is not available under windows (see issue #3311).

Trust the users's mime_type when acceptable, or content names that are not filenames won't have a mime_type

- avoid call of deprecated sql variant with 12 args via API (many thnaks to Guenter Ernst)

- handling of NULL values in cr_revision_latest_tr (many thanks to Guenter Ernst)

- bump version to 5.9.1d24

  1. … 3 more files in changeset.
Created new proc cr_check_mime_type, centralizing the retrieval of the mime_type from uploaded file's information.

Applied the new proc to the different situations in the system when we require mime_type retrieval: content-repository, file-storage and xotcl CrItem

TODO: get the real mime_type from the file content, but this would require some modification in the data model.

  1. … 3 more files in changeset.
Avoid using deprecated content_item__new/17

- Fix type of v_is_registered in dql function content_folder__register_content_type to boolean (was "varchar")

(This chance is necessary at least for pg 9.5)

  1. … 2 more files in changeset.
- fix documentation bug (... -revision best ... does not work)

- fix lob interface (especially for portraits)

  1. … 4 more files in changeset.
- prefer sql statements between curly braces

    • -2
    • +2
    ./content-revision-procs-postgresql.xql
  1. … 3 more files in changeset.
.xql-file reform of acs-content-repository

- remove sql statements from the code, where these are provided via .xql

- prefer empty sql statements over various forms of *SQL*

- remove unneeded sql queries

cr_check_orphaned_files.fetch_path

content::item::upload_file.get_parent_existing_filenames

content::revision::new.update_lob_attribute

content::init_all.get_template_url

content::init.get_live_revision

content::init_all.get_live_revision

cr::keyword::item_unassign.item_unassign

cr::keyword::get_keyword_id.select_keyword_id

cr::keyword::item_unassign_children.item_unassign_children

cr::keyword::item_get_assigned.get_keywords

cr::keyword::item_get_assigned.get_child_keywords

cr::keyword::get_options_flat.select_keyword_options

publish::write_content.get_revision_id

    • -6
    • +0
    ./acs-content-repository-procs-oracle.xql
    • -10
    • +1
    ./content-revision-procs-oracle.xql
- add editor hints to keep spaces/tabs in the furture more consistent

    • -1
    • +7
    ./acs-content-repository-callback-procs.tcl
  1. … 740 more files in changeset.
- add @see for deprecated proc

Avoid log file pollution on systems that lack a (full) content repository (e.g. development-clones of large production systems)

- fix for bug #3256

- provide a simple templated error page

  1. … 2 more files in changeset.
- replace (probably incorrect) query based on acs_object.tree_sortkey by a (probably sufficiently correct) recursive query based on cr_items (parent_ids)

- mark broken (and unused except from package "cms") function content::get_folder_labels as deprecated

Merging back to HEAD all changes that happened in branch oacs-5-8 between tags: vg-merge-oacs-5-8-from-20141027 and vg-merge-oacs-5-8-from-20150427

  1. … 519 more files in changeset.
- fix comment

- fix inconsistent way to refer to ImageMagick binary (parameter

ImageMagickPath vs. image::identify_binary)

- fix incorrect way to refer to results of ImageMagick (foreach was

dangerous and incorrect)

- fix incorrect parameter to ImageMagick (-size geometry)

- fix broken switch statement

- fix typo in name (image::imagmagick_identify should be imagemagick_identify)

- fix incorrect comments

- provide default to optional argument of filename_mime_type

- try to use built-in support and fall back to external programs

(image magick). Built-in support is several hundred times faster.

- use NaviServer's extened functionality

- fix for issue #3242: for items with a latest_revision but no live_revision, content::item::get_revision_content was raising an exception

- Fix for Bug #3237

Merging back to HEAD branch oacs-5-8 (using tag vg-merge-oacs-5-8-from-20141027).

    • -3
    • +3
    ./acs-content-repository-callback-procs.tcl
    • -0
    • +6
    ./acs-content-repository-procs-oracle.xql
    • -0
    • +17
    ./acs-content-repository-procs-postgresql.xql
    • -11
    • +74
    ./acs-content-repository-procs.tcl
  1. … 2533 more files in changeset.
cleanup in item::* namespace

most functions were already moved into the content::item namespace,

but a few were left.

- marked the following function as deprecated

* item::get_content

* item::content_is_null

* item::get_revision_content

* item::content_methods_by_type

* item::publish

* item::unpublish

- added new functions:

* content::item::content_is_null

* content::item::content_methods_by_type

* content::item::get_content

* content::item::get_revision_content

* content::item::publish

* content::item::unpublish

- updated regression test

    • -82
    • +86
    ./test/content-image-test-procs.tcl
    • -52
    • +60
    ./test/content-revision-test-procs.tcl
cleanup in cr::keyword::* namespace

one cannot advocate to create a keyword with

content::keyword::item_assign and query it with

cr::keyword::item_get_assigned)

- marked the following function as deprecaed

* cr::keyword::get_children

* cr::keyword::get_keyword_id

* cr::keyword::get_options_flat

* cr::keyword::item_get_assigned

* cr::keyword::item_unassign

* cr::keyword::item_unassign_children

- added new functions:

* content::keyword::get_children

* content::keyword::get_keyword_id

* content::keyword::get_options_flat

* content::keyword::item_get_assigned

* content::keyword::item_unassign_children

- updated regression test

    • -6
    • +6
    ./test/acs-content-repository-procs.tcl
  1. … 1 more file in changeset.
- replace calls to the deprecated functions

- mark more of the functions in the ::item::* namespace as deprecated,

since much of the detailed info is delivered by ::content::item::get

* item::get_mime_info

* item::get_extended_url

* item::get_element

- change spelling of TCL to Tcl

- change requirements to Tcl 8.5

  1. … 64 more files in changeset.
- fix api-doc variables @creation-date and @cvs-id

  1. … 3 more files in changeset.
- fix api-doc variable @creation-date

- fix invalid @param declaration for API browser

  1. … 4 more files in changeset.
- fix invalid @param declarations for API browser

  1. … 5 more files in changeset.