• last updated 12 hours ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
- change spelling of TCL to Tcl

- change requirements to Tcl 8.5

  1. … 64 more files in changeset.
- fix api-doc variables @creation-date and @cvs-id

  1. … 3 more files in changeset.
- fix api-doc variable @creation-date

- fix invalid @param declaration for API browser

  1. … 4 more files in changeset.
- fix invalid @param declarations for API browser

  1. … 5 more files in changeset.
- replace call to deprecated proc cr::keyword::new by content::keyword::new

    • -3
    • +3
    ./test/acs-content-repository-procs.tcl
- use expand operator rathen than "eval" when possible

  1. … 5 more files in changeset.
Fixed proc cr_create_content_file_from_string

Because of an earlier copy/paste mistake:

* variable $dir was not set (replaced with cr_fs_path)

* rearranged blocks, so that $content_file is already set

- better handling of potentially incorrect file names in the content repository (checking for "" is not enough)

- improve safety of orphan file deletion (e.g in case, fetch_paths returns empty file names)

    • -34
    • +45
    ./acs-content-repository-procs.tcl
- make sure to delete cr_delete_orphans only files from the cr

- write entry to deletion log before writing to disk, extend mutex

- use 4-space tab indent

file content-init.tcl was initially added on branch oacs-5-8.

file content-procs-postgresql.xql was initially added on branch oacs-5-8.

    • -0
    • +0
    ./content-procs-postgresql.xql
acs-content-repository:

- new public function "cr_cleanup_orphaned_files" to clean up orphaned

files incrementally based on cr-file creation log

- added "cr_cleanup_orphaned_files" to "cr_delete_scheduled_files"

to perform cleanup automatically

- new function to handle cr-file creation log, which is used to

removed orphaned files (created by aborted transactions)

- the function "cr_check_orphaned_files" can still be used

for cleaning up orphaned files from times before the

cr-file creation log was in place (that is from the birth of

OpenACS until now).

acs-tcl:

- new function "ad_mutex_eval" for safely executing

tcl commands under a mutex lock

    • -9
    • +5
    ./acs-content-repository-procs-postgresql.xql
    • -13
    • +18
    ./acs-content-repository-procs.tcl
  1. … 1 more file in changeset.
Added check for trailing slash on cr folder, required for find command to work properly.

    • -17
    • +24
    ./acs-content-repository-procs.tcl
- use external command "find" instead of tcllib package fileutil for speed and better filtering

- add index for much quicker reverse lookup file names in the content repository

    • -0
    • +6
    ./acs-content-repository-procs-oracle.xql
    • -0
    • +21
    ./acs-content-repository-procs-postgresql.xql
  1. … 3 more files in changeset.
file acs-content-repository-procs-postgresql.xql was initially added on branch oacs-5-8.

    • -0
    • +0
    ./acs-content-repository-procs-postgresql.xql
- cr_check_orphaned_files: new helper proc to locate (or delete) orphaned files in the content repository (see also bug #2619)

- use $::acs::rootdir rather than [acs_root_dir] or [get_server_root]

    • -2
    • +2
    ./acs-content-repository-callback-procs.tcl
  1. … 1 more file in changeset.
- use $::acs::rootdir rather than [acs_root_dir] or [get_server_root]

    • -2
    • +2
    ./acs-content-repository-callback-procs.tcl
  1. … 9 more files in changeset.
- use "![info exists]" instead of "template::util::is_nil" on scalars

  1. … 4 more files in changeset.
- use "in" operator instead of "lsearch"

- use numeric comparison operator for truth value comparisons

- make ad_return deprecated; maybe this function was useful for ancient versions of tcl, but as it is, it does not make sense (see comment in code)

  1. … 1 more file in changeset.
- use "in" or not in (ni) operator instead of lsearch (for readability and performance)

- use "eq" instead of "string equal"

- modernize tcl

    • -3
    • +4
    ./test/acs-content-repository-procs.tcl
- use "lassign" instead of "foreach ... break" idiom

  1. … 5 more files in changeset.
- use standard error message reporting

  1. … 1 more file in changeset.
- get rid of empty_string_p

  1. … 3 more files in changeset.
- replace deprecated acs_sc_call by acs_sc::invoke

  1. … 10 more files in changeset.
- replace depreacted "ns_mkdir" by "file mkdir"

  1. … 9 more files in changeset.
- added victor's patch to omit deprecated messages of "ns_info tcllib". Background: naviserver supports multiple (virtual) servers, which might have different tcllibs. Therefore, the preferred command to query this was moved to "ns_server ?-server s? tcllib" and "ns_info tcllib" was deprecated. From the OpenACS point of view, one wants to locate the actual library. Since the variable does not change, it is fine to store it in a per-thread variable which can be efficiently accessed.

  1. … 20 more files in changeset.