OpenACS

Tools

Line History

Line Count Graph
Line Count Graph

Stats

Commits this week: 6
Total Committers: 146
Last Commit: 21 Nov
Commits this week: 6
Total Lines of Code (LoC): 7,560,943
Net change in LoC this week: 122

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated 13 hours ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Thursday 23 Mar 2023
5:14 pm

antoniop

Deprecate all remaining dt_widget_* api

The rationale is that modern HTML5 provides already consistent and localized UI elements for date and time input. It is also difficult to style a widget that comes pre-baked by the api. One should either use acs-templating or xowiki feature to generate UIs, or modern HTML5 is in most cases sufficient.

Options
    • -4
    • +22
    /openacs-4/packages/acs-datetime/tcl/acs-calendar-procs.tcl
    • -5
    • +30
    /openacs-4/packages/acs-datetime/tcl/acs-datetime-procs.tcl
    • -33
    • +1
    /openacs-4/packages/acs-datetime/www/doc/design.adp
    • -42
    • +9
    /openacs-4/packages/acs-datetime/www/doc/design.html
    • -37
    • +0
    /openacs-4/packages/acs-datetime/www/doc/examples/calendar-widgets.adp
    • -40
    • +0
    /openacs-4/packages/acs-datetime/www/doc/examples/calendar-widgets.tcl
    • -53
    • +0
    /openacs-4/packages/acs-datetime/www/doc/examples/datetime-widgets.adp
    • -52
    • +0
    /openacs-4/packages/acs-datetime/www/doc/examples/datetime-widgets.tcl
    • -5
    • +1
    /openacs-4/packages/acs-datetime/www/doc/examples/index.adp
4:50 pm

antoniop

Replace deprecated api

Options
    • -11
    • +10
    /openacs-4/packages/dotlrn/www/weblog-new.tcl
4:41 pm

antoniop

Prevent Javascript in the comment content

Note that this check is additional to that coming from e.g. allowed tags or similar

Options
    • -1
    • +18
    /openacs-4/packages/general-comments/www/comment-add-2.tcl
    • -1
    • +18
    /openacs-4/packages/general-comments/www/comment-edit-2.tcl
4:24 pm

antoniop

Do not allow markup in the portlet name

Options
    • -3
    • +6
    /openacs-4/packages/static-portlet/www/element.tcl
4:22 pm

antoniop

Localize error message

Options
    • -3
    • +8
    /openacs-4/packages/acs-templating/tcl/data-procs.tcl
4:13 pm

antoniop

Use a better regexp to reimplement ad_looks_like_html_p, use the improved api to port downstream feature: an ad_form datatype validator that won't allow to insert markup

Many thanks to Günter Ernst

Options
    • -6
    • +2
    /openacs-4/packages/acs-tcl/tcl/text-html-procs.tcl
    • -1
    • +20
    /openacs-4/packages/acs-templating/tcl/data-procs.tcl
3:31 pm

antoniop

Cleanup reference to deprecated api

Options
    • -1
    • +0
    /openacs-4/packages/xowiki/tcl/test/xowiki-admin-tests-procs.tcl
3:31 pm

antoniop

Quote name, as this will be shown in the error message

Options
    • -2
    • +2
    /openacs-4/packages/xowiki/tcl/xowiki-procs.tcl
2:56 pm

antoniop

Do not allow data URLs

Options
    • -1
    • +6
    /openacs-4/packages/general-comments/www/url-add-2.tcl
2:38 pm

antoniop

Use modern HTML and OpenACS features for date input, which do not require rendering via a custom widget api and cumbersome validation

Options
    • -2
    • +2
    /openacs-4/packages/news/www/admin/approve-2-oracle.xql
    • -2
    • +2
    /openacs-4/packages/news/www/admin/approve-2-postgresql.xql
    • -10
    • +6
    /openacs-4/packages/news/www/admin/approve-2.tcl
    • -2
    • +2
    /openacs-4/packages/news/www/admin/approve.adp
    • -4
    • +3
    /openacs-4/packages/news/www/admin/approve.tcl
2:24 pm

antoniop

Deprecate dt_widget_calendar_year

Options
    • -2
    • +5
    /openacs-4/packages/acs-datetime/tcl/acs-calendar-procs.tcl
    • -4
    • +1
    /openacs-4/packages/acs-datetime/www/doc/design.adp
    • -4
    • +1
    /openacs-4/packages/acs-datetime/www/doc/design.html
    • -2
    • +1
    /openacs-4/packages/acs-datetime/www/doc/examples/calendar-widgets.tcl
    • -2
    • +1
    /openacs-4/packages/acs-datetime/www/doc/examples/index.adp
2:17 pm

antoniop

Cleanup dt_widget_calendar_navigation documentation

Options
    • -4
    • +1
    /openacs-4/packages/acs-datetime/www/doc/design.adp
    • -4
    • +2
    /openacs-4/packages/acs-datetime/www/doc/design.html
    • -42
    • +0
    /openacs-4/packages/acs-datetime/www/doc/examples/calendar-navigation.adp
    • -39
    • +0
    /openacs-4/packages/acs-datetime/www/doc/examples/calendar-navigation.tcl
2:13 pm

antoniop

Deprecate dt_widget_calendar_navigation

Options
    • -2
    • +7
    /openacs-4/packages/acs-datetime/tcl/acs-calendar-procs.tcl
2:00 pm

antoniop

Test dt_no_time_p

Options
    • -12
    • +36
    /openacs-4/packages/acs-datetime/tcl/test/acs-datetime-procs.tcl
1:50 pm

antoniop

Deprecate ad_ns_set_to_tcl_vars, which can always be replaced with simple tcl idioms

Options
    • -2
    • +10
    /openacs-4/packages/acs-tcl/tcl/utilities-procs.tcl
1:47 pm

antoniop

Update uninstall callback:

- avoid convoluted idioms

- improve documentation

- use cross dbms api

Options
    • -11
    • +26
    /openacs-4/packages/forums/tcl/forums-install-procs.tcl
1:35 pm

antoniop

Deprecate ad_user_class_description, private proc used nowhere in upstream codebase

Options
    • -2
    • +7
    /openacs-4/packages/acs-tcl/tcl/admin-procs.tcl
1:30 pm

antoniop

dt_ansi_to_list already trims the zeros, no need to create an ns_set, not need to upvar everything twice just to have the variables in our scope

Options
    • -34
    • +48
    /openacs-4/packages/acs-datetime/tcl/acs-calendar-procs.tcl
1:18 pm

trenner

harden page_contract

Options
    • -3
    • +5
    /openacs-4/packages/file-storage/www/simple-add.tcl
1:14 pm

antoniop

Test dt_get_info, fix documentation according to long standing behavior

Options
    • -8
    • +6
    /openacs-4/packages/acs-datetime/tcl/acs-calendar-procs.tcl
    • -1
    • +33
    /openacs-4/packages/acs-datetime/tcl/test/acs-datetime-procs.tcl
9:40 am

trenner

do not show grading_table if grading is "none"

Options
    • -1
    • +1
    /openacs-4/packages/xowf/tcl/test-item-procs.tcl
Wednesday 22 Mar 2023
6:45 pm

antoniop

Port of downstream feature:

check that no Portlet with the same name exists on the same portal and page before trying to enter the data.

Options
    • -2
    • +2
    /openacs-4/packages/static-portlet/static-portlet.info
    • -4
    • +5
    /openacs-4/packages/static-portlet/catalog/static-portlet.de_DE.ISO-8859-1.xml
    • -0
    • +1
    /openacs-4/packages/static-portlet/catalog/static-portlet.en_US.ISO-8859-1.xml
    • -0
    • +1
    /openacs-4/packages/static-portlet/catalog/static-portlet.it_IT.ISO-8859-1.xml
    • -7
    • +48
    /openacs-4/packages/static-portlet/www/element.tcl
5:06 pm

antoniop

Fix applet mountpoint:

.LRN UI expects the static portlet applet to be mounted under the /dotlrn/applets site node and this is also the case at the WU installation. However, upstream .LRN mounts the applet under /dotlrn, causing dead links in the UI. Rectify the situation and provide an automated test that will enforce this condition from now on.

Options
    • -3
    • +7
    /openacs-4/packages/dotlrn-static/dotlrn-static.info
    • -0
    • +93
    /openacs-4/packages/dotlrn-static/tcl/apm-callback-procs.tcl
    • -7
    • +15
    /openacs-4/packages/dotlrn-static/tcl/dotlrn-static-procs.tcl
    • -0
    • +18
    /openacs-4/packages/dotlrn-static/tcl/test/dotlrn-static-test-procs.tcl
5:06 pm

antoniop

file apm-callback-procs.tcl was initially added on branch oacs-5-10.

Options
    • -0
    • +0
    /openacs-4/packages/dotlrn-static/tcl/apm-callback-procs.tcl
2:22 pm

trenner

handle the case when instantiate_includelet is not returning an object (e.g. invalid top_includelet via user input)

Options
    • -2
    • +2
    /openacs-4/packages/xowiki/tcl/xowiki-procs.tcl
Tuesday 21 Mar 2023
6:59 pm

antoniop

For the file-storage portlet to support the "showcasing use case", instead of hacking the UI as done before, we just point it to the user folder, that should exist for everyone

Options
    • -2
    • +2
    /openacs-4/packages/fs-portlet/www/fs-portlet.tcl
6:41 pm

antoniop

Handle here as well the case, that we are just showcasing the portlet for "Portal Templates"

Options
    • -2
    • +45
    /openacs-4/packages/calendar-portlet/www/calendar-full-portlet.tcl
4:35 pm

antoniop

Handle here as well the case when this portlet is rendered in "Portal Templates"

Options
    • -4
    • +16
    /openacs-4/packages/dotlrn-homework/www/dotlrn-homework-portlet.tcl
4:27 pm

antoniop

Handle the case of "Portal Templates", when the portlet is only showcased and should not be interacted with

Options
    • -3
    • +24
    /openacs-4/packages/calendar-portlet/www/calendar-list-portlet.tcl
4:10 pm

trenner

make check more robust

Options
    • -2
    • +2
    /openacs-4/packages/general-comments/www/admin/index.tcl