OpenACS

Tools

Line History

Line Count Graph
Line Count Graph

Stats

Commits this week: 6
Total Committers: 146
Last Commit: 21 Nov
Commits this week: 6
Total Lines of Code (LoC): 7,560,943
Net change in LoC this week: 122

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated 7 hours ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Wednesday 22 Mar 2023
5:06 pm

antoniop

Fix applet mountpoint:

.LRN UI expects the static portlet applet to be mounted under the /dotlrn/applets site node and this is also the case at the WU installation. However, upstream .LRN mounts the applet under /dotlrn, causing dead links in the UI. Rectify the situation and provide an automated test that will enforce this condition from now on.

Options
    • -3
    • +7
    /openacs-4/packages/dotlrn-static/dotlrn-static.info
    • -0
    • +93
    /openacs-4/packages/dotlrn-static/tcl/apm-callback-procs.tcl
    • -7
    • +15
    /openacs-4/packages/dotlrn-static/tcl/dotlrn-static-procs.tcl
    • -0
    • +18
    /openacs-4/packages/dotlrn-static/tcl/test/dotlrn-static-test-procs.tcl
5:06 pm

antoniop

file apm-callback-procs.tcl was initially added on branch oacs-5-10.

Options
    • -0
    • +0
    /openacs-4/packages/dotlrn-static/tcl/apm-callback-procs.tcl
2:22 pm

trenner

handle the case when instantiate_includelet is not returning an object (e.g. invalid top_includelet via user input)

Options
    • -2
    • +2
    /openacs-4/packages/xowiki/tcl/xowiki-procs.tcl
Tuesday 21 Mar 2023
6:59 pm

antoniop

For the file-storage portlet to support the "showcasing use case", instead of hacking the UI as done before, we just point it to the user folder, that should exist for everyone

Options
    • -2
    • +2
    /openacs-4/packages/fs-portlet/www/fs-portlet.tcl
6:41 pm

antoniop

Handle here as well the case, that we are just showcasing the portlet for "Portal Templates"

Options
    • -2
    • +45
    /openacs-4/packages/calendar-portlet/www/calendar-full-portlet.tcl
4:35 pm

antoniop

Handle here as well the case when this portlet is rendered in "Portal Templates"

Options
    • -4
    • +16
    /openacs-4/packages/dotlrn-homework/www/dotlrn-homework-portlet.tcl
4:27 pm

antoniop

Handle the case of "Portal Templates", when the portlet is only showcased and should not be interacted with

Options
    • -3
    • +24
    /openacs-4/packages/calendar-portlet/www/calendar-list-portlet.tcl
4:10 pm

trenner

make check more robust

Options
    • -2
    • +2
    /openacs-4/packages/general-comments/www/admin/index.tcl
4:07 pm

trenner

harden page_contract

Options
    • -2
    • +2
    /openacs-4/packages/general-comments/www/url-add-2.tcl
    • -3
    • +3
    /openacs-4/packages/general-comments/www/url-edit-2.tcl
2:52 pm

antoniop

Format code in a way to avoid false positives where a column name is taken as a deprecated proc

Options
    • -9
    • +6
    /openacs-4/packages/forums/tcl/forums-procs.tcl
2:51 pm

antoniop

Cleanup deprecated api from test

Options
    • -3
    • +2
    /openacs-4/packages/forums/tcl/test/forums-procs.tcl
2:44 pm

antoniop

Go ahead and reimplement also lc_time_utc_to_local

Options
    • -16
    • +0
    /openacs-4/packages/acs-lang/tcl/localization-procs-oracle.xql
    • -14
    • +0
    /openacs-4/packages/acs-lang/tcl/localization-procs-postgresql.xql
    • -10
    • +7
    /openacs-4/packages/acs-lang/tcl/localization-procs.tcl
2:34 pm

antoniop

Reimplement lc_time_local_to_utc using lc_time_tz_convert

Options
    • -11
    • +0
    /openacs-4/packages/acs-lang/tcl/localization-procs-oracle.xql
    • -9
    • +0
    /openacs-4/packages/acs-lang/tcl/localization-procs-postgresql.xql
    • -10
    • +9
    /openacs-4/packages/acs-lang/tcl/localization-procs.tcl
2:31 pm

antoniop

Improve test for lc_time_local_to_utc, showing that its behavior is inconsitent with respect to invalid input

Options
    • -0
    • +33
    /openacs-4/packages/acs-lang/tcl/test/acs-lang-localization-procs.tcl
9:15 am

trenner

harden page contract

perm-include checks already that privs are not empty

Options
    • -2
    • +2
    /openacs-4/packages/acs-subsite/www/permissions/perm-modify.tcl
Monday 20 Mar 2023
5:07 pm

antoniop

Use UTF-8 emoji HTML entities instead of static images to convert smileys in the forums package

This has the advantage of not requiring a request to serve the images. It also avoids the need to hardcode the image size, as they will be basically treated as fonts.

Options
    • -19
    • +12
    /openacs-4/packages/forums/tcl/messages-format-procs.tcl
    • -10
    • +11
    /openacs-4/packages/forums/www/doc/emoticons.adp
4:35 pm

antoniop

Whitespace cleanup

Options
    • -5
    • +5
    /openacs-4/packages/forums/tcl/messages-format-procs.tcl
4:02 pm

antoniop

Increase proc coverage, deprecate proc in the process

Options
    • -2
    • +11
    /openacs-4/packages/forums/tcl/messages-procs.tcl
    • -6
    • +101
    /openacs-4/packages/forums/tcl/test/forums-procs.tcl
3:15 pm

antoniop

Test cornercase behavior

Options
    • -2
    • +3
    /openacs-4/packages/forums/tcl/test/forums-procs.tcl
3:11 pm

hectorr

Whitespace changes

Options
    • -3
    • +3
    /openacs-4/packages/xowiki-portlet/xowiki-portlet.info
2:58 pm

antoniop

Make Service Contract implementations private

Options
    • -5
    • +11
    /openacs-4/packages/forums/tcl/forum-reply-procs.tcl
2:53 pm

antoniop

Hardcode the word "Page" in the message keys as the German localization does

Many thanks to Markus Moser for reporting the inconsistency

Options
    • -2
    • +2
    /openacs-4/packages/xowiki-portlet/xowiki-portlet.info
    • -1
    • +1
    /openacs-4/packages/xowiki-portlet/catalog/xowiki-portlet.en_US.ISO-8859-1.xml
    • -1
    • +1
    /openacs-4/packages/xowiki-portlet/catalog/xowiki-portlet.es_ES.ISO-8859-1.xml
    • -1
    • +1
    /openacs-4/packages/xowiki-portlet/catalog/xowiki-portlet.it_IT.ISO-8859-1.xml
2:39 pm

antoniop

Deprecate forum::new_questions_allow and forum::new_questions_deny, one should use forum::edit, which will also track the change, or just inline the query instead

Options
    • -2
    • +6
    /openacs-4/packages/forums/tcl/forums-callback-procs.tcl
    • -3
    • +11
    /openacs-4/packages/forums/tcl/forums-procs.tcl
2:28 pm

antoniop

Deprecate forum::new_questions_allowed_p and replace occurrences

Options
    • -4
    • +2
    /openacs-4/packages/forums/lib/message/threads-chunk.tcl
    • -2
    • +8
    /openacs-4/packages/forums/tcl/forums-procs.tcl
    • -5
    • +1
    /openacs-4/packages/forums/tcl/test/forums-procs.tcl
2:17 pm

antoniop

Increase proc coverage

Options
    • -9
    • +44
    /openacs-4/packages/forums/tcl/test/forums-procs.tcl
2:04 pm

antoniop

Make faq::notification_delivery::do_notification private

Options
    • -1
    • +1
    /openacs-4/packages/faq/tcl/q-and-a-procs.tcl
1:58 pm

antoniop

Use better idioms to cleanup the user

Options
    • -9
    • +5
    /openacs-4/packages/tlf-survey/tcl/test/tlf-survey-test-procs.tcl
1:34 pm

antoniop

Provide an api to create a new FAQ, so that Create+Read of an FAQ can be tested

Options
    • -0
    • +23
    /openacs-4/packages/faq/tcl/faq-procs-oracle.xql
    • -0
    • +21
    /openacs-4/packages/faq/tcl/faq-procs-postgresql.xql
    • -0
    • +33
    /openacs-4/packages/faq/tcl/faq-procs.tcl
    • -0
    • +23
    /openacs-4/packages/faq/tcl/test/faq-procs.tcl
    • -13
    • +0
    /openacs-4/packages/faq/www/admin/faq-new-2-postgresql.xql
    • -19
    • +4
    /openacs-4/packages/faq/www/admin/faq-new-2.tcl
1:34 pm

antoniop

file faq-procs-oracle.xql was initially added on branch oacs-5-10.

Options
    • -0
    • +0
    /openacs-4/packages/faq/tcl/faq-procs-oracle.xql
1:34 pm

antoniop

file faq-procs-postgresql.xql was initially added on branch oacs-5-10.

Options
    • -0
    • +0
    /openacs-4/packages/faq/tcl/faq-procs-postgresql.xql