Activity OpenACS/

.LRN UI expects the static portlet applet to be mounted under the /dotlrn/applets site node and this is also the case at the WU installation. However, upstream .LRN mounts the applet under /dotlrn, causing dead links in the UI. Rectify the situation and provide an automated test that will enforce this condition from now on.

- -3
- +7
/openacs-4/packages/dotlrn-static/dotlrn-static.info
- History
- Source
- Diff
/openacs-4/packages/.../dotlrn-static.info
- -0
- +93
/openacs-4/packages/dotlrn-static/tcl/apm-callback-procs.tcl
- History
- Source
- Diff
/openacs-4/.../apm-callback-procs.tcl
- -7
- +15
/openacs-4/packages/dotlrn-static/tcl/dotlrn-static-procs.tcl
- History
- Source
- Diff
/openacs-4/.../dotlrn-static-procs.tcl
- -0
- +18
/openacs-4/packages/dotlrn-static/tcl/test/dotlrn-static-test-procs.tcl
- History
- Source
- Diff
/openacs-4/.../dotlrn-static-test-procs.tcl

5:06 pm

antoniop

More
MAIN:antoniop:20230322160604
deleted 1 file
MAIN

file apm-callback-procs.tcl was initially added on branch oacs-5-10.

- -0
- +0
/openacs-4/packages/dotlrn-static/tcl/apm-callback-procs.tcl
- History
- Source
/openacs-4/packages/.../tcl/apm-callback-procs.tcl

2:22 pm

trenner

handle the case when instantiate_includelet is not returning an object (e.g. invalid top_includelet via user input)

- -2
- +2
/openacs-4/packages/xowiki/tcl/xowiki-procs.tcl
- History
- Source
- Diff
/openacs-4/packages/.../tcl/xowiki-procs.tcl

6:59 pm

antoniop

For the file-storage portlet to support the "showcasing use case", instead of hacking the UI as done before, we just point it to the user folder, that should exist for everyone

- -2
- +2
/openacs-4/packages/fs-portlet/www/fs-portlet.tcl
- History
- Source
- Diff
/openacs-4/packages/.../www/fs-portlet.tcl

6:41 pm

antoniop

Handle here as well the case, that we are just showcasing the portlet for "Portal Templates"

- -2
- +45
/openacs-4/packages/calendar-portlet/www/calendar-full-portlet.tcl
- History
- Source
- Diff
/openacs-4/.../calendar-full-portlet.tcl

4:35 pm

antoniop

Handle here as well the case when this portlet is rendered in "Portal Templates"

- -4
- +16
/openacs-4/packages/dotlrn-homework/www/dotlrn-homework-portlet.tcl
- History
- Source
- Diff
/openacs-4/.../dotlrn-homework-portlet.tcl

4:27 pm

antoniop

Handle the case of "Portal Templates", when the portlet is only showcased and should not be interacted with

- -3
- +24
/openacs-4/packages/calendar-portlet/www/calendar-list-portlet.tcl
- History
- Source
- Diff
/openacs-4/.../calendar-list-portlet.tcl

4:10 pm

trenner

make check more robust

- -2
- +2
/openacs-4/packages/general-comments/www/admin/index.tcl
- History
- Source
- Diff
/openacs-4/packages/.../admin/index.tcl

4:07 pm

trenner

harden page_contract

- -2
- +2
/openacs-4/packages/general-comments/www/url-add-2.tcl
- History
- Source
- Diff
/openacs-4/packages/.../www/url-add-2.tcl
- -3
- +3
/openacs-4/packages/general-comments/www/url-edit-2.tcl
- History
- Source
- Diff
/openacs-4/packages/.../www/url-edit-2.tcl

2:52 pm

antoniop

Format code in a way to avoid false positives where a column name is taken as a deprecated proc

- -9
- +6
/openacs-4/packages/forums/tcl/forums-procs.tcl
- History
- Source
- Diff
/openacs-4/packages/.../tcl/forums-procs.tcl

2:51 pm

antoniop

Cleanup deprecated api from test

- -3
- +2
/openacs-4/packages/forums/tcl/test/forums-procs.tcl
- History
- Source
- Diff
/openacs-4/packages/.../test/forums-procs.tcl

2:44 pm

antoniop

Go ahead and reimplement also lc_time_utc_to_local

- -16
- +0
/openacs-4/packages/acs-lang/tcl/localization-procs-oracle.xql
- History
- Source
- Diff
/openacs-4/.../localization-procs-oracle.xql
- -14
- +0
/openacs-4/packages/acs-lang/tcl/localization-procs-postgresql.xql
- History
- Source
- Diff
/openacs-4/.../localization-procs-postgresql.xql
- -10
- +7
/openacs-4/packages/acs-lang/tcl/localization-procs.tcl
- History
- Source
- Diff
/openacs-4/.../localization-procs.tcl

2:34 pm

antoniop

Reimplement lc_time_local_to_utc using lc_time_tz_convert

- -11
- +0
/openacs-4/packages/acs-lang/tcl/localization-procs-oracle.xql
- History
- Source
- Diff
/openacs-4/.../localization-procs-oracle.xql
- -9
- +0
/openacs-4/packages/acs-lang/tcl/localization-procs-postgresql.xql
- History
- Source
- Diff
/openacs-4/.../localization-procs-postgresql.xql
- -10
- +9
/openacs-4/packages/acs-lang/tcl/localization-procs.tcl
- History
- Source
- Diff
/openacs-4/.../localization-procs.tcl

2:31 pm

antoniop

Improve test for lc_time_local_to_utc, showing that its behavior is inconsitent with respect to invalid input

- -0
- +33
/openacs-4/packages/acs-lang/tcl/test/acs-lang-localization-procs.tcl
- History
- Source
- Diff
/openacs-4/.../acs-lang-localization-procs.tcl

9:15 am

trenner

harden page contract

perm-include checks already that privs are not empty

- -2
- +2
/openacs-4/packages/acs-subsite/www/permissions/perm-modify.tcl
- History
- Source
- Diff
/openacs-4/packages/.../perm-modify.tcl

5:07 pm

antoniop

Use UTF-8 emoji HTML entities instead of static images to convert smileys in the forums package

This has the advantage of not requiring a request to serve the images. It also avoids the need to hardcode the image size, as they will be basically treated as fonts.