OpenACS

Tools

Line History

Line Count Graph
Line Count Graph

Stats

Commits this week: 6
Total Committers: 146
Last Commit: 21 Nov
Commits this week: 6
Total Lines of Code (LoC): 7,560,943
Net change in LoC this week: 122

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated 7 hours ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Thursday 23 Mar 2023
2:56 pm

antoniop

Do not allow data URLs

Options
    • -1
    • +6
    /openacs-4/packages/general-comments/www/url-add-2.tcl
2:38 pm

antoniop

Use modern HTML and OpenACS features for date input, which do not require rendering via a custom widget api and cumbersome validation

Options
    • -2
    • +2
    /openacs-4/packages/news/www/admin/approve-2-oracle.xql
    • -2
    • +2
    /openacs-4/packages/news/www/admin/approve-2-postgresql.xql
    • -10
    • +6
    /openacs-4/packages/news/www/admin/approve-2.tcl
    • -2
    • +2
    /openacs-4/packages/news/www/admin/approve.adp
    • -4
    • +3
    /openacs-4/packages/news/www/admin/approve.tcl
2:24 pm

antoniop

Deprecate dt_widget_calendar_year

Options
    • -2
    • +5
    /openacs-4/packages/acs-datetime/tcl/acs-calendar-procs.tcl
    • -4
    • +1
    /openacs-4/packages/acs-datetime/www/doc/design.adp
    • -4
    • +1
    /openacs-4/packages/acs-datetime/www/doc/design.html
    • -2
    • +1
    /openacs-4/packages/acs-datetime/www/doc/examples/calendar-widgets.tcl
    • -2
    • +1
    /openacs-4/packages/acs-datetime/www/doc/examples/index.adp
2:17 pm

antoniop

Cleanup dt_widget_calendar_navigation documentation

Options
    • -4
    • +1
    /openacs-4/packages/acs-datetime/www/doc/design.adp
    • -4
    • +2
    /openacs-4/packages/acs-datetime/www/doc/design.html
    • -42
    • +0
    /openacs-4/packages/acs-datetime/www/doc/examples/calendar-navigation.adp
    • -39
    • +0
    /openacs-4/packages/acs-datetime/www/doc/examples/calendar-navigation.tcl
2:13 pm

antoniop

Deprecate dt_widget_calendar_navigation

Options
    • -2
    • +7
    /openacs-4/packages/acs-datetime/tcl/acs-calendar-procs.tcl
2:00 pm

antoniop

Test dt_no_time_p

Options
    • -12
    • +36
    /openacs-4/packages/acs-datetime/tcl/test/acs-datetime-procs.tcl
1:50 pm

antoniop

Deprecate ad_ns_set_to_tcl_vars, which can always be replaced with simple tcl idioms

Options
    • -2
    • +10
    /openacs-4/packages/acs-tcl/tcl/utilities-procs.tcl
1:47 pm

antoniop

Update uninstall callback:

- avoid convoluted idioms

- improve documentation

- use cross dbms api

Options
    • -11
    • +26
    /openacs-4/packages/forums/tcl/forums-install-procs.tcl
1:35 pm

antoniop

Deprecate ad_user_class_description, private proc used nowhere in upstream codebase

Options
    • -2
    • +7
    /openacs-4/packages/acs-tcl/tcl/admin-procs.tcl
1:30 pm

antoniop

dt_ansi_to_list already trims the zeros, no need to create an ns_set, not need to upvar everything twice just to have the variables in our scope

Options
    • -34
    • +48
    /openacs-4/packages/acs-datetime/tcl/acs-calendar-procs.tcl
1:18 pm

trenner

harden page_contract

Options
    • -3
    • +5
    /openacs-4/packages/file-storage/www/simple-add.tcl
1:14 pm

antoniop

Test dt_get_info, fix documentation according to long standing behavior

Options
    • -8
    • +6
    /openacs-4/packages/acs-datetime/tcl/acs-calendar-procs.tcl
    • -1
    • +33
    /openacs-4/packages/acs-datetime/tcl/test/acs-datetime-procs.tcl
9:40 am

trenner

do not show grading_table if grading is "none"

Options
    • -1
    • +1
    /openacs-4/packages/xowf/tcl/test-item-procs.tcl
Wednesday 22 Mar 2023
6:45 pm

antoniop

Port of downstream feature:

check that no Portlet with the same name exists on the same portal and page before trying to enter the data.

Options
    • -2
    • +2
    /openacs-4/packages/static-portlet/static-portlet.info
    • -4
    • +5
    /openacs-4/packages/static-portlet/catalog/static-portlet.de_DE.ISO-8859-1.xml
    • -0
    • +1
    /openacs-4/packages/static-portlet/catalog/static-portlet.en_US.ISO-8859-1.xml
    • -0
    • +1
    /openacs-4/packages/static-portlet/catalog/static-portlet.it_IT.ISO-8859-1.xml
    • -7
    • +48
    /openacs-4/packages/static-portlet/www/element.tcl
5:06 pm

antoniop

Fix applet mountpoint:

.LRN UI expects the static portlet applet to be mounted under the /dotlrn/applets site node and this is also the case at the WU installation. However, upstream .LRN mounts the applet under /dotlrn, causing dead links in the UI. Rectify the situation and provide an automated test that will enforce this condition from now on.

Options
    • -3
    • +7
    /openacs-4/packages/dotlrn-static/dotlrn-static.info
    • -0
    • +93
    /openacs-4/packages/dotlrn-static/tcl/apm-callback-procs.tcl
    • -7
    • +15
    /openacs-4/packages/dotlrn-static/tcl/dotlrn-static-procs.tcl
    • -0
    • +18
    /openacs-4/packages/dotlrn-static/tcl/test/dotlrn-static-test-procs.tcl
5:06 pm

antoniop

file apm-callback-procs.tcl was initially added on branch oacs-5-10.

Options
    • -0
    • +0
    /openacs-4/packages/dotlrn-static/tcl/apm-callback-procs.tcl
2:22 pm

trenner

handle the case when instantiate_includelet is not returning an object (e.g. invalid top_includelet via user input)

Options
    • -2
    • +2
    /openacs-4/packages/xowiki/tcl/xowiki-procs.tcl
Tuesday 21 Mar 2023
6:59 pm

antoniop

For the file-storage portlet to support the "showcasing use case", instead of hacking the UI as done before, we just point it to the user folder, that should exist for everyone

Options
    • -2
    • +2
    /openacs-4/packages/fs-portlet/www/fs-portlet.tcl
6:41 pm

antoniop

Handle here as well the case, that we are just showcasing the portlet for "Portal Templates"

Options
    • -2
    • +45
    /openacs-4/packages/calendar-portlet/www/calendar-full-portlet.tcl
4:35 pm

antoniop

Handle here as well the case when this portlet is rendered in "Portal Templates"

Options
    • -4
    • +16
    /openacs-4/packages/dotlrn-homework/www/dotlrn-homework-portlet.tcl
4:27 pm

antoniop

Handle the case of "Portal Templates", when the portlet is only showcased and should not be interacted with

Options
    • -3
    • +24
    /openacs-4/packages/calendar-portlet/www/calendar-list-portlet.tcl
4:10 pm

trenner

make check more robust

Options
    • -2
    • +2
    /openacs-4/packages/general-comments/www/admin/index.tcl
4:07 pm

trenner

harden page_contract

Options
    • -2
    • +2
    /openacs-4/packages/general-comments/www/url-add-2.tcl
    • -3
    • +3
    /openacs-4/packages/general-comments/www/url-edit-2.tcl
2:52 pm

antoniop

Format code in a way to avoid false positives where a column name is taken as a deprecated proc

Options
    • -9
    • +6
    /openacs-4/packages/forums/tcl/forums-procs.tcl
2:51 pm

antoniop

Cleanup deprecated api from test

Options
    • -3
    • +2
    /openacs-4/packages/forums/tcl/test/forums-procs.tcl
2:44 pm

antoniop

Go ahead and reimplement also lc_time_utc_to_local

Options
    • -16
    • +0
    /openacs-4/packages/acs-lang/tcl/localization-procs-oracle.xql
    • -14
    • +0
    /openacs-4/packages/acs-lang/tcl/localization-procs-postgresql.xql
    • -10
    • +7
    /openacs-4/packages/acs-lang/tcl/localization-procs.tcl
2:34 pm

antoniop

Reimplement lc_time_local_to_utc using lc_time_tz_convert

Options
    • -11
    • +0
    /openacs-4/packages/acs-lang/tcl/localization-procs-oracle.xql
    • -9
    • +0
    /openacs-4/packages/acs-lang/tcl/localization-procs-postgresql.xql
    • -10
    • +9
    /openacs-4/packages/acs-lang/tcl/localization-procs.tcl
2:31 pm

antoniop

Improve test for lc_time_local_to_utc, showing that its behavior is inconsitent with respect to invalid input

Options
    • -0
    • +33
    /openacs-4/packages/acs-lang/tcl/test/acs-lang-localization-procs.tcl
9:15 am

trenner

harden page contract

perm-include checks already that privs are not empty

Options
    • -2
    • +2
    /openacs-4/packages/acs-subsite/www/permissions/perm-modify.tcl
Monday 20 Mar 2023
5:07 pm

antoniop

Use UTF-8 emoji HTML entities instead of static images to convert smileys in the forums package

This has the advantage of not requiring a request to serve the images. It also avoids the need to hardcode the image size, as they will be basically treated as fonts.

Options
    • -19
    • +12
    /openacs-4/packages/forums/tcl/messages-format-procs.tcl
    • -10
    • +11
    /openacs-4/packages/forums/www/doc/emoticons.adp