Undo part of the recent cache-deactivation for attribute definitions
When all calls for "db_attribute_defined" are performed without cachin…
Show more
Undo part of the recent cache-deactivation for attribute definitionsWhen all calls for "db_attribute_defined" are performed withoutcaching, this results in a huge amount of additional SQL queries,since these tests are performed during blueprint definition as wellduring every blueprint reload of every db attribute. On a small sitewith just 6 connection threads (2 monitor, 2 default, 2 slow), thisresults during startup with 969 additional SQL queries, a reload ofxowiki causes an additional 1063 of such queries. When a site definesmuch more connection threads ((the LEARN site has e.g. 85 connectionthreads defined), these DB attribute testing operations will result in10K+ of mostly useless SQL queries. As a consequence of this, thestartup of the server will become slower, reloads will become sloweretc., which is bad especially for large sites.The new implementation seems to fix the original problem case (runningxotcl_core_tutorial_4 multiple times). If there is still a problemwith installing xolp [2] this problem should be analyzed and fixedprobably there. If necessary, a proper bug report would be appreciatedto reduce guessing work.[1] https://fisheye.openacs.org/changelog/OpenACS/?cs=oacs-5-10%3Aantoniop%3A20230310183055[2] https://fisheye.openacs.org/changelog/OpenACS/?cs=oacs-5-10%3Aantoniop%3A20230317160241Show less