• last updated 16 hours ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
undo escaped changes (debugging info)

avoid that invalid tags are inserted to the db

The inserted tags have to be compatible with

Package->validate_tag

    • -4
    • +10
    ./xotcl-core/tcl/30-widget-procs.tcl
Intercept the cornercase of a pretty name made exclusively of invalid characters, which would result in an empty cr_items.name and in an error

    • -1
    • +10
    ./file-storage/www/folder-create.tcl
Bring SQL inline, cleanup obsolete remarks

    • -7
    • +10
    ./file-storage/www/folder-create.tcl
    • -15
    • +0
    ./file-storage/www/folder-create.xql
Whitespace changes

    • -26
    • +26
    ./file-storage/www/folder-create.tcl
set the granularity to 5 to support also values like 125% and 175%

Return result as a plain list, rather than forcing a string representation, so that "evil" tags containing e.g. double quotes are properly quoted and list idioms such as lsort executed on this proc's output work properly

The issue was found e.g. in the my-tags includelet

extend tests for naturalnum

    • -1
    • +1
    ./acs-tcl/tcl/test/acs-tcl-test-procs.tcl
improve safety of SQL queries

    • -17
    • +5
    ./acs-templating/tcl/paginator-procs.tcl
improve safety of SQL queries

improve safety of SQL queries

Prefer api to retrieve the acs-kernel id, as this will work also in corercases such as bootstraping of a new OpenACS instance

    • -5
    • +5
    ./acs-tcl/tcl/server-cluster-procs.tcl
avoid multiple substitution for question names starting with the same string (e.g. question, question-1)

remove obsolete variable

Whitespace changes

    • -62
    • +53
    ./dotlrn/tcl/dotlrn-callback-procs.tcl
Add callback hooks for archive, unarchive and delete. Thanks to Felix Moedritscher

    • -1
    • +26
    ./dotlrn/tcl/dotlrn-callback-procs.tcl
Tighten ad_page_contract check for item_id

disallow nested composite questions

Extend high-level filtering by providing "-unless" clause in form-field class "form_page"

- added "unless" clause to form-field class "test_section" to be able to filter

certain pages which should not be included

- reduced redundancy be factor out "compute_filter_clauses" method for FormPage

(used in includelet procs (class "form-usages") and form-field procs (class "form_page")

    • -18
    • +13
    ./xowiki/tcl/includelet-procs.tcl
fix wrong name (not sure, why i have not noticed this earlier)

added statement (commented out) flag for debugging of resource path loading

added a "-verbose" flag to template::themed_template and template::resource_path to ease debugging

    • -2
    • +18
    ./acs-templating/tcl/util-procs.tcl
perform also sitewide flushes for urspace based site-node cache

Revert escaped code

    • -0
    • +3
    ./forums/lib/user/post-history-chunk.adp
    • -1
    • +4
    ./forums/lib/user/post-history-chunk.tcl
Fix default name

    • -3
    • +0
    ./forums/lib/user/post-history-chunk.adp
    • -4
    • +1
    ./forums/lib/user/post-history-chunk.tcl
More work on refactoring and streamlining cluster infrastructure

- removed more cases of ad-hoc parsing of IP address and port

- reduced code redundancy

- fixed incorrect comments

- removed obsolete private functions server_cluster_httpget_from_peers

and server_cluster_do_httpget (replaced by acs::clusterwide)

    • -51
    • +43
    ./acs-tcl/tcl/server-cluster-procs.tcl
Refactored and streamlined of cluster infrastructure

- base the API new new cluster infrastructure (including memoize-flush, server_cluster_peer_hosts, etc.)

- improved handling for multiple IP addresses and IPv6

- removed assumptions of local vs. global network drivers

- server_cluster_httpget_from_peers not used anymore

    • -19
    • +50
    ./acs-tcl/tcl/acs-cache-procs.tcl
    • -23
    • +13
    ./acs-tcl/tcl/server-cluster-procs.tcl
Provide a default timeout of 5m to all ns_cache besed caches created via the acs-cache infrastructure

Background: in case, a db entry is to be cached, where the db query

does not finish (e.g. runs into a deadlock), subsequent attempts for

the same value will be blocked as well by the mutex protecting the

entry to be cached. Therefore, later requests to this entry might queue

up in the server. By providing a timeout, this mutex will terminate

latest when the timeout is reached.

The default value for the timeout is set to 5m. In case a certain

cache might issue requests running longer than this, the cache has

to be configured with a larger timeout value.

Use the test machinery to simulate a cookie authentication

    • -29
    • +10
    ./acs-authentication/tcl/test/authentication-procs.tcl
improve spelling