• last updated 18 hours ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Now that oneof filter can handle a wider range of formattings, prefer this filter to manual validation

    • -9
    • +2
    ./general-comments/www/comment-add-2.tcl
    • -9
    • +2
    ./general-comments/www/comment-edit-2.tcl
    • -9
    • +2
    ./general-comments/www/comment-edit-3.tcl
Prefer literal to noquote in template properties

    • -1
    • +1
    ./contacts-lite/www/addresses/add-edit.adp
    • -2
    • +2
    ./contacts-lite/www/addresses/delete.adp
    • -2
    • +2
    ./contacts-lite/www/addresses/index.adp
    • -2
    • +2
    ./contacts-lite/www/admin/address-type/index.adp
  1. … 12 more files in changeset.
Prefer literal to noquote in template properties

    • -2
    • +2
    ./scorm-simple-lms/www/admin/confirm-delete.adp
    • -2
    • +2
    ./scorm-simple-lms/www/admin/delete-course.adp
    • -2
    • +2
    ./scorm-simple-lms/www/admin/edit-properties.adp
Handle acs-mail-lite conf regarding the recipient in the test

    • -2
    • +11
    ./acs-authentication/tcl/test/local-procs.tcl
Make sure test email is fine even when usernames are emails

Use lowercase letter to append to the fake username, so that if it should be an email, it will still be valid

Replace calls to deprecated call "util_commify_number"

Use lc_numeric instead

    • -2
    • +2
    ./schema-browser/tcl/schema-browser-procs-postgresql.tcl
revert escaped version

    • -14
    • +12
    ./acs-tcl/tcl/parameter-procs.tcl
reduce verbosity

    • -12
    • +14
    ./acs-tcl/tcl/parameter-procs.tcl
reduce verbosity

    • -2
    • +2
    ./acs-templating/tcl/element-procs.tcl
improve comments

avoid deprecated proc template::util::is_true

remove constant from deprecated message

    • -2
    • +5
    ./acs-bootstrap-installer/tcl/00-proc-procs.tcl
Give people the chance to use OpenACS with WithDeprecatedCode set to 0

When OpenACS is configured to omit loading of long deprecated code

(WithDeprecatedCode set to 0) files like deprecated-procs.tcl are not

loaded. Therefore, these files should only contain code, which was

deprecated at LEAST ONE RELEASE EARLIER, such that site admins have

one release time to fix calls to deprecated code. This is especially

important for public procs.

    • -102
    • +2
    ./acs-tcl/tcl/deprecated-procs.tcl
    • -2
    • +107
    ./acs-tcl/tcl/utilities-procs.tcl
Follow the litmus test suite and address issues reported in the "props" section:

* allow properties expressed in "high unicode" by using the database, rather than the filesystem to store them. (TODO: provide an own data-model, right now I am using persistent client properties)

* return all requested properties, reporting 404 when these properties do not exist

    • -123
    • +127
    ./oacs-dav/tcl/tDAV-procs.tcl
Cleanup debug

Follow the litmus test suite and improve standard compliance for the "copymove" test section:

- return 204 when trying to copy on an existing resource (by trimming traling slash in the destination path before checking)

- return 409 when one tries to copy/move to a non-existant resource

This makes the "copymove" section pass without warnings

Fix boolean expression, as the permission api will return a generic boolean, not necessarily 1 or 0

Fix query in oacs_dav::children_have_permission_p

    • -1
    • +1
    ./oacs-dav/tcl/oacs-dav-procs-postgresql.xql
Test oacs_dav::children_have_permission_p: this test exposes a bug in the api

    • -1
    • +108
    ./oacs-dav/tcl/test/oacs-dav-procs.tcl
Modernize tcl

    • -14
    • +22
    ./oacs-dav/tcl/test/oacs-dav-procs.tcl
    • -28
    • +1
    ./oacs-dav/tcl/test/oacs-dav-procs.xql
Make service contract implementation private and replace foreign occurrences

    • -10
    • +37
    ./file-storage/tcl/file-storage-dav-procs.tcl
    • -21
    • +25
    ./oacs-dav/tcl/oacs-dav-procs.tcl
produce error message in the error log, if the parameter value_array_list is not well formed

Whitespace changes

    • -17
    • +17
    ./file-storage/tcl/file-storage-dav-procs.tcl
show the amount of questions only if the no_position parameter is not provided

-) the no_position parameter is provided for the composite question form

Prefer the classical procedural api in the installation callbacks for these two packages:

- currently, acs-service-contract (among others) defines database functions with the same number of arguments, but different argument types. The acs::dc facility won't be able to distinguish which is the correct one to pick in this case

- a cicken/egg problem arises when one installs xowiki-portlet alongside the new-portal package, because before a restart the acs::dc methods won't be created yet

    • -39
    • +11
    ./dotlrn-xowiki/tcl/xowiki-applet-procs.tcl
    • -36
    • +20
    ./xowiki-portlet/tcl/xowiki-admin-portlet-procs.tcl
    • -37
    • +21
    ./xowiki-portlet/tcl/xowiki-portlet-procs.tcl
Fix typo in test

    • -1
    • +1
    ./acs-authentication/tcl/test/local-procs.tcl
Complete coverage for the ACS Service Contract 'auth_user_info'

    • -0
    • +47
    ./acs-authentication/tcl/test/local-procs.tcl
Complete coverage of ACS Service Contract 'auth_sync_retrieve' implementations

Test IMS_Enterprise_v_1p1 implementation of the auth_sync_process Service Contract

    • -1
    • +213
    ./acs-authentication/tcl/test/sync-test-procs.tcl