• last updated 8 hours ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
allow parameter::get_from_package_key to be called before acs-tcl/tcl/utilities-procs.tcl are called

    • -3
    • +3
    ./packages/acs-tcl/tcl/parameter-procs.tcl
rely on ad_urlencode_folder_path working with empty path

    • -2
    • +2
    ./packages/file-storage/www/folder-chunk.tcl
don't raise exception when folder_path is empty

check for empty folder_path

    • -2
    • +2
    ./packages/file-storage/www/folder-chunk.tcl
made value retrival for parameters "DefaultDimensionalStyle" and "DefaultListFilterStyle" theme aware

    • -5
    • +11
    ./packages/acs-templating/tcl/list-procs.tcl
encode folder_path

    • -2
    • +2
    ./packages/file-storage/www/folder-chunk.tcl
proivde upgrades script for PG 11 and bump version number to 5.9.2d2

file upgrade-5.9.2d1-5.9.2d2.sql was initially added on branch oacs-5-9.

backport from HEAD for PG 11

Remove stupid upvar tricks

    • -17
    • +6
    ./packages/new-portal/tcl/portal-procs.tcl
reduce quoting

    • -4
    • +3
    ./packages/new-portal/tcl/portal-procs.tcl
make portal::show_proc_helper theme aware

    • -3
    • +3
    ./packages/new-portal/tcl/portal-procs.tcl
activate usage of "ns_db currenthandles" when available

    • -6
    • +15
    ./packages/acs-tcl/tcl/00-database-procs.tcl
Put event handler inline so is attached at element creation, fix URLencoding of image deletion

Bring event handler inline to force it being attached after the upload button is added to the page

Add missing parameter in calc_wiki_image_links_to_image_tags

See bug tracker #3372

    • -2
    • +2
    ./packages/xowiki/www/resources/ckeip.js
add message key

whitespace changes

    • -53
    • +53
    ./packages/acs-templating/tcl/tag-init.tcl
    • -35
    • +34
    ./packages/acs-templating/tcl/tag-procs.tcl
add error, when we are running out of handles

    • -3
    • +7
    ./packages/acs-tcl/tcl/00-database-procs.tcl
reduce verbosity, deactivate usage 'ns_db currenthandles' for now

    • -13
    • +13
    ./packages/acs-tcl/tcl/00-database-procs.tcl
reveive dotlrn community includelet

    • -0
    • +222
    ./packages/xowiki/tcl/dotlrn-portal-procs.tcl
modernize code

prefer "array size" over llength of names

    • -2
    • +2
    ./packages/xowiki/tcl/import-procs.tcl
prefer "-base" parameter of export_vars

    • -1
    • +1
    ./packages/xowiki/tcl/test/test-procs.tcl
add quotes for nicer editor rendering

    • -2
    • +2
    ./packages/xowiki/tcl/form-field-procs.tcl
    • -2
    • +2
    ./packages/xowiki/tcl/package-procs.tcl
fix typo

    • -2
    • +2
    ./packages/acs-tcl/tcl/00-database-procs.tcl
db_handle reform

Use "ns_db currenthandles" (when available) to implement "db_with_handle"

instead of the old approach based on the global db_state variables.

The enws approach has the advantantge that it is

- more robust (deletion and creation of the per-request variables,

no coherency problem),

- simpler, and

- faster (less overhead per db_with_handle call, simple queries up to 20% faster)

time {db_string . {select object_id from acs_objects limit 1}} 1000

old: 200-230 microseconds per iteration

new: 160-180 microseconds per iteration

    • -113
    • +334
    ./packages/acs-tcl/tcl/00-database-procs.tcl
Replace single quotes wuith double quotes in javascript expressions involving acs_ListBulkActionClick

this is really needed only for the URL part, but was done on the name as well for consistency. The reason

is even a properly encoded URL could still contain single quotes, therefore breaking the expression,

while double quotes are expected to be encoded in valid, urlencoded URLs. This relies on trusting the developer

to properly encode URLs, which should be expected. An alternative could involve active escaping of

javascript special characters by e.g. ad_js_escape.

    • -2
    • +2
    ./packages/xotcl-core/tcl/30-widget-procs.tcl
    • -2
    • +2
    ./packages/xowiki/tcl/bootstrap-procs.tcl
[PostgreSQL 11] Change 'with (iscachable)' to IMMUTABLE for PG11

[PostgreSQL 11] Change 'with (iscachable)' to IMMUTABLE for PG11