• last updated 16 hours ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Check also for empty lines at the end of the file in the 'files__trailing_whitespace' test case

Fix files__page_contracts automated test for the page

Use localized message when returning 403 and no custom message is specified

Provide an ad_include_contract for the page (fixes files__page_contracts)

Ehm.. revert previous commit: search would use service contract to get the search form, so we should no assume local-search to be used...

    • -0
    • +106
    ./packages/acs-authentication/lib/search.adp
    • -0
    • +155
    ./packages/acs-authentication/lib/search.tcl
Removal of obsolete user search includes

Rationale:

- no mention to these pages anywhere in upstream packages

- local-search fails files__page_contracts automated test

- weird code in local-search (where is authority_id used to filter users?...)

- acs-admin/users/complex-search is a working replacement and duplicates their intended features

- as for TIP#125, in case complex-search was not reusable, probably a minor rework would do

    • -106
    • +0
    ./packages/acs-authentication/lib/search.adp
    • -155
    • +0
    ./packages/acs-authentication/lib/search.tcl
added cookie management by passing request dict as "-session" to next requests

- new webtest API calls:

::acs::test::login

::acs::test::logout

- transformed tclwebtest_example to webtest_example (not using twt)

Allow to specify the URL which is used for regression

testing for cases, where it is hard to determine (when e.g. running

behind a proxy server)

whitespace changes

Document the use of the parameter 'args' containing a list of a variable number of arguments

Fix proc doc parameters without description

Trim whitespaces

    • -8
    • +8
    ./packages/acs-authentication/lib/search.adp
Indentation change

    • -3
    • +13
    ./packages/acs-authentication/lib/search.adp
Fix parameter name in proc doc

    • -2
    • +2
    ./packages/xowiki/tcl/package-procs.tcl
Parameters UI: show main (empty) section at the beginning and deprecated section at the bottom

Whitespace changes

    • -2
    • +2
    ./packages/assessment/tcl/as-list-procs.tcl
    • -153
    • +152
    ./packages/dotlrn/tcl/dotlrn-procs.tcl
    • -412
    • +412
    ./packages/evaluation/tcl/evaluation-procs.tcl
    • -15
    • +15
    ./packages/views/tcl/views-procs.tcl
Add @see in deprecated proc, declare acs-kernel.AdminOwner parameter deprecated (superseded by acs-kernel.HostAdministrator)

    • -3
    • +4
    ./packages/acs-tcl/tcl/deprecated-procs.tcl
Fix proc doc errors detected by 'documentation__check_parameters'

    • -7
    • +4
    ./packages/assessment/tcl/as-list-procs.tcl
    • -2
    • +2
    ./packages/dotlrn/tcl/community-procs.tcl
    • -3
    • +3
    ./packages/dotlrn/tcl/dotlrn-procs.tcl
    • -10
    • +8
    ./packages/evaluation/tcl/evaluation-procs.tcl
Whitespace cleanup

    • -15
    • +15
    ./packages/xowf/tcl/test/xowf-test-procs.tcl
Fix cases when 'selected_p' is empty, which is the default for 'ad_get_client_property'

    • -3
    • +8
    ./packages/theme-selva/tcl/selva-procs.tcl
    • -3
    • +8
    ./packages/theme-zen/tcl/navigation-procs.tcl
Fix URL

include content_pages and include_pages in call graph analysis

include protection hints for callers in callgraph display

include acs-bootstrap-installer/bootstrap.tcl in init files for callgraph analysis

apm_source and apm_guess_db_type are called from multiple packages

improve callgraph display: handle false positives

include calls from *-init.tcl files in call graph analysis

- reduce verbosity

- improve structuring

allow as well testing via https

Fix parameter name and rework proc doc