• last updated 10 hours ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
update category-portlet for existing instances

Backfix upgrade to be PostgreSQL 9.0 compliant

Backport fix to https://openacs.org/bugtracker/openacs/bug?format=table&bug_number=3331: fix original problematic update

file upgrade-5.9.1-5.9.2d1.sql was initially added on branch oacs-5-9.

Fix nesting level issue for old-style includes, which is bugging Frank

https://openacs.org/forums/message-view?message_id=5377895

Fix typo

Use PostgreSQL 9.0 compatible idioms in 'sql' stored procedure

    • -0
    • +20
    ./acs-kernel/sql/postgresql/upgrade/upgrade-5.10.0d2-5.10.0d3.sql
Protect against certain potential dead-locks in PostgreSQL: allow to provide sql suffixes like e.g. FOR NO KEY UPDATE for certain operations

Handle access to non-existent faq question through human-readable error message

Fix typo

fix typo

Improve warning message to provide more precise context

Fix boolean expressions in .adp file

Bug fix: avoid confusion between command argument and option, when argument starts with "-"

    • -3
    • +3
    ./file-storage/tcl/file-storage-procs.tcl
    • -2
    • +2
    ./forums/lib/message/threads-chunk.tcl
    • -3
    • +3
    ./xotcl-request-monitor/tcl/throttle_mod-procs.tcl
  1. … 67 more files in changeset.
Prefer XOTcl 2.0 idioms

    • -29
    • +28
    ./xotcl-core/tcl/20-Ordered-Composite-procs.tcl
    • -123
    • +115
    ./xotcl-core/tcl/context-procs.tcl
Bug fix: avoid confusion between text argument and option, when text starts with "-"

    • -2
    • +2
    ./acs-tcl/tcl/test/html-conversion-procs.tcl
    • -2
    • +2
    ./bug-tracker/www/related-file-add.tcl
    • -2
    • +2
    ./bug-tracker/www/related-file-update.tcl
    • -3
    • +3
    ./bug-tracker/www/admin/categories.adp
  1. … 22 more files in changeset.
Bug fix: avoid confusion between test argument and option, when text starts with "-"

Many thanks to Franz Penz

    • -2
    • +2
    ./acs-mail-lite/tcl/acs-mail-lite-procs.tcl
Introduce a callback hook for packages to insert some specific logic

Driver is reduce difference between downstream and upstream code

    • -1
    • +17
    ./dotlrn/tcl/dotlrn-callback-procs.tcl
fix category-portlet to support the latest TreeNode Class

Don't tamper with permissions to remember whether we should be able to moderate or not

Show moderate button only when forum is actually moderated

check truth by lean and mean tcl idiom

    • -5
    • +5
    ./forums/lib/message/threads-chunk.tcl
Ehm, fix missed occurrency of message level permission check

Fix typo in deprecated proc (not used upstream anymore)

    • -2
    • +2
    ./forums/tcl/forums-security-procs.tcl
reuse forum properties

Forum reform

- remove hardcoded dependency with registered_users group. Target is to improve suitability in convoluted multi groups/multi subsites context

- in place of previous permission-based machinery, use plain table columns to detect whether user can or cannot post replies/new threads

- remove permission check at the message level in favor of that on forum level

    • -9
    • +4
    ./forums/lib/message/threads-chunk.tcl
    • -0
    • +18
    ./forums/sql/oracle/upgrade/upgrade-1.3-1.3d1.sql
    • -0
    • +13
    ./forums/sql/postgresql/upgrade/upgrade-1.3-1.3.1d1.sql
    • -74
    • +62
    ./forums/tcl/forums-security-procs.tcl
    • -2
    • +3
    ./forums/www/moderate/message-approve.tcl
  1. … 7 more files in changeset.
Don't throw an error, when no url2file mapping exists

    • -10
    • +9
    ./acs-tcl/tcl/request-processor-procs.tcl
Remove usage of apm_package_version__version_name_greater in favor of apm_version_names_compare proc as their logics conflict

    • -11
    • +0
    ./acs-tcl/tcl/apm-install-procs-oracle.xql
    • -11
    • +0
    ./acs-tcl/tcl/apm-install-procs-postgresql.xql
Remove usage of apm_package_version.version_name_greater stored procedure in favor of apm_version_names_compare proc, because their logics conflict

    • -3
    • +3
    ./acs-admin/www/apm/version-view-oracle.xql
Unifiy logic for package version comparison

    • -19
    • +0
    ./acs-admin/tcl/apm-admin-procs-oracle.xql
    • -20
    • +0
    ./acs-admin/tcl/apm-admin-procs-postgresql.xql
    • -10
    • +6
    ./acs-admin/tcl/apm-admin-procs.tcl