• last updated 3 hours ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Deprecate 'db_null'

    • -6
    • +10
    ./acs-tcl/tcl/00-database-procs.tcl
Trailing whitespace cleanup

    • -25
    • +23
    ./dotlrn/tcl/community-procs.tcl
dotlrn cache reform: added missing cache flush; added caching of "community_key"

bump version number to 5.10.0d2 and update dependencies

bump version number to 5.10.0d23

parameter::get_from_package_key: check as well in "global" package parameter

and make clear, that lookup from non-singleton packages does not make

sense.

    • -13
    • +36
    ./acs-tcl/tcl/parameter-procs.tcl
fix typos

    • -2
    • +2
    ./acs-tcl/tcl/form-processing-procs.tcl
improve comments, make function private to avoid confusions

improve comment

Make sure variable is an array

no need to call private function

follow usual naming conventions

    • -3
    • +3
    ./acs-tcl/tcl/request-processor-procs.tcl
no need to call private function of other package

    • -2
    • +2
    ./acs-bootstrap-installer/bootstrap.tcl
Ease usage of util_memoize during startup. let util_memoize succeed,

even when the cache is not yet created

    • -22
    • +31
    ./acs-tcl/tcl/memoize-procs-aolserver.tcl
    • -4
    • +13
    ./acs-tcl/tcl/memoize-procs-naviserver.tcl
use separate urlspace for site-node cache to reduce lock contention

prefer inline SQL over generic xql to make apm code usable during initialization

ad_form reform:

- use actual flags instead of parsing arguments all the time

- retrieve proc flags from ad_proc definition (TODO: have some api for this?)

- follow the thread of peculiar ad_form logic to fix new csrf signing feature

- improve documentation using @param instead of manual formatting

- leave some note to travellers in the code

    • -243
    • +229
    ./acs-tcl/tcl/form-processing-procs.tcl
new parameter "fallback_languages":

Specify space delimited two character codes for checking default languages. When this parameter is non-empty, try to get the page in the specified languages as fallback rather than offering a link for creation of a page in the requested locale. Per default this paramter is empty.

Reinstate reworked versions of some oracle database utilities left behind during solution of bug #3302

Rework is based on coding style observed in code provided by Brian Fenton, but could still not be tested. See https://openacs.org/bugtracker/openacs/bug?bug_number=3302

    • -1
    • +187
    ./acs-kernel/sql/oracle/utilities-create.sql
    • -0
    • +353
    ./acs-kernel/sql/oracle/upgrade/upgrade-5.10.0d11-5.10.0d12.sql
Fix typo (thanks to Thomas Renner)

reduce redirects

    • -1
    • +1
    ./acs-authentication/www/doc/configure-batch-sync.adp
    • -2
    • +2
    ./acs-authentication/www/doc/ext-auth-ldap-install.adp
    • -1
    • +1
    ./acs-authentication/www/doc/ext-auth-pam-install.adp
    • -1
    • +1
    ./acs-authentication/www/doc/ims-sync-driver-design.adp
    • -1
    • +1
    ./acs-authentication/www/doc/index.adp
Fix comment

Add flushing of user permissions as well when adding to a new group, extend comments

whitespace and comment changes

    • -6
    • +11
    ./xotcl-request-monitor/tcl/throttle_mod-procs.tcl
- make sure to get rid over overdue elements from statistics

- improve comments

    • -28
    • +37
    ./xotcl-request-monitor/tcl/throttle_mod-procs.tcl
reflow overlong lines in comments

    • -52
    • +75
    ./acs-tcl/tcl/form-processing-procs.tcl
ad_form: Add optional parameter -csrf_protection_p (defaults to false)

    • -5
    • +35
    ./acs-tcl/tcl/form-processing-procs.tcl
white space changes

    • -12
    • +19
    ./acs-tcl/tcl/form-processing-procs.tcl
simplify code

    • -13
    • +3
    ./acs-tcl/tcl/form-processing-procs.tcl
Cleanup not more relevant comments, remove idiom meant to work in the context of a db_with_handle we are not using anymore