• last updated 8 hours ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Whitespace changes

    • -12
    • +18
    ./acs-tcl/lib/check-installed.tcl
Add missing parameter to include doc

fix documentation bug #3369

Add ad_include_contract and documentation to this page

    • -0
    • +10
    ./file-storage/lib/folder-admin.tcl
Use ad_include_contract on this page

Replace custom arg checks with proper ad_include_contract

    • -42
    • +25
    ./acs-tcl/lib/static-progress-bar.tcl
Fix doc

    • -3
    • +2
    ./acs-templating/tcl/deprecated-procs.tcl
Add @see in deprecated proc

    • -1
    • +3
    ./acs-templating/tcl/deprecated-procs.tcl
    • -1
    • +3
    ./acs-datetime/tcl/acs-datetime-procs.tcl
Add some @see in deprecated procs

Fix contract doc

Use ad_include_contract and revise current usages (e.g. write_p was not used anywhere)

Use ad_include_contract on this page

Bring all sql inline

Replace silent catch idiom

Use ad_include_contract

Whitespace changes

    • -16
    • +16
    ./acs-content-repository/tcl/content-procs.tcl
Add missing 'title' parameter to 'content::item::upload_file', which is checked in the proc and probably not materialized out of thin air.

    • -9
    • +7
    ./acs-content-repository/tcl/content-item-procs.tcl
Use '::content::item::get_content_type' instead of the deprecated '::content::item::content_type'

    • -2
    • +2
    ./project-manager/tcl/project-manager-callback-procs.tcl
add procdic for private function

Cookie security reform:

- fix handling of persistent logins while addressing problems of last commits

- increase usage of try/throw to be able to distinguish exceptions

- fix handling of LoginTimeout 0 in cryptographic expiration

- use [ad_conn behind_secure_proxy_p] on more occasions, where

security::secure_conn_p is used (maybe fold these together in the future)

- new private proc security::log to ease debugging of cookie management

- further improved documentation

    • -126
    • +197
    ./acs-tcl/tcl/security-procs.tcl
provide ip address to be stored in acs_objects on save operation

improve comments

    • -2
    • +4
    ./acs-authentication/tcl/authentication-procs.tcl
whitespace changes

    • -12
    • +10
    ./acs-authentication/tcl/authentication-procs.tcl
prefer dict over Tcl array

reduce redundant lookups in auth::check_local_account_status

    • -18
    • +28
    ./acs-authentication/tcl/authentication-procs.tcl
Use '::content::item::get_content_type' instead of the deprecated '::content::item::content_type'

    • -2
    • +2
    ./acs-content-repository/tcl/content-item-procs.tcl
Use '::content::item::get_content_type' instead of the deprecated '::content::item::content_type'

    • -2
    • +2
    ./acs-content-repository/tcl/content-revision-procs.tcl
Trailing whitespace cleanup

    • -2
    • +2
    ./acs-content-repository/tcl/content-item-procs.tcl
Deprecate '::content::item::content_type', which is exactly the same proc as 'content::item::get_content_type'. Weird.

    • -15
    • +12
    ./acs-content-repository/tcl/content-item-procs.tcl
Wrap legacy and current ns_http api behavior in a proc with a common interface in a way that people with newer Naviserver can exploit e.g. ns_http run capabilities (in particular, not being forced to queue and potentially block concurrent HTTP requests)

    • -54
    • +118
    ./acs-tcl/tcl/http-client-procs.tcl
- fix serveral documentation bugs (align decumentation with implementation)

- use "throw" as well for invalid cookies (in addition to non-existent cookies)

    • -23
    • +51
    ./acs-tcl/tcl/security-procs.tcl