• last updated 5 hours ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Fix parameter name

Allow square brackets in proc doc. In particular, this fixed a false positive with [doc_string] in 'ad_proc'

    • -2
    • +1
    ./acs-tcl/tcl/test/doc-check-procs.tcl
Improve 'args' check in 'documentation__check_parameters' test case by using the built-in 'varargs_p' variable.

    • -4
    • +2
    ./acs-tcl/tcl/test/doc-check-procs.tcl
Sanitize date stings for parsability with clock scan and allow HTTPS requests using 'util::http::post' (many thanks to Markus Moser).

Add 'args' parameter to the real parameter list of the 'documentation__check_parameters', as it is not included into 'switches' or 'positionals'.

    • -1
    • +13
    ./acs-tcl/tcl/test/doc-check-procs.tcl
Use 'apm_get_package_files -file_types' instead of filtering the 'www' and 'lib' directories manually.

    • -10
    • +10
    ./acs-tcl/tcl/test/file-test-procs.tcl
Take care of '_p' boolean parameters when checking for discrepancies between real and documented proc parameters.

    • -9
    • +11
    ./acs-tcl/tcl/test/doc-check-procs.tcl
- add the detail-link only when necessary

- include the email address properly

    • -4
    • +4
    ./acs-automated-testing/tcl/aa-test-procs.tcl
Overhaul of test cases:

- make tested API calls explict

- reduce dependency on twt

    • -9
    • +16
    ./acs-tcl/tcl/test/acs-tcl-apm-procs.tcl
    • -5
    • +11
    ./acs-tcl/tcl/test/ad-proc-test-procs.tcl
    • -1
    • +98
    ./acs-tcl/tcl/test/apm-parameter-test-procs.tcl
    • -113
    • +141
    ./acs-tcl/tcl/test/application-data-link-procs.tcl
    • -15
    • +33
    ./acs-tcl/tcl/test/datamodel-test-procs.tcl
    • -3
    • +60
    ./acs-tcl/tcl/test/doc-check-procs.tcl
    • -26
    • +64
    ./acs-tcl/tcl/test/file-test-procs.tcl
    • -29
    • +174
    ./acs-tcl/tcl/test/html-conversion-procs.tcl
    • -1
    • +4
    ./acs-tcl/tcl/test/html-email-procs.tcl
    • -2
    • +8
    ./acs-tcl/tcl/test/memoizing-procs.tcl
    • -41
    • +24
    ./acs-tcl/tcl/test/navigation-procs.tcl
    • -8
    • +6
    ./acs-tcl/tcl/test/object-test-case-procs.tcl
    • -12
    • +20
    ./acs-tcl/tcl/test/openacs-kernel-procs.tcl
    • -12
    • +21
    ./acs-tcl/tcl/test/test-membership-rel-procs.tcl
  1. … 4 more files in changeset.
Add call graph information based on static analysis to API doc. This information

is computed on a best-effor bases and not necessarily complete, since static analysis

of a dyamic language is limited; furthermore, direct calls from web pages are not included

for activation, see tcl/api-doc-init.tcl

    • -2
    • +2
    ./acs-api-browser/acs-api-browser.info
    • -108
    • +373
    ./acs-api-browser/tcl/acs-api-documentation-procs.tcl
    • -0
    • +24
    ./acs-api-browser/tcl/api-doc-init.tcl
Fix parameter name in proc documentation

Whitespace changes

    • -170
    • +170
    ./acs-bootstrap-installer/tcl/00-proc-procs.tcl
Fix misleading and uncoherent 'ad_dispatch' proc documentation, discovered using the 'documentation__check_parameters' test.

    • -6
    • +7
    ./acs-bootstrap-installer/tcl/00-proc-procs.tcl
don't leak user_ids from regression test case

make tested API calls explicit

    • -4
    • +19
    ./acs-tcl/tcl/test/acs-tcl-test-procs.tcl
    • -3
    • +4
    ./acs-tcl/tcl/test/navigation-procs.tcl
    • -7
    • +23
    ./acs-tcl/tcl/test/site-nodes-test-procs.tcl
prefer built-in ns_dbquotevalue over DoubleApos

    • -6
    • +2
    ./webmail/www/message-send-add-attachment.tcl
improve spelling

modernize Tcl

normalize boolean expressions in .adp files

prefer built-in ns_dbquotevalue over DoubleApos

    • -3
    • +3
    ./ecommerce/tcl/ecommerce-widgets-procs.tcl
    • -3
    • +2
    ./ecommerce/www/admin/customer-service/index.tcl
    • -2
    • +2
    ./ecommerce/www/admin/email-templates/add-2.tcl
    • -2
    • +2
    ./ecommerce/www/admin/email-templates/edit-2.tcl
    • -3
    • +3
    ./ecommerce/www/admin/retailers/add-3.tcl
    • -3
    • +3
    ./ecommerce/www/admin/retailers/edit-2.tcl
    • -2
    • +2
    ./ecommerce/www/admin/templates/add-3.tcl
    • -2
    • +2
    ./ecommerce/www/admin/templates/delete-2.tcl
    • -2
    • +2
    ./ecommerce/www/admin/user-classes/add-2.tcl
  1. … 3 more files in changeset.
normalize boolean expressions in .adp files

    • -7
    • +7
    ./ecommerce/www/checkout-one-form-2.tcl
    • -1
    • +1
    ./ecommerce/www/gift-certificate-claim-2.adp
    • -2
    • +2
    ./ecommerce/www/shopping-cart-oracle.xql
    • -1
    • +2
    ./ecommerce/www/admin/customer-reviews/one.tcl
  1. … 20 more files in changeset.
prefer built-in ns_dbquotevalue over DoubleApos

make former private functions, used in several packages to public functions

    • -3
    • +3
    ./acs-tcl/tcl/tcl-documentation-procs.tcl
prefer built-in ns_dbquotevalue over DoubleApos

    • -3
    • +3
    ./acs-templating/tcl/paginator-procs.tcl
    • -2
    • +2
    ./acs-templating/tcl/richtext-procs.tcl
remove single quotes

    • -2
    • +2
    ./acs-subsite/tcl/plsql-utility-procs.tcl
prefer built-in ns_dbquotevalue over DoubleApos

    • -2
    • +2
    ./acs-subsite/tcl/plsql-utility-procs.tcl
improve spelling

    • -2
    • +2
    ./acs-bootstrap-installer/tcl/30-apm-load-procs.tcl
Add new test case 'documentation__check_parameters', which checks if parameters defined in the proc doc (@param) are really proc parameters.

Sometimes proc parameter changes are not reflected in the proc doc, this should take care of some of these cases.

    • -1
    • +62
    ./acs-tcl/tcl/test/doc-check-procs.tcl
Fix @param names

    • -4
    • +4
    ./acs-service-contract/tcl/acs-service-contract-procs.tcl
improve spelling

    • -2
    • +2
    ./categories/tcl/category-xml-procs.tcl