OpenACS / openacs-4

packages

Tools

Line History

Line Count Graph
Line Count Graph

Stats

Commits this week: 6
Total Committers: 138
Last Commit: 02 Jul
Commits this week: 6
Total Lines of Code (LoC): 5,106,955
Net change in LoC this week: 0

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated 20 hours ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Wednesday 25 Jul 2018
5:10 am

gustafn

don't leak user_ids from regression test case

Options
    • -10
    • +9
    ./acs-tcl/tcl/test/community-core-test-procs.tcl
4:51 am

gustafn

make tested API calls explicit

Options
    • -4
    • +19
    ./acs-tcl/tcl/test/acs-tcl-test-procs.tcl
    • -3
    • +4
    ./acs-tcl/tcl/test/navigation-procs.tcl
    • -7
    • +23
    ./acs-tcl/tcl/test/site-nodes-test-procs.tcl
4:27 am

gustafn

prefer built-in ns_dbquotevalue over DoubleApos

Options
    • -2
    • +2
    ./webmail/www/message-send-2.tcl
    • -6
    • +2
    ./webmail/www/message-send-add-attachment.tcl
4:19 am

gustafn

improve spelling

Options
    • -2
    • +2
    ./webmail/www/message-send-2.tcl
4:19 am

gustafn

modernize Tcl

Options
    • -2
    • +2
    ./webmail/tcl/wm-util-procs.tcl
4:17 am

gustafn

normalize boolean expressions in .adp files

Options
    • -2
    • +2
    ./scorm-player/embed/player.adp
4:09 am

gustafn

prefer built-in ns_dbquotevalue over DoubleApos

Options
    • -3
    • +3
    ./ecommerce/tcl/ecommerce-widgets-procs.tcl
    • -3
    • +2
    ./ecommerce/www/admin/customer-service/actions.tcl
    • -3
    • +2
    ./ecommerce/www/admin/customer-service/index.tcl
    • -2
    • +2
    ./ecommerce/www/admin/customer-service/interaction-add-2.tcl
    • -3
    • +2
    ./ecommerce/www/admin/customer-service/issues.tcl
    • -3
    • +3
    ./ecommerce/www/admin/customer-service/statistics.tcl
    • -2
    • +2
    ./ecommerce/www/admin/email-templates/add-2.tcl
    • -2
    • +2
    ./ecommerce/www/admin/email-templates/edit-2.tcl
    • -3
    • +3
    ./ecommerce/www/admin/retailers/add-3.tcl
    • -3
    • +3
    ./ecommerce/www/admin/retailers/edit-2.tcl
    • -2
    • +2
    ./ecommerce/www/admin/templates/add-3.tcl
    • -2
    • +2
    ./ecommerce/www/admin/templates/delete-2.tcl
    • -2
    • +2
    ./ecommerce/www/admin/user-classes/add-2.tcl
    • -2
    • +2
    ./ecommerce/www/admin/user-classes/approve-toggle.tcl
    • -3
    • +3
    ./ecommerce/www/admin/user-classes/member-add-2.tcl
  16. … 3 more files in changeset.
3:52 am

gustafn

normalize boolean expressions in .adp files

Options
    • -1
    • +1
    ./ecommerce/lib/checkout-progress.adp
    • -1
    • +1
    ./ecommerce/lib/contextbar.adp
    • -1
    • +1
    ./ecommerce/lib/share-bar.adp
    • -1
    • +1
    ./ecommerce/lib/toolbar.adp
    • -7
    • +7
    ./ecommerce/www/checkout-one-form-2.tcl
    • -1
    • +1
    ./ecommerce/www/checkout-one-form.adp
    • -1
    • +1
    ./ecommerce/www/gift-certificate-claim-2.adp
    • -1
    • +1
    ./ecommerce/www/payment.adp
    • -1
    • +1
    ./ecommerce/www/product.tcl
    • -2
    • +2
    ./ecommerce/www/shopping-cart-oracle.xql
    • -3
    • +3
    ./ecommerce/www/shopping-cart.adp
    • -1
    • +2
    ./ecommerce/www/admin/audit-table.tcl
    • -1
    • +1
    ./ecommerce/www/admin/index.adp
    • -1
    • +2
    ./ecommerce/www/admin/customer-reviews/one.tcl
    • -2
    • +2
    ./ecommerce/www/admin/customer-service/interaction-add-3.tcl
  16. … 20 more files in changeset.
3:50 am

gustafn

prefer built-in ns_dbquotevalue over DoubleApos

Options
    • -6
    • +4
    ./acs-tcl/tcl/00-database-procs.tcl
    • -2
    • +2
    ./acs-tcl/tcl/json-procs.tcl
    • -8
    • +14
    ./acs-tcl/tcl/utilities-procs.tcl
3:38 am

gustafn

make former private functions, used in several packages to public functions

Options
    • -3
    • +3
    ./acs-tcl/tcl/00-database-procs.tcl
    • -4
    • +4
    ./acs-tcl/tcl/apm-file-procs.tcl
    • -2
    • +2
    ./acs-tcl/tcl/apm-xml-procs.tcl
    • -3
    • +3
    ./acs-tcl/tcl/exception-procs.tcl
    • -3
    • +3
    ./acs-tcl/tcl/tcl-documentation-procs.tcl
3:35 am

gustafn

prefer built-in ns_dbquotevalue over DoubleApos

Options
    • -2
    • +2
    ./acs-templating/tcl/list-procs.tcl
    • -3
    • +3
    ./acs-templating/tcl/paginator-procs.tcl
    • -2
    • +2
    ./acs-templating/tcl/richtext-procs.tcl
    • -3
    • +3
    ./acs-templating/tcl/util-procs.tcl
3:28 am

gustafn

remove single quotes

Options
    • -4
    • +4
    ./acs-subsite/tcl/package-procs.tcl
    • -2
    • +2
    ./acs-subsite/tcl/plsql-utility-procs.tcl
3:20 am

gustafn

prefer built-in ns_dbquotevalue over DoubleApos

Options
    • -4
    • +4
    ./acs-subsite/tcl/package-procs.tcl
    • -2
    • +2
    ./acs-subsite/tcl/plsql-utility-procs.tcl
Tuesday 24 Jul 2018
9:42 pm

gustafn

improve spelling

Options
    • -2
    • +2
    ./acs-bootstrap-installer/tcl/30-apm-load-procs.tcl
    • -2
    • +7
    ./acs-tcl/tcl/security-procs.tcl
    • -2
    • +2
    ./acs-templating/tcl/parse-procs.tcl
9:29 pm

hectorr

Add new test case 'documentation__check_parameters', which checks if parameters defined in the proc doc (@param) are really proc parameters.

Sometimes proc parameter changes are not reflected in the proc doc, this should take care of some of these cases.

Options
    • -1
    • +62
    ./acs-tcl/tcl/test/doc-check-procs.tcl
9:12 pm

hectorr

Fix @param names

Options
    • -4
    • +4
    ./acs-service-contract/tcl/acs-service-contract-procs.tcl
    • -4
    • +2
    ./xowiki/tcl/package-procs.tcl
9:04 pm

gustafn

improve spelling

Options
    • -5
    • +5
    ./dotlrn/tcl/community-procs.tcl
    • -2
    • +2
    ./dotlrn/www/subcommunity-new.tcl
    • -2
    • +2
    ./categories/tcl/category-xml-procs.tcl
    • -2
    • +2
    ./categories/www/doc/o.adp
    • -1
    • +1
    ./general-comments/www/doc/design.adp
    • -2
    • +2
    ./acs-core-docs/www/xml/developers-guide/db-api.xml
    • -5
    • +5
    ./acs-core-docs/www/xml/developers-guide/tutorial-advanced.xml
    • -1
    • +1
    ./acs-core-docs/www/xml/install-guide/other-software.xml
8:54 pm

gustafn

use consistently bind variables

Options
    • -4
    • +5
    ./forums/lib/message/row2.tcl
8:46 pm

gustafn

improve spelling

Options
    • -3
    • +3
    ./xotcl-core/tcl/05-db-procs.tcl
    • -2
    • +2
    ./xotcl-core/tcl/cr-procs.tcl
    • -2
    • +2
    ./xowiki/tcl/xowiki-www-procs.tcl
7:57 pm

gustafn

improve spelling

Options
    • -3
    • +3
    ./acs-tcl/tcl/apm-install-procs.tcl
7:19 pm

gustafn

port all former tclwebtest test cases to acs::test and do some more detailed testing

Options
    • -3
    • +3
    ./forums/forums.info
    • -116
    • +57
    ./forums/tcl/test/forums-procs.tcl
    • -290
    • +0
    ./forums/tcl/test/tclwebtest-procs.tcl
    • -61
    • +196
    ./forums/tcl/test/webtest-procs.tcl
7:18 pm

gustafn

acs-automated testing:

- provide the ability to add detail urls to messages

- new convenince methods

acs::test::reply_contains

acs::test::reply_contains_no

Options
    • -2
    • +2
    ./acs-automated-testing/acs-automated-testing.info
    • -1
    • +43
    ./acs-automated-testing/tcl/aa-test-procs.tcl
    • -4
    • +4
    ./acs-automated-testing/www/admin/testcase.adp
    • -6
    • +15
    ./acs-automated-testing/www/admin/testcase.tcl
5:49 pm

hectorr

Fix spelling

Options
    • -2
    • +2
    ./new-portal/tcl/portal-procs.tcl
5:48 pm

hectorr

Improve the list of common typos for the 'documentation__check_typos' test case, including some from Wikipedia: https://en.wikipedia.org/wiki/Wikipedia:Lists_of_common_misspellings/For_machines

Options
    • -1
    • +3354
    ./acs-tcl/tcl/test/doc-check-procs-common-typos.txt
4:59 pm

hectorr

Remove apparent leftover + trailing whitespace

Options
    • -4
    • +3
    ./acs-tcl/tcl/test/doc-check-procs.tcl
4:47 pm

hectorr

Add new test case 'files__page_contracts', which checks for the existance of both 'ad_page_contract' and 'ad_include_contract' in the .tcl files inside 'www' and 'lib' package directories.

There are cases, where includelets are not stored in 'lib' but 'www', or have 'ad_page_contract' instead of 'ad_include_contract'. Checking if the location of includelets is correct is not so clear, so we avoid doing this in this particular test.

Options
    • -1
    • +78
    ./acs-tcl/tcl/test/file-test-procs.tcl
4:37 pm

gustafn

add tested API calls to testcases

Options
    • -5
    • +5
    ./forums/tcl/test/forums-procs.tcl
4:37 pm

gustafn

modernize Tcl

Options
    • -8
    • +12
    ./forums/www/forum-view.tcl
4:36 pm

gustafn

display testd URLs on testcases for web tests

Options
    • -2
    • +3
    ./acs-automated-testing/tcl/aa-test-procs.tcl
    • -0
    • +4
    ./acs-automated-testing/www/admin/testcase.adp
    • -4
    • +15
    ./acs-automated-testing/www/admin/testcase.tcl
3:13 pm

gustafn

rework test case documentation__check_typos

- make test case more robust (don't abort tests when there is a proc_doc without a "main" section

- improve performance and sanity:

* move invariantes out of the loop

* use built-in hashes

* don't check the same term multiple times

... times went from >15 sec to <1sec

Options
    • -24
    • +39
    ./acs-tcl/tcl/test/doc-check-procs.tcl