• last updated 6 hours ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
fix documentation

    • -2
    • +2
    ./acs-tcl/tcl/tcl-documentation-procs.tcl
Replace "wrap_string" by "ns_reflow_text", where the latter is a

builtin of newer versions of NaviServer. When "ns_reflow_text" is not

available, provide a scripted version for it.

wrap_string is marked as deprecated, since it has no proper prefix,

and is less powerful than ns_reflow_text

    • -44
    • +60
    ./acs-tcl/tcl/text-html-procs.tcl
    • -1
    • +1
    ./sloan-bboard/www/message-threaded.adp
Improve scalability by reducing the number of locks on ad_page_contract_filters (this nsv receives the most locks on e.g. openacs.org)

    • -14
    • +22
    ./acs-tcl/tcl/tcl-documentation-procs.tcl
Use acs_magic_object instead of acs_lookup_magic_object

    • -2
    • +2
    ./acs-tcl/tcl/community-core-procs.tcl
    • -2
    • +2
    ./acs-tcl/tcl/request-processor-procs.tcl
reduce stress on util_memoize cache by using per-thread cache for magic objects

reduce stress on util_memoize_cache by using per-thread cache for acs::version number

Add files missed by last commit

    • -0
    • +27
    ./acs-admin/www/auth/login-attempts-reset.tcl
    • -0
    • +11
    ./acs-admin/www/auth/login-attempts.adp
    • -0
    • +67
    ./acs-admin/www/auth/login-attempts.tcl
    • -0
    • +133
    ./acs-authentication/tcl/authentication-procs-aolserver.tcl
    • -0
    • +92
    ./acs-authentication/tcl/authentication-procs-naviserver.tcl
- Add new feature to prevent/slowdown brute force attacks on login by counting the number of

failed consecutive login attempts based on ip-address and subsite.

- Add new package dependency: package "acs-admin" now requires "acs-authentication"

    • -2
    • +4
    ./acs-authentication/acs-authentication.info
    • -0
    • +1
    ./acs-authentication/catalog/acs-authentication.de_DE.ISO-8859-1.xml
    • -0
    • +1
    ./acs-authentication/catalog/acs-authentication.en_US.ISO-8859-1.xml
    • -7
    • +119
    ./acs-authentication/tcl/authentication-procs.tcl
Reduce stress on util_memoize_cache by removing the - by far - most often reused

item in the cache (apm_package_installed_p_not_cached ref-timezones). Instead,

we fall back to the (per-thread) caching of apm_package_id_from_key.

Whitesepace cleanup

    • -72
    • +76
    ./tsearch2-driver/tcl/tsearch2-driver-install-procs.tcl
    • -50
    • +55
    ./tsearch2-driver/tcl/tsearch2-driver-procs.tcl
white space cleanup and removal of unneeded line

    • -19
    • +18
    ./xotcl-core/tcl/50-protocol-handler-procs.tcl
- make sure that length timitation of tsearch vector does not raise errors

- refactor code to avoid redundant logic

- bump version number to 5.10.0d2

    • -2
    • +2
    ./tsearch2-driver/tsearch2-driver.info
    • -10
    • +27
    ./tsearch2-driver/tcl/tsearch2-driver-procs.tcl
Improve handling of unauthorized cases via exception handling

    • -5
    • +15
    ./xotcl-core/tcl/50-protocol-handler-procs.tcl
Improve performance of ::xowiki::datasource, especially for huge text/plain xowiki::Files

complete truncated file

    • -1
    • +10
    ./acs-tcl/tcl/memoize-procs-naviserver.tcl
factor out naviserver and aolserver specific code

    • -0
    • +283
    ./acs-tcl/tcl/utilities-procs-aolserver.tcl
    • -0
    • +191
    ./acs-tcl/tcl/utilities-procs-naviserver.tcl
    • -429
    • +1
    ./acs-tcl/tcl/utilities-procs.tcl
Factor out code for navisever and aolserver

    • -0
    • +120
    ./acs-tcl/tcl/memoize-procs-aolserver.tcl
    • -0
    • +117
    ./acs-tcl/tcl/memoize-procs-naviserver.tcl
fix adp expression

    • -2
    • +2
    ./categories/www/cadmin/object-map.tcl
reduce error-message swallowing: remove catch operations to trigger error messages, when something goes wrong on the OS-level

fix internal redirection to beautified error pages in connection with host-node-mapped subsites

    • -6
    • +17
    ./acs-tcl/tcl/request-processor-procs.tcl
clean up expression: no need to use backslashes in tcl expression

    • -7
    • +7
    ./acs-tcl/tcl/tcl-documentation-procs.tcl
Upgrade fix

Execute cleanup only if explicitly uncommented, as might have performance implications.

Also, correct unaligned constraint names in old instances upgraded incrementally over the years.

Fix current date UTC query

    • -1
    • +1
    ./acs-lang/www/admin/set-system-timezone.xql
Add missing change in the data model from previous commit

Portrait management reform and correction

Moved logics to create a portrait in a proc in order to reuse it in other places

such as picture retrieval services (e.g. Bach picture retrieval at WU). Turns out

we were not doing our homeworks here: when the portrait is created into CR, a

cr_child_rel is created. When the portrait was erased though, this was not cleaned

up propely, leaving dangling acs_objects with no reference in cr_child_rels table.

On busy sites, this can grow in the ten thousands order of magnitude. Changes include

also fix for this behavior and tuples cleanup.

    • -2
    • +2
    ./acs-content-repository/acs-content-repository.info
    • -0
    • +77
    ./acs-content-repository/sql/postgresql/upgrade/upgrade-5.10.0d4-5.10.0d5.sql
    • -0
    • +80
    ./acs-kernel/sql/postgresql/upgrade/upgrade-5.10.0d3-5.10.0d4.sql
    • -16
    • +6
    ./acs-subsite/www/user/portrait/index.tcl
    • -75
    • +15
    ./acs-subsite/www/user/portrait/upload.tcl
    • -38
    • +0
    ./acs-subsite/www/user/portrait/upload.xql
    • -1
    • +14
    ./acs-tcl/tcl/community-core-procs-oracle.xql
    • -0
    • +16
    ./acs-tcl/tcl/community-core-procs-postgresql.xql
    • -7
    • +63
    ./acs-tcl/tcl/community-core-procs.tcl
    • -10
    • +0
    ./acs-tcl/tcl/community-core-procs.xql
avoid errors, when connection is already closed

    • -1
    • +8
    ./cookie-consent/tcl/cookie-consent-procs.tcl
fix more spelling issues

    • -4
    • +4
    ./acs-mail-lite/tcl/email-inbound-procs.tcl
    • -2
    • +2
    ./acs-mail-lite/tcl/imap-inbound-procs.tcl
    • -2
    • +2
    ./acs-mail-lite/www/doc/analysis-notes.adp
remove spurious "expr" in "expr"

simplfy expressions (no need for backslash), standardize writing of RFC

    • -2
    • +2
    ./acs-mail-lite/tcl/acs-mail-lite-procs.tcl
    • -48
    • +55
    ./acs-mail-lite/tcl/email-inbound-procs.tcl
    • -16
    • +18
    ./acs-mail-lite/tcl/imap-inbound-procs.tcl
    • -9
    • +9
    ./acs-mail-lite/tcl/maildir-inbound-procs.tcl
fix spelling

    • -1
    • +1
    ./acs-mail-lite/www/doc/imap-install.adp
    • -1
    • +1
    ./acs-mail-lite/www/doc/incoming-email-legacy-notes.adp