• last updated 3 hours ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Fix backslashes

    • -3
    • +2
    ./acs-automated-testing/tcl/test/acs-automated-testing-procs.tcl
Remove ns_parseurl from list of tested procs, as not being a openacs proc will trigger an error at load time

Test also the portrait api (exploit the fact that we are already creating bogus users), move helper procs to the beginning so they can be found by the testing machinery

    • -28
    • +53
    ./acs-authentication/tcl/test/acs-authentication-procs.tcl
Trim whitespace

    • -64
    • +64
    ./acs-authentication/tcl/test/acs-authentication-procs.tcl
Cache the portrait in the right cache (Thanks to Felix Mödritscher)

    • -2
    • +2
    ./acs-tcl/tcl/community-core-procs.tcl
Translation of file descriptor must be binary as well when flushing in-memory payload to the spool file, or we would corrupt this content

util::http performance improvements:

- cache util::http::available as namespace variable, as in the worst case it would go to the db

- replace array idioms with dict idioms

    • -62
    • +69
    ./acs-tcl/tcl/http-client-procs.tcl
Trim whitespace

    • -11
    • +11
    ./acs-tcl/tcl/http-client-procs.tcl
fix backslashes

    • -2
    • +2
    ./acs-content-repository/tcl/test/acs-content-repository-procs.tcl
    • -2
    • +2
    ./acs-content-repository/tcl/test/content-image-test-procs.tcl
overwork test cases: moderinze tests, make tested api functions explicit

    • -2
    • +12
    ./acs-automated-testing/tcl/test/acs-automated-testing-procs.tcl
    • -2
    • +10
    ./acs-content-repository/tcl/test/acs-content-repository-procs.tcl
    • -59
    • +65
    ./acs-content-repository/tcl/test/content-folder-test-procs.tcl
    • -4
    • +24
    ./acs-content-repository/tcl/test/content-image-test-procs.tcl
    • -23
    • +36
    ./acs-content-repository/tcl/test/content-item-test-procs.tcl
    • -27
    • +35
    ./acs-content-repository/tcl/test/content-keyword-test-procs.tcl
    • -8
    • +22
    ./acs-content-repository/tcl/test/content-revision-test-procs.tcl
    • -15
    • +32
    ./acs-content-repository/tcl/test/content-search-procs.tcl
Trim whitespace

    • -3
    • +3
    ./news-aggregator/www/subscriptions.tcl
Repair form validation of URL

    • -5
    • +5
    ./news-aggregator/www/subscriptions.tcl
New test to check whether configured news feeds look ok

    • -2
    • +2
    ./news-aggregator/tcl/source-procs.tcl
Fix typo or this file would not load

    • -1
    • +1
    ./acs-lang/tcl/test/acs-lang-test-procs.tcl
fix typo

Trim whitespace

    • -2
    • +2
    ./news-aggregator/tcl/install-procs.tcl
Fix typo

    • -1
    • +1
    ./acs-tcl/tcl/test/acs-tcl-apm-procs.tcl
Replace array idioms with dict idioms

    • -24
    • +20
    ./acs-tcl/tcl/site-nodes-procs.tcl
whitespace changes

    • -3
    • +3
    ./acs-automated-testing/tcl/aa-test-procs.tcl
since test case ids are only significant per package_key, record such pairs in procdoc data structure

    • -4
    • +9
    ./acs-automated-testing/tcl/aa-test-procs.tcl
don't raise error on wrong inputs

    • -1
    • +6
    ./acs-automated-testing/www/admin/testcase.tcl
Display warnings in the test results page

    • -3
    • +15
    ./acs-automated-testing/www/admin/index.adp
    • -20
    • +28
    ./acs-automated-testing/www/admin/index.tcl
improve testcases by removing useless expr commands

    • -1
    • +1
    ./new-portal/tcl/test/new-portal-test-procs.tcl
    • -5
    • +5
    ./oacs-dav/tcl/test/oacs-dav-procs.tcl
    • -10
    • +10
    ./views/tcl/test/views-procs.tcl
    • -3
    • +3
    ./workflow/tcl/test/workflow-test-procs.tcl
update tutorial: don't recommend to use "expr" for aa_true or aa_false

procdoc change: Preserve pre-existing values, e.g. from testcases, which might be loaded in a different order (testcase might be loaded before proc)

.CVS: ----------------------------------------------------------------------

    • -2
    • +16
    ./acs-bootstrap-installer/tcl/00-proc-procs.tcl
improve testcases by removing useless expr commands

    • -3
    • +7
    ./acs-admin/tcl/test/acs-admin-procs.tcl
    • -19
    • +19
    ./acs-authentication/tcl/test/acs-authentication-procs.tcl
    • -21
    • +21
    ./acs-authentication/tcl/test/sync-test-procs.tcl
    • -3
    • +3
    ./acs-content-repository/tcl/test/acs-content-repository-procs.tcl
    • -2
    • +2
    ./acs-content-repository/tcl/test/content-folder-test-procs.tcl
    • -10
    • +10
    ./acs-content-repository/tcl/test/content-image-test-procs.tcl
    • -15
    • +15
    ./acs-content-repository/tcl/test/content-item-test-procs.tcl
    • -2
    • +2
    ./acs-content-repository/tcl/test/content-keyword-test-procs.tcl
    • -6
    • +6
    ./acs-content-repository/tcl/test/content-revision-test-procs.tcl
    • -4
    • +4
    ./acs-content-repository/tcl/test/content-search-procs.tcl
    • -7
    • +7
    ./acs-lang/tcl/test/acs-lang-test-procs.tcl
    • -2
    • +2
    ./acs-subsite/tcl/test/acs-subsite-procs.tcl
    • -11
    • +11
    ./acs-templating/tcl/test/spell-checker-procs.tcl
    • -2
    • +2
    ./dotlrn-ecommerce/tcl/test/dotlrn-ecommerce-procs.tcl
    • -5
    • +5
    ./dotlrn-fs/tcl/test/dotlrn-fs-procs.tcl
  1. … 3 more files in changeset.
make tested procs explicit

    • -10
    • +101
    ./acs-authentication/tcl/test/acs-authentication-procs.tcl
    • -15
    • +94
    ./acs-authentication/tcl/test/sync-test-procs.tcl
improve testcases by removing useless expr commands

    • -3
    • +3
    ./acs-tcl/tcl/test/acs-tcl-test-procs.tcl
    • -7
    • +7
    ./acs-tcl/tcl/test/ad-proc-test-procs.tcl
    • -14
    • +14
    ./acs-tcl/tcl/test/application-data-link-procs.tcl
    • -3
    • +6
    ./acs-tcl/tcl/test/doc-check-procs.tcl
    • -16
    • +16
    ./acs-tcl/tcl/test/test-permissions-procs.tcl
    • -5
    • +5
    ./acs-tcl/tcl/test/whos-online-procs.tcl
make feedback from testruns nicer (remove redundant messages)

    • -10
    • +8
    ./acs-automated-testing/tcl/aa-test-procs.tcl
Declass constraint names breaking the very strict OpenACS naming convention from errors to warnings

Rationale: it is sometimes impossible to have constraint names that are both < 30 chars and consistent with the naming scheme 'table_name'_'column_name'_'constraint_type' for all those defined on a particular table (see e.g. acs_named_objects).

Breaking this convention might be suboptimal, but is not harmful in itself.

    • -2
    • +2
    ./acs-tcl/tcl/test/datamodel-test-procs.tcl