OpenACS / openacs-4 / packages

xowiki

Tools

Line History

Line Count Graph
Line Count Graph

Stats

Commits this week: 2
Total Committers: 14
Last Commit: 14 Nov
Commits this week: 2
Total Lines of Code (LoC): 139,128
Net change in LoC this week: 0

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated 7 hours ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Wednesday 31 Jul
11:59 am

gustafn

improved spelling

Options
    • -3
    • +3
    ./www/xinha/insert-ilink.adp
    • -3
    • +3
    ./www/xinha/insert-image.adp
  3. … 28 more files in changeset.
Monday 29 Jul
2:01 pm

gustafn

js-libraries: improved naming of variables

Changed name "installedVersion" to "configuredVersion", since

the former might lead to the impression, that it refers only

to the locally installed version. Instead, this refers as well

to a CDN version (when available)

Options
    • -2
    • +2
    ./tcl/resource-info-procs.tcl
  2. … 18 more files in changeset.
Sunday 28 Jul
7:41 pm

gustafn

js-libraries: removed variable "resourceUrl"

The variable "resourceUrl" was always used in a single branch but set

for all branches before. To ease maintenance and simplify

comprehension, it was removed.

Options
    • -3
    • +2
    ./tcl/resource-info-procs.tcl
  2. … 10 more files in changeset.
7:08 pm

gustafn

tdom: "dom parse -html" implies the "simple" parser

The flag "-simple" is not needed when parsing with the flag "-html". This meanse

that

dom parse -simple -html ...

is equivalent with

dom parse -html ...

Options
    • -5
    • +5
    ./tcl/xowiki-procs.tcl
    • -2
    • +2
    ./tcl/xowiki-www-procs.tcl
  3. … 2 more files in changeset.
7:00 pm

gustafn

Always use "--" in "dom parse" when document is interpolated

This is a safety measure to make sure that the document parsed is

never confused with an option, when the document starts with a "-". In

the best case, the error message provided by "dom parse" might be

misleading. This might be a problem for user contributed documents

(passed as variables, or return values from functions).

The double dash is supported in tdom since version 0.9.0.

Options
    • -2
    • +2
    ./tcl/form-field-procs.tcl
    • -1
    • +1
    ./tcl/syndicate-procs.tcl
    • -3
    • +3
    ./tcl/xowiki-form-procs.tcl
    • -7
    • +7
    ./tcl/xowiki-procs.tcl
    • -2
    • +2
    ./tcl/xowiki-www-procs.tcl
  6. … 14 more files in changeset.
2:15 pm

gustafn

various small fixes for js libraries

- fixed page contract in case a non-default version is downloaded

- provide always an argument "-version" to resource_info procs

- obtain current version number always via resource_info.installedVersion

(it refers to CDN and locally installed version)

- pass always versionDir via resource_info to ::util::resources::download

- always obtain version_dir from resource_info

Options
    • -3
    • +1
    ./www/sitewide-admin/download.tcl
  2. … 25 more files in changeset.
Thursday 25 Jul
4:24 pm

gustafn

Improved resource information for external libraries

- added vulnerability check for a particular version

- centralized URL generation for cdnjs URLS (will reduce maintenance work, when external URL changes)

- improve behavior when running without an Internet connection

Options
    • -3
    • +1
    ./tcl/resource-info-procs.tcl
  2. … 11 more files in changeset.
Wednesday 24 Jul
7:07 pm

gustafn

bump version numbers to reflect the updated resource-info API in acs-tcl

Options
    • -4
    • +5
    ./xowiki.info
  2. … 6 more files in changeset.
6:31 pm

gustafn

Improved consistency of resource-info for javascript libraries, added vulnarability info

Tested the following cases:

download check

- bootstrap

- bootstrap-icons

- bootstrap-treeview

- ckeditor4

- font-awesome

- highcharts

- cookieconsent2 3.0.3

- cookieconsent2 3.1.1

CDN check

- bootstrap

- bootstrap-icons

- bootstrap-treeview

- font-awesome

- highcharts

- cookieconsent2 3.0.3

- cookieconsent2 3.1.1

Options
    • -2
    • +2
    ./tcl/resource-info-procs.tcl
    • -1
    • +1
    ./www/sitewide-admin/index.tcl
  3. … 8 more files in changeset.
3:38 pm

gustafn

Don't set result variables for "header_stuff"

The method "header_stuff" was changes ages ago to

side-effect via the standard OpenACS template::head

interface rather than outputting to a variable, which

has to be passed around. This change removes some

leftover of this time.

Options
    • -1
    • +1
    ./resources/templates/view-book-no-ajax.tcl
    • -3
    • +3
    ./tcl/package-procs.tcl
Tuesday 23 Jul
6:10 pm

gustafn

Extended resource info dict with explicit version number and an API call to obtain the newest version number

The two new optional resource info fields are

- versionCheckAPI

- installedVersion

These fields are necessary to provide an admin page to check

whether the installed versions are the most recent ones.

Options
    • -2
    • +5
    ./tcl/resource-info-procs.tcl
  2. … 8 more files in changeset.
Friday 19 Jul
1:46 pm

antoniop

Remove xowiki dependency from CKEditor4

Rationale: CKEditor4 is EOL for its free version and the paid LTS version will be discontinued in December 2026.

We now do not set an explicit default for the preferred richtext editor. Instead, the first richtext-* package that will be installed with check whether a preferred editor was chosen. If not, they will set themselves as the xowiki editor. This should not change the behavior for existing installations already using ckeditor4, or a different editor.

Options
    • -4
    • +3
    ./xowiki.info
  2. … 3 more files in changeset.
1:11 pm

gustafn

Fixed several issue with the regression test case

- don't hard-code locales

- don't base decision to perform decimal comma tests on the fact that the locale is enabled

(it might be enabled but not loaded)

- perform test, when a locale with decimal point is enabled and loaded and the locale

of the test user can be set to it

Options
    • -9
    • +23
    ./tcl/test/xowiki-test-procs.tcl
Thursday 18 Jul
12:02 pm

antoniop

Adjust TinyMCE behavior for the cornercase of a nested compound field with inline editor

Options
    • -2
    • +13
    ./tcl/form-field-procs.tcl
9:56 am

antoniop

Unset the "required" HTML5 attribute after the superclass initialization, because the textarea superclass will set it back again otherwise

Options
    • -2
    • +2
    ./tcl/form-field-procs.tcl
Monday 15 Jul
2:04 pm

gustafn

improved spelling

Options
    • -3
    • +3
    ./tcl/form-field-procs.tcl
    • -2
    • +2
    ./tcl/xowiki-www-procs.tcl
  3. … 13 more files in changeset.
Friday 21 Jun
4:17 pm

antoniop

Make "standard" the default preset we apply to richtext editors

This is needed to have consistent site-wide default settings coming from the tcl level, such as connection context information and more.

Options
    • -2
    • +8
    ./tcl/form-field-procs.tcl
  2. … 1 more file in changeset.
1:25 pm

antoniop

Render richtext as div reform

Some richtext editors, such as TinyMCE in inline mode, do not expect

to enhance a textarea, but a div.

We could already override the rendering in the richtext editor

subclass, but this has the consequence that inheritance would be

interrupted. This prevents from plugging behavior in subclasses of the

richtext formfield.

This reform refactors render_richtext_as_div from the richtext

formfield into render_as_div on the textarea class. It also supports a

flag for subclasses to instruct the superclass that they should render

the field as div AFTER the whole inheritance chain was applied.

Options
    • -23
    • +41
    ./tcl/form-field-procs.tcl
12:47 pm

antoniop

Do not assume the repeated field will be attached as a direct child of the observed element

This is not the case in some downstream implementations

Options
    • -4
    • +4
    ./tcl/form-field-procs.tcl
11:35 am

antoniop

Include the attribute to identify a repeated field also when we render richtext as div

Options
    • -2
    • +2
    ./tcl/form-field-procs.tcl
Wednesday 19 Jun
4:08 pm

antoniop

Port of downstream modification in place since at least 2012

When parsing XoWiki links, accept links in the form [[link|| -flag1 flagvalue]], where the label is set to empty.

Options
    • -2
    • +2
    ./tcl/xowiki-procs.tcl
Friday 14 Jun
2:28 pm

antoniop

Port of downstream fix by Markus Moser on live since 2022-09-21

Fix regression after disabled formfield reform

Options
    • -3
    • +5
    ./tcl/form-field-procs.tcl
Friday 31 May
1:48 pm

gustafn

updated jqueryui to latest version

Options
    • -5
    • +5
    ./www/resources/jquery/jquery-ui.css
    • -323
    • +331
    ./www/resources/jquery/jquery-ui.js
    • -4
    • +4
    ./www/resources/jquery/jquery-ui.min.js
1:34 pm

gustafn

improved spelling

Options
    • -2
    • +2
    ./tcl/form-field-procs.tcl
    • -3
    • +3
    ./tcl/xowiki-www-procs.tcl
Wednesday 08 May
2:31 pm

antoniop

Provide a reference to the current object when configuring tinymce

Options
    • -1
    • +7
    ./tcl/form-field-procs.tcl
11:00 am

antoniop

Allow to completely override the imageSelectorDialog URL downstream

Options
    • -2
    • +12
    ./tcl/form-field-procs.tcl
Monday 06 May
4:47 pm

antoniop

Introduce for richtext editors the concept of "preset"

A preset is an abstract set configurations designed to address a specific use case.

An example could be a preset for a "minimal" richtext editor, used in those forms where we want to limit the features a user should have access to. Other presets could address specific usages or applications.

Downstream developers can provide a set of ::richtext::$editor::preset::$preset procs, returning an options dict. This set of options will be merged other local configurations.

The same approach works in ad_forms and xowiki forms.

This also enables the use-case of switching to a different editor maintaining the existing application-specific configurations consistent.

Options
    • -2
    • +34
    ./tcl/form-field-procs.tcl
  2. … 1 more file in changeset.
Thursday 02 May
4:06 pm

antoniop

TinyMCE XoWiki formfield integration

We introduce a new richtext mixin richtext::tinymce, requiring the richtext-tinymce package, currently integrating TinyMCE editor 7.0.1.

This implementation has been tested with regular, repeat, compound and repeatedcompound fields.

Downstream implementations based on this formfield can customize the editor configuration further, e.g. provide custom plugins via the api parameters.

Options
    • -3
    • +3
    ./xowiki.info
    • -1
    • +207
    ./tcl/form-field-procs.tcl
3:13 pm

antoniop

Add a richtext to the test formfields specifications

Options
    • -0
    • +2
    ./tcl/test/xowiki-test-procs.tcl
2:47 pm

antoniop

Move back richtext formfield implementations in form-field-procs

Moving to a different file may affect dependencies defined on form-field-procs that also expect the richtext editor to be loaded. As breaking changes are not desirable now, we revert this reform.

Options
    • -1
    • +527
    ./tcl/form-field-procs.tcl
    • -546
    • +0
    ./tcl/richtext-procs.tcl